Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube should return same IP address after restarting when using hyperkit. #2416

Closed
bpasson opened this issue Jan 11, 2018 · 2 comments
Closed

Comments

@bpasson
Copy link
Contributor

bpasson commented Jan 11, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST

Please provide the following details:

Environment:

Minikube version (use minikube version): 0.24.1

  • OS (e.g. from /etc/os-release): OSX 10.11.6
  • VM Driver: hyperkit
  • ISO version: v0.24.0
  • Install tools:
  • Others:

What happened:
After creating a minikube using minikube start --vm-driver=hyperkit, the minikube gets assigned an IP address. I then stop it and start it again. The minikube gets assigned a different new IP address.

What you expected to happen:
I would expect the minikube to have the same IP address after restarting the minikube.

How to reproduce it (as minimally and precisely as possible):
Run the following commands:

$ minikube start --vm-driver=hyperkit
$ minikube stop
$ minikube start

Output of minikube logs (if applicable):

Anything else do we need to know:
After some investigation I found the hyperkit driver to generate a new random mac-address on every start of the machine. It does this based on a random UUID it generates. Saving the UUID to the configuration and using it upon starting the machine should solve the issue as the same mac address gets generated and thus gets assigned the same IP using DHCP.

Update: I managed to get it working for the hyperkit driver and will submit a pull request.

bpasson added a commit to bpasson/minikube that referenced this issue Jan 11, 2018
…ube configuration to be able to regenerate the same mac address for the machine after restarts to give DHCP a change of assigning the previously used IP address.
dlorenc pushed a commit that referenced this issue Jan 11, 2018
…uration to be able to regenerate the same mac address for the machine after restarts to give DHCP a change of assigning the previously used IP address.
@dlorenc dlorenc closed this as completed Jan 11, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jan 11, 2018

This should be fixed with #2416

@dlorenc
Copy link
Contributor

dlorenc commented Jan 11, 2018

D'oh, #2417 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants