Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubernetes-incubator/external-storage for dynamic provisioning (deprecate r2d4 storage-provisioner) #3628

Closed
jayunit100 opened this issue Feb 5, 2019 · 12 comments
Closed

Use kubernetes-incubator/external-storage for dynamic provisioning (deprecate r2d4 storage-provisioner) #3628

jayunit100 opened this issue Feb 5, 2019 · 12 comments
Assignees
@josedonizetti
Labels
addon/storage-provisioner Issues relating to storage provisioner addon help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@jayunit100
Copy link
Member

It looks like we use r2d4's fork of https://github.com/kubernetes-incubator/external-storage/ .... for the dynamic provisioner, should we be using the canonical upstream ?
@jayunit100 jayunit100 changed the title Use kubernetes-incubator/external-storage Use kubernetes-incubator/external-storage for dynamic provisioning Feb 5, 2019
@afbjorklund
Copy link
Collaborator

Yikes, This branch is 19 commits ahead, 1480 commits behind kubernetes-incubator:master.

On the other hand, it seems to have moved (or at least the lib directory, and the "leaderelection")

https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner

https://github.com/kubernetes/client-go/tree/master/tools/leaderelection

Definitely something to consider, when updating to the new CSI standard... ? (for 1.13 and beyond)

https://github.com/kubernetes-csi/drivers/tree/master/pkg/hostpath

@tstromberg tstromberg added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/code-deps Code dependencies (guest-vm deps belong in guest-vm) labels Feb 5, 2019
@tstromberg
Copy link
Contributor

Sounds good to me! I'll happily approve a PR that does this.

@jayunit100
Copy link
Member Author

The move to CSI might be a better way to do this... given that external-storage is deprecated.

@afbjorklund
Copy link
Collaborator

It probably needs to be optional (especially for older k8s), similar to the way that CNI is now.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2019
@tstromberg tstromberg added r/2019q2 Issue was last reviewed 2019q2 and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2019
@tstromberg tstromberg added the addon/storage-provisioner Issues relating to storage provisioner addon label Jul 17, 2019
@tstromberg tstromberg changed the title Use kubernetes-incubator/external-storage for dynamic provisioning Use kubernetes-incubator/external-storage for dynamic provisioning (deprecate r2d4 storage-provisioner) Jul 17, 2019
@tstromberg tstromberg mentioned this issue Jul 17, 2019
Closed
@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 17, 2019
@tstromberg tstromberg mentioned this issue Jul 17, 2019
Merged
@tstromberg
Copy link
Contributor

This is now done in minikube's source code:

https://github.com/kubernetes/minikube/blob/master/pkg/storage/storage_provisioner.go

I believe that the gcr.io/k8s-minikube/storage-provisioner Docker image needs to rebuilt using this updated source code for this to be fully complete.

@tstromberg tstromberg mentioned this issue Aug 22, 2019
Open
@tstromberg
Copy link
Contributor

I heard this mentioned on the sig-cluster-lifecycle call, which may be an alternative:

https://github.com/rancher/local-path-provisioner

@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed area/code-deps Code dependencies (guest-vm deps belong in guest-vm) good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2 labels Sep 20, 2019
@medyagh
Copy link
Member

medyagh commented Dec 16, 2019

We still need to do this issue ! I would be happy to review any prototype with https://github.com/rancher/local-path-provisioner

@josedonizetti josedonizetti self-assigned this Mar 1, 2020
@ghost ghost mentioned this issue May 12, 2020
Open
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 29, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@priyawadhwa priyawadhwa removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 8, 2020
@priyawadhwa
Copy link

I'm going to close this issue, as it seems that this has been done and the storage provisioner image has been upgraded since.

If anyone thinks this issue should remain open , please reopen this issue by including /reopen in your comment.

@afbjorklund afbjorklund mentioned this issue Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josedonizetti josedonizetti

Labels
addon/storage-provisioner Issues relating to storage provisioner addon help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@josedonizetti @tstromberg @jayunit100 @medyagh @afbjorklund @priyawadhwa @k8s-ci-robot @fejta-bot