Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head: "minikube delete" on empty directory causes panic #3662

Closed
tstromberg opened this issue Feb 12, 2019 · 2 comments
Closed

head: "minikube delete" on empty directory causes panic #3662

tstromberg opened this issue Feb 12, 2019 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@tstromberg
Copy link
Contributor

From head - appears related to #3656

% ./out/minikube delete
🔄  Reverting Kubernetes  using kubeadm ...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x12af3ba]

goroutine 1 [running]:
k8s.io/minikube/cmd/minikube/cmd.glob..func6(0x23e1720, 0x2412b40, 0x0, 0x0)
	/usr/local/google/home/tstromberg/go/src/k8s.io/minikube/cmd/minikube/cmd/delete.go:63 +0xaaa
k8s.io/minikube/vendor/github.com/spf13/cobra.(*Command).execute(0x23e1720, 0x2412b40, 0x0, 0x0, 0x23e1720, 0x2412b40)
	/usr/local/google/home/tstromberg/go/src/k8s.io/minikube/vendor/github.com/spf13/cobra/command.go:757 +0x2ae
k8s.io/minikube/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x23e2300, 0x1, 0x138ef40, 0xc00046c528)
	/usr/local/google/home/tstromberg/go/src/k8s.io/minikube/vendor/github.com/spf13/cobra/command.go:843 +0x2c0
k8s.io/minikube/vendor/github.com/spf13/cobra.(*Command).Execute(...)
	/usr/local/google/home/tstromberg/go/src/k8s.io/minikube/vendor/github.com/spf13/cobra/command.go:791
k8s.io/minikube/cmd/minikube/cmd.Execute()
	/usr/local/google/home/tstromberg/go/src/k8s.io/minikube/cmd/minikube/cmd/root.go:103 +0x2e
main.main()
	/usr/local/google/home/tstromberg/go/src/k8s.io/minikube/cmd/minikube/main.go:43 +0xca
@tstromberg tstromberg added this to the v0.34.0 milestone Feb 12, 2019
@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Feb 12, 2019
u5surf added a commit to u5surf/minikube that referenced this issue Feb 13, 2019
@u5surf
Copy link
Contributor

u5surf commented Feb 13, 2019

clusterBootstrapper, err := GetClusterBootstrapper(api, viper.GetString(cmdcfg.Bootstrapper))
if err != nil {
if err = clusterBootstrapper.DeleteCluster(kc); err != nil {

GetClusterBootstrapper returns nil, err when it's error.
L62 is true, then it excutes clusterBootstrapper.delete(), but clusterBootstrapper is nil from the above.

@afbjorklund
Copy link
Collaborator

Oops, think that code went in too fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants