Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable version switcher on docs site #5424

Open
divoxx opened this issue Sep 20, 2019 · 7 comments
Open

Enable version switcher on docs site #5424

divoxx opened this issue Sep 20, 2019 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@divoxx
Copy link

divoxx commented Sep 20, 2019

Running minikube start --vm-driver=kvm2 without docker-machine-driver-kvm2 fails, as expected, but the new documentation URL does not provide installation steps for the driver.

Specifically, this page does not provide any information on how to install docker-machine-driver-kvm2, nor a download link.

@divoxx
Copy link
Author

divoxx commented Sep 20, 2019

Sorry, I just realized that the new version 1.4.0 automatically downloads the driver. I was on 1.3.x.

Still, it might be good to keep a section in the documentation for people running older versions.

@tstromberg tstromberg added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 20, 2019
@tstromberg
Copy link
Contributor

This is indeed a place where we fail users by not showing the version switcher.

@tstromberg tstromberg changed the title Documentation for kvm2 missing information about driver Documentation site should allow version switching Sep 20, 2019
@tstromberg tstromberg changed the title Documentation site should allow version switching Enable version switcher on docs site (kvm2 doesn't mention driver install) Sep 20, 2019
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 20, 2019
@medyagh
Copy link
Member

medyagh commented Dec 16, 2019

we still need help on making docs per version.

@medyagh medyagh added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 16, 2019
@medyagh medyagh changed the title Enable version switcher on docs site (kvm2 doesn't mention driver install) Enable version switcher on docs site Dec 16, 2019
@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 16, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2020
@priyawadhwa priyawadhwa removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 31, 2020
@prasadkatti
Copy link
Contributor

#6921 is a dup of this one.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 30, 2020
@tstromberg tstromberg added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels May 28, 2020
@tstromberg
Copy link
Contributor

After speaking with the Kubernetes docs folks, this is a fairly big undertaking. New Netlify sites will need to be manually created per version, at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

7 participants