Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localkube should vendor kube-dns instead of the current kube2sky solution #55

Closed
luxas opened this issue May 10, 2016 · 13 comments · Fixed by #738
Closed

Localkube should vendor kube-dns instead of the current kube2sky solution #55

luxas opened this issue May 10, 2016 · 13 comments · Fixed by #738
Labels
area/code-deps Code dependencies (guest-vm deps belong in guest-vm)

Comments

@luxas
Copy link
Member

luxas commented May 10, 2016

Ref: kubernetes/kubernetes#23930

@luxas luxas changed the title Localkube should vendor kube-dns instead of the current kub2sky solution Localkube should vendor kube-dns instead of the current kube2sky solution May 10, 2016
@luxas luxas added this to the 0.1 Release milestone May 13, 2016
@luxas luxas added area/code-deps Code dependencies (guest-vm deps belong in guest-vm) priority/P1 labels May 19, 2016
@luxas
Copy link
Member Author

luxas commented May 22, 2016

kubernetes/kubernetes#23930 was merged :)
Let's update Godeps and write a new DNSServer

@dlorenc
Copy link
Contributor

dlorenc commented May 22, 2016

FYI I started updating godeps, but got blocked on a k8s.io/kubernetes appc/spec incompatibility. We'll need this PR to get merged before we can continue: appc/spec#607

@luxas
Copy link
Member Author

luxas commented May 22, 2016

Yes, I also started updating to head, and hit the same error.

@luxas
Copy link
Member Author

luxas commented Jun 2, 2016

I started to think if it's easier to deploy DNS as an addon instead of built-in in the binary...
That way we would be much more compatible with "real" solutions. Also, the new DNS solution uses dnsmasq for caching (I think), and it might be easier to just deploy them together as a Pod.

@dlorenc WDYT? Our localkube code would also get cleaner...

@dlorenc
Copy link
Contributor

dlorenc commented Jun 2, 2016

@luxas I'm concerned about the size of the image that people would have to pull. Any idea how large it is?

@luxas
Copy link
Member Author

luxas commented Jun 3, 2016

~50MB. That's quite much.
But anyway, I'm concerned about the dnsmasq dep... (Although it might be a soft dep)

@dlorenc
Copy link
Contributor

dlorenc commented Jul 2, 2016

I'm going to move this out of the milestone. We should come up with a plan here soon. Running as a pod might be the right approach.

@dlorenc dlorenc removed this from the 0.5 Release milestone Jul 2, 2016
@dlorenc dlorenc removed this from the 0.5 Release milestone Jul 2, 2016
@luxas
Copy link
Member Author

luxas commented Jul 2, 2016

I'm leaning against going with the "official" kube-dns solution.
Then we won't have any compability problems.

I've already added a flag, --enable-dns which you may just set to false when adding the manifest

jimmidyson added a commit to jimmidyson/minikube that referenced this issue Sep 2, 2016
@philips
Copy link
Contributor

philips commented Oct 6, 2016

It would be nice to make the kube-dns container smaller or something. The problem I see with not using the normal add-on is it makes the minikube cluster "more special".

For example this debugging guide doesn't work: https://coreos.com/kubernetes/docs/latest/network-troubleshooting.html#first-stop-dns-debugging

@philips
Copy link
Contributor

philips commented Oct 6, 2016

Thoughts @ethernetdan ?

@dlorenc
Copy link
Contributor

dlorenc commented Oct 7, 2016

+1 on switching to the standard DNS addon model.

@philips
Copy link
Contributor

philips commented Oct 7, 2016

@dlorenc another datapoint is today during my k8s workshop at LinuxCon EU someone asked about how to replace the DNS implementation and I was using minikube so I had to say "On a normal k8s cluster you can do that, minikube is special"

@ethernetdan
Copy link
Contributor

+1 for add-on - minikube should mirror best practices where possible

I was able to get the kube-dns executable down to 28mb from 42mb by omitting symbol and debug info with make kube-dns GOLDFLAGS="--s -w"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-deps Code dependencies (guest-vm deps belong in guest-vm)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants