-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localkube should vendor kube-dns instead of the current kube2sky solution #55
Comments
kubernetes/kubernetes#23930 was merged :) |
FYI I started updating godeps, but got blocked on a k8s.io/kubernetes appc/spec incompatibility. We'll need this PR to get merged before we can continue: appc/spec#607 |
Yes, I also started updating to head, and hit the same error. |
I started to think if it's easier to deploy DNS as an addon instead of built-in in the binary... @dlorenc WDYT? Our localkube code would also get cleaner... |
@luxas I'm concerned about the size of the image that people would have to pull. Any idea how large it is? |
~50MB. That's quite much. |
I'm going to move this out of the milestone. We should come up with a plan here soon. Running as a pod might be the right approach. |
I'm leaning against going with the "official" kube-dns solution. I've already added a flag, --enable-dns which you may just set to false when adding the manifest |
Couple of small fixes
It would be nice to make the kube-dns container smaller or something. The problem I see with not using the normal add-on is it makes the minikube cluster "more special". For example this debugging guide doesn't work: https://coreos.com/kubernetes/docs/latest/network-troubleshooting.html#first-stop-dns-debugging |
Thoughts @ethernetdan ? |
+1 on switching to the standard DNS addon model. |
@dlorenc another datapoint is today during my k8s workshop at LinuxCon EU someone asked about how to replace the DNS implementation and I was using minikube so I had to say "On a normal k8s cluster you can do that, minikube is special" |
+1 for add-on - minikube should mirror best practices where possible I was able to get the kube-dns executable down to 28mb from 42mb by omitting symbol and debug info with |
Ref: kubernetes/kubernetes#23930
The text was updated successfully, but these errors were encountered: