Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor docker-env to a package #6887

Closed
medyagh opened this issue Mar 4, 2020 · 9 comments
Closed

refactor docker-env to a package #6887

medyagh opened this issue Mar 4, 2020 · 9 comments
Assignees
@n0npax
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 4, 2020

we should be able to generate eval commands per shell type

so for example in this PR, we could give them exact command to re-eval their docker-env or podman env
#6885
@medyagh medyagh added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 4, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2020
@n0npax n0npax mentioned this issue Jun 3, 2020
Merged
@n0npax
Copy link
Contributor

n0npax commented Jun 3, 2020

/assign n0npax

@n0npax
Copy link
Contributor

n0npax commented Jun 3, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2020
n0npax added a commit to n0npax/minikube that referenced this issue Jun 8, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
171ec1b 
…esGH-6887/refactor-docker-env
@n0npax n0npax mentioned this issue Jun 8, 2020
Closed
n0npax added a commit to n0npax/minikube that referenced this issue Jun 11, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
7eebcf0 
…esGH-6887/refactor-docker-env
n0npax added a commit to n0npax/minikube that referenced this issue Jun 17, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
0912457 
…esGH-6887/refactor-docker-env
n0npax added a commit to n0npax/minikube that referenced this issue Jun 17, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
8ce5782 
…esGH-6887/refactor-docker-env
n0npax added a commit to n0npax/minikube that referenced this issue Jun 23, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
854cb62 
…esGH-6887/refactor-docker-env
n0npax added a commit to n0npax/minikube that referenced this issue Jul 3, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
b13d3ea 
…esGH-6887/refactor-docker-env
n0npax added a commit to n0npax/minikube that referenced this issue Jul 8, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
3754952 
…esGH-6887/refactor-docker-env
n0npax added a commit to n0npax/minikube that referenced this issue Aug 18, 2020
@n0npax
Merge branch 'master' of github.com:kubernetes/minikube into kubernet…
a32ea0a 
…esGH-6887/refactor-docker-env
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@n0npax
Copy link
Contributor

n0npax commented Sep 1, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 30, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 30, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n0npax n0npax

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@medyagh @n0npax @k8s-ci-robot @fejta-bot