Add test coverage for cmd/docker-env #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
dlorenc
reviewed
Feb 19, 2017
cmd/minikube/cmd/env_test.go
Outdated
| }, | ||
| { | ||
| shell: "emacs", | ||
| expected: `;; Run this command to configure your shell: |
There was a problem hiding this comment.
Could we move these to constants so we don't have them defined twice?
There was a problem hiding this comment.
made them constants. I was hoping to do it in a cleaner way, but the ShellConfig struct probably needs to be reworked if its going to be any cleaner. I also moved the usage hint to just be constants, because I don't think its worth the complexity to continue to have them configurable
r2d4
force-pushed
the
env-tests
branch
2 times, most recently
from
3c3ecdd
to
115970e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
+ Coverage 31.35% 35.36% +4.01%
==========================================
Files 46 46
Lines 2092 2081 -11
==========================================
+ Hits 656 736 +80
+ Misses 1305 1210 -95
- Partials 131 135 +4
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of a few PRs to try to get our test coverage from 30% to at least 60%