Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix images for aliyun registry #11785

Merged
merged 2 commits into from Sep 9, 2021
Merged

fix images for aliyun registry #11785

merged 2 commits into from Sep 9, 2021

Conversation

brian14708
Copy link
Contributor

for aliyun registry must strip namespace for addon images, e.g.
registry.cn-hangzhou.aliyuncs.com/google_containers/k8s-minikube/storage-provisioner:v5 will not work, but
registry.cn-hangzhou.aliyuncs.com/google_containers/storage-provisioner:v5 does work

fixes #11476

related to #10770

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @brian14708. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2021
@brian14708 brian14708 changed the title fix addon image for aliyun registry fix images for aliyun registry Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2021
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11785) |
+----------------+----------+---------------------+
| minikube start | 50.2s    | 49.2s               |
| enable ingress | 32.8s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 11785) start: 51.2s 49.5s 48.7s 47.6s 48.9s
Times for minikube start: 53.8s 49.1s 48.2s 52.7s 47.2s

Times for minikube (PR 11785) ingress: 32.3s 32.9s 31.3s 32.4s 31.3s
Times for minikube ingress: 33.3s 31.8s 32.4s 34.7s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11785) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.6s               |
| enable ingress | 29.6s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 21.6s 22.0s 21.9s 22.5s
Times for minikube (PR 11785) start: 21.5s 21.9s 21.1s 21.3s 22.1s

Times for minikube ingress: 25.9s 34.4s 25.4s 26.5s 35.5s
Times for minikube (PR 11785) ingress: 26.9s 27.0s 26.4s 26.4s 26.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11785) |
+----------------+----------+---------------------+
| minikube start | 43.1s    | 42.1s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 48.3s 43.1s 43.8s 44.4s 36.1s
Times for minikube (PR 11785) start: 43.2s 36.5s 43.5s 43.8s 43.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) 9/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) latest/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_debian (gopogh) sid/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 18.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.04/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) 20.10/kvm2-driver (chart)
Docker_macOS TestDebPackageInstall/install_amd64_ubuntu (gopogh) latest/kvm2-driver (chart)
Hyperkit_macOS TestPreload (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestErrorSpam/setup (gopogh) 2.07 (chart)
Docker_Linux_containerd_arm64 TestMultiNode/serial/StartAfterStop (gopogh) 2.07 (chart)
Docker_Linux_crio TestNetworkPlugins/group/kindnet/DNS (gopogh) 4.61 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 5.88 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/ControllerPod (gopogh) 6.45 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 8.09 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 8.09 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 8.09 (chart)
Docker_macOS TestJSONOutput/pause/Command (gopogh) 8.39 (chart)
Hyperkit_macOS TestFunctional/parallel/MountCmd/any-port (gopogh) 8.82 (chart)
Hyperkit_macOS TestMultiNode/serial/AddNode (gopogh) 8.82 (chart)
Hyperkit_macOS TestMultiNode/serial/StartAfterStop (gopogh) 8.82 (chart)
Hyperkit_macOS TestMultiNode/serial/FreshStart2Nodes (gopogh) 9.56 (chart)
Hyperkit_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 11.03 (chart)
Hyperkit_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 11.03 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 12.58 (chart)
Docker_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 12.58 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 14.71 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 15.23 (chart)
Docker_Windows TestStartStop/group/no-preload/serial/Pause (gopogh) 18.92 (chart)
Docker_Windows TestAddons/parallel/CSI (gopogh) 19.44 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit f18c312 into kubernetes:master Sep 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brian14708, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

无法从registry.cn-hangzhou.aliyuncs.com/google_containers下载镜像
6 participants