don't try to recreate pull secrets for refreshing gcp-auth #11945

sharifelgamal · 2021-07-08T23:18:37Z

This is an attempt to fix #11565

sharifelgamal · 2021-07-13T20:55:25Z

/ok-to-test

minikube-pr-bot · 2021-07-13T22:40:11Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 48.7s    | 50.3s               |
| enable ingress | 32.0s    | 35.5s               |
+----------------+----------+---------------------+

Times for minikube start: 52.3s 47.9s 49.3s 47.6s 46.7s
Times for minikube (PR 11945) start: 52.1s 48.6s 49.9s 49.7s 51.1s

Times for minikube ingress: 32.8s 32.3s 31.8s 31.4s 31.9s
Times for minikube (PR 11945) ingress: 32.8s 31.9s 32.9s 39.8s 40.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.0s               |
| enable ingress | 35.8s    | 33.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 36.5s 36.5s 34.5s 35.0s 36.5s
Times for minikube (PR 11945) ingress: 34.5s 35.5s 35.5s 27.0s 35.5s

Times for minikube start: 23.2s 23.0s 23.3s 21.9s 21.7s
Times for minikube (PR 11945) start: 22.0s 21.7s 22.7s 21.4s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 41.4s    | 43.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.5s 44.1s 43.5s 43.8s 43.8s
Times for minikube (PR 11945) start: 44.8s 44.7s 44.2s 37.2s 44.3s

briandealwis · 2021-07-19T14:16:42Z

@sharifelgamal is there a way for CC devs to try out this patch?

sharifelgamal · 2021-07-19T15:37:16Z

@sharifelgamal is there a way for CC devs to try out this patch?

Before it's merged, you can download a binary at https://storage.googleapis.com/minikube-builds/11945/minikube-linux-amd64 (or darwin or whatever you'd like, they're all there)

minikube-pr-bot · 2021-07-23T20:11:44Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 47.1s    | 47.5s               |
| enable ingress | 32.4s    | 37.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 11945) start: 48.0s 47.3s 46.8s 47.3s 47.9s
Times for minikube start: 48.4s 46.2s 47.5s 46.7s 46.6s

Times for minikube ingress: 31.8s 32.8s 33.9s 31.8s 31.8s
Times for minikube (PR 11945) ingress: 32.3s 41.2s 32.3s 40.8s 39.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.2s               |
| enable ingress | 34.6s    | 34.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 21.7s 21.0s 22.3s 22.4s
Times for minikube (PR 11945) start: 22.2s 22.5s 22.0s 22.3s 22.1s

Times for minikube ingress: 35.0s 31.5s 35.5s 35.5s 35.5s
Times for minikube (PR 11945) ingress: 31.5s 35.5s 31.5s 36.5s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 40.1s    | 43.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 27.4s 42.9s 43.5s 43.3s 43.5s
Times for minikube (PR 11945) start: 40.5s 44.9s 43.6s 43.6s 43.6s

minikube-pr-bot · 2021-07-23T20:54:10Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 48.6s    | 48.6s               |
| enable ingress | 37.2s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 11945) start: 48.0s 47.0s 53.1s 47.5s 47.4s
Times for minikube start: 49.5s 52.7s 47.4s 46.6s 46.8s

Times for minikube ingress: 41.3s 31.8s 40.3s 39.7s 32.8s
Times for minikube (PR 11945) ingress: 31.8s 32.3s 33.3s 39.7s 32.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.7s               |
| enable ingress | 34.3s    | 36.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.2s 21.8s 22.2s 21.6s
Times for minikube (PR 11945) start: 21.6s 21.8s 21.3s 21.9s 21.9s

Times for minikube ingress: 31.5s 36.5s 31.5s 35.5s 36.5s
Times for minikube (PR 11945) ingress: 35.5s 35.5s 38.0s 35.0s 36.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 40.1s    | 43.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 26.8s 43.2s 43.7s 43.5s 43.1s
Times for minikube (PR 11945) start: 42.5s 43.1s 43.0s 44.2s 43.0s

medyagh · 2021-07-23T21:17:59Z

/retest-this-please

medyagh · 2021-07-23T21:18:28Z

@briandealwis curious have u had a chance to try this out ?

minikube-pr-bot · 2021-07-23T21:43:05Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_crio)	TestNetworkPlugins/group/auto/DNS	3.55 (chart)
Docker_Linux_crio)	TestStartStop/group/no-preload/serial/Pause	5.22 (chart)
Docker_Linux_crio)	TestMultiNode/serial/PingHostFrom2Pods	5.92 (chart)
Docker_Linux_crio)	TestPause/serial/PauseAgain	13.02 (chart)
KVM_Linux_containerd)	TestPause/serial/SecondStartNoReconfiguration	13.10 (chart)
Docker_Linux_crio_arm64)	TestFunctional/parallel/BuildImage	13.27 (chart)
Docker_macOS)	TestFunctional/serial/ComponentHealth	37.82 (chart)
Docker_macOS)	TestFunctional/serial/ExtraConfig	37.82 (chart)
Docker_macOS)	TestNetworkPlugins/group/kubenet/Start	38.79 (chart)
Docker_Linux_containerd_arm64)	TestNetworkPlugins/group/kindnet/Start	46.00 (chart)
Docker_Windows)	TestPause/serial/VerifyStatus	56.84 (chart)
Docker_macOS)	TestNetworkPlugins/group/calico/Start	56.90 (chart)
Docker_Linux_crio_arm64)	TestMultiNode/serial/PingHostFrom2Pods	58.41 (chart)
Docker_macOS)	TestNetworkPlugins/group/kindnet/Start	58.62 (chart)
Docker_macOS)	TestNetworkPlugins/group/bridge/DNS	62.50 (chart)
Docker_Windows)	TestNetworkPlugins/group/kindnet/Start	64.71 (chart)
Docker_macOS)	TestNetworkPlugins/group/enable-default-cni/DNS	65.74 (chart)
Docker_Windows)	TestAddons/parallel/GCPAuth	66.98 (chart)
Docker_Windows)	TestNetworkPlugins/group/enable-default-cni/DNS	68.89 (chart)
Docker_Windows)	TestNetworkPlugins/group/bridge/Start	82.35 (chart)
Docker_Windows)	TestNetworkPlugins/group/custom-weave/Start	83.50 (chart)
Docker_Linux_containerd_arm64)	TestNetworkPlugins/group/bridge/Start	86.00 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop	88.00 (chart)
Docker_Windows)	TestNetworkPlugins/group/kubenet/Start	88.24 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/SecondStart	88.46 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop	88.46 (chart)
Docker_macOS)	TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDscacheutil	94.96 (chart)
Docker_Linux_containerd_arm64)	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop	96.00 (chart)
Docker_Linux_containerd_arm64)	TestStartStop/group/old-k8s-version/serial/SecondStart	96.00 (chart)
Docker_Linux_containerd_arm64)	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop	96.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-07-23T22:10:11Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 48.8s               |
| enable ingress | 31.4s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 11945) start: 48.8s 49.7s 48.8s 48.4s 48.2s
Times for minikube start: 51.9s 48.6s 53.2s 47.7s 51.7s

Times for minikube ingress: 31.3s 31.4s 31.3s 31.8s 31.3s
Times for minikube (PR 11945) ingress: 31.3s 34.3s 31.8s 31.3s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 22.5s               |
| enable ingress | 34.3s    | 32.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 11945) start: 22.3s 22.4s 22.8s 22.5s 22.3s
Times for minikube start: 23.4s 23.1s 22.2s 22.5s 22.1s

Times for minikube ingress: 35.0s 35.1s 30.5s 35.0s 36.0s
Times for minikube (PR 11945) ingress: 35.0s 28.5s 30.5s 35.0s 34.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11945) |
+----------------+----------+---------------------+
| minikube start | 41.3s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 26.6s 44.7s 43.0s 48.4s 43.9s
Times for minikube (PR 11945) start: 43.7s 43.6s 43.1s 44.4s 43.5s

minikube-pr-bot · 2021-07-23T23:40:04Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux)	TestNetworkPlugins/group/auto/Start	0.00 (chart)
KVM_Linux_containerd)	TestStartStop/group/no-preload/serial/Pause	0.59 (chart)
Docker_Windows)	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP	0.94 (chart)
Docker_Linux_crio)	TestAddons/parallel/CSI	1.78 (chart)
KVM_Linux_crio)	TestNetworkPlugins/group/cilium/Start	1.82 (chart)
Docker_Windows)	TestFunctional/parallel/InternationalLanguage	2.15 (chart)
Docker_Windows)	TestStartStop/group/newest-cni/serial/FirstStart	3.92 (chart)
Docker_Linux_crio)	TestMultiNode/serial/PingHostFrom2Pods	5.92 (chart)
Docker_macOS)	TestStartStop/group/no-preload/serial/Pause	6.19 (chart)
KVM_Linux_containerd)	TestStoppedBinaryUpgrade/MinikubeLogs	7.14 (chart)
Docker_Windows)	TestInsufficientStorage	7.55 (chart)
Docker_Linux_containerd)	TestStartStop/group/old-k8s-version/serial/Pause	8.92 (chart)
Docker_Windows)	TestAddons/parallel/HelmTiller	12.26 (chart)
Docker_Windows)	TestMultiNode/serial/CopyFile	13.33 (chart)
Docker_Linux_crio)	TestStartStop/group/default-k8s-different-port/serial/Stop	13.61 (chart)
Docker_Linux_crio)	TestStartStop/group/embed-certs/serial/Stop	15.98 (chart)
Docker_Windows)	TestAddons/parallel/Olm	27.36 (chart)
Docker_macOS)	TestFunctional/serial/ComponentHealth	37.82 (chart)
Docker_macOS)	TestFunctional/serial/ExtraConfig	37.82 (chart)
Docker_Windows)	TestFunctional/parallel/DryRun	41.51 (chart)
Docker_macOS)	TestDownloadOnlyKic	47.06 (chart)
Docker_Windows)	TestFunctional/parallel/StatusCmd	48.11 (chart)
Docker_Windows)	TestPause/serial/VerifyStatus	56.84 (chart)
Docker_Windows)	TestPause/serial/DeletePaused	58.06 (chart)
Docker_Linux_crio_arm64)	TestMultiNode/serial/PingHostFrom2Pods	58.41 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop	88.00 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/SecondStart	88.46 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop	88.46 (chart)
Docker_macOS)	TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDscacheutil	94.96 (chart)
Docker_Linux_containerd_arm64)	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop	96.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-07-24T00:00:49Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux)	TestNetworkPlugins/group/auto/Start	0.00 (chart)
KVM_Linux_containerd)	TestStartStop/group/no-preload/serial/Pause	0.59 (chart)
Docker_Windows)	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP	0.94 (chart)
Docker_Linux_crio)	TestAddons/parallel/CSI	1.78 (chart)
KVM_Linux_crio)	TestNetworkPlugins/group/cilium/Start	1.82 (chart)
Docker_Windows)	TestFunctional/parallel/InternationalLanguage	2.15 (chart)
Docker_Windows)	TestStartStop/group/newest-cni/serial/FirstStart	3.92 (chart)
Docker_Linux_crio)	TestMultiNode/serial/PingHostFrom2Pods	5.92 (chart)
KVM_Linux_containerd)	TestStoppedBinaryUpgrade/MinikubeLogs	7.14 (chart)
Docker_Windows)	TestInsufficientStorage	7.55 (chart)
Docker_macOS)	TestRunningBinaryUpgrade	7.63 (chart)
Docker_Linux_containerd)	TestStartStop/group/old-k8s-version/serial/Pause	8.92 (chart)
Docker_Windows)	TestAddons/parallel/HelmTiller	12.26 (chart)
Docker_Windows)	TestMultiNode/serial/CopyFile	13.33 (chart)
Docker_Linux_crio)	TestStartStop/group/default-k8s-different-port/serial/Stop	13.61 (chart)
Docker_Linux_crio)	TestStartStop/group/embed-certs/serial/Stop	15.98 (chart)
Docker_Windows)	TestAddons/parallel/Olm	27.36 (chart)
Docker_Windows)	TestFunctional/parallel/DryRun	41.51 (chart)
Docker_Windows)	TestFunctional/parallel/StatusCmd	48.11 (chart)
Docker_macOS)	TestNetworkPlugins/group/kubenet/DNS	50.70 (chart)
Docker_Windows)	TestPause/serial/VerifyStatus	56.84 (chart)
Docker_macOS)	TestNetworkPlugins/group/calico/Start	56.90 (chart)
Docker_Windows)	TestPause/serial/DeletePaused	58.06 (chart)
Docker_Linux_crio_arm64)	TestMultiNode/serial/PingHostFrom2Pods	58.41 (chart)
Docker_macOS)	TestNetworkPlugins/group/kindnet/Start	58.62 (chart)
Docker_macOS)	TestNetworkPlugins/group/bridge/DNS	62.50 (chart)
Docker_macOS)	TestNetworkPlugins/group/enable-default-cni/DNS	65.74 (chart)
Docker_Linux_containerd_arm64)	TestNetworkPlugins/group/bridge/Start	86.00 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop	88.00 (chart)
Docker_Linux_docker_arm64)	TestStartStop/group/old-k8s-version/serial/SecondStart	88.46 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2021-07-28T23:10:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

don't try to recreate pull secrets for refreshing gcp-auth

a8d366f

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2021

k8s-ci-robot requested review from ilya-zuyev and tstromberg July 8, 2021 23:18

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2021

sharifelgamal added 3 commits July 13, 2021 13:31

Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa

4dd89f8

fix time-to-k8s

0b9a2aa

fix time to k8s again

4a2c2f7

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 13, 2021

sharifelgamal added 4 commits July 19, 2021 12:23

Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa

5227520

Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa

c8379ea

update instead of delete/create

a940203

only use update if the secret already exists

6d710b4

medyagh mentioned this pull request Jul 23, 2021

intellij “Failed to enable GCP auth addon” GoogleCloudPlatform/cloud-code-intellij#2949

Closed

medyagh merged commit 5da954e into kubernetes:master Jul 28, 2021

medyagh approved these changes Jul 28, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't try to recreate pull secrets for refreshing gcp-auth #11945

don't try to recreate pull secrets for refreshing gcp-auth #11945

sharifelgamal commented Jul 8, 2021

sharifelgamal commented Jul 13, 2021

minikube-pr-bot commented Jul 13, 2021

briandealwis commented Jul 19, 2021

sharifelgamal commented Jul 19, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

medyagh commented Jul 23, 2021

medyagh commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 24, 2021

k8s-ci-robot commented Jul 28, 2021

don't try to recreate pull secrets for refreshing gcp-auth #11945

don't try to recreate pull secrets for refreshing gcp-auth #11945

Conversation

sharifelgamal commented Jul 8, 2021

sharifelgamal commented Jul 13, 2021

minikube-pr-bot commented Jul 13, 2021

briandealwis commented Jul 19, 2021

sharifelgamal commented Jul 19, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

medyagh commented Jul 23, 2021

medyagh commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 23, 2021

minikube-pr-bot commented Jul 24, 2021

k8s-ci-robot commented Jul 28, 2021