new image save command
#12162
Merged
new image save command
#12162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
afbjorklund
force-pushed
the
image-save-cmd
branch
from
386b96f
to
3229494
Compare
k8s-ci-robot
added
the
needs-rebase
Previously you could only Copy(To), not CopyFrom. Implies that some Assets can be written to instead.
This is the opposite command of "minikube image load", and can be used after doing a "minikube image build". The default is to save images in the cache, but it is also possible to save to files or to standard output.
afbjorklund
force-pushed
the
image-save-cmd
branch
from
3229494
to
b75bf27
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 49.7s 46.9s 52.3s 46.8s 50.2s Times for minikube ingress: 31.3s 31.8s 39.2s 40.8s 31.4s docker driver with docker runtime Times for minikube ingress: 32.0s 37.5s 36.5s 37.0s 32.0s Times for minikube start: 22.6s 22.4s 21.6s 22.1s 22.4s docker driver with containerd runtime Times for minikube start: 27.1s 43.8s 43.5s 43.9s 43.5s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
medyagh
approved these changes
Aug 13, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
minikube image savecommand:minikube --alsologtostderr image load --pull busyboxminikube --alsologtostderr image save busybox busybox.tarIt looks big because of the somewhat silly structure of "machine", and the missing CopyFrom functionality for VM "assets":
NewFileAsset: busybox.tar -> /var/lib/minikube/images/busybox.tarscp /var/lib/minikube/images/busybox.tar --> busybox.tar (1463808 bytes)Closes #11130