Update mount implementation, add mount integration tests, and check t… #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
aaron-prindle
force-pushed
the
switch-mount
branch
10 times, most recently
from
a51c017
to
c4fb492
Compare
|
@minikube-bot retest this please |
|
Were there any manual changes to the new go9p library? |
aaron-prindle
force-pushed
the
switch-mount
branch
3 times, most recently
from
821a9d3
to
63e002e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
=========================================
- Coverage 43.43% 43.1% -0.34%
=========================================
Files 48 48
Lines 2256 2269 +13
=========================================
- Hits 980 978 -2
- Misses 1117 1131 +14
- Partials 159 160 +1
Continue to review full report at Codecov.
|
|
Yes the "same" manual changes needed to be done as before in order to get the server working for Windows. |
|
@minikube-bot retest this please |
aaron-prindle
force-pushed
the
switch-mount
branch
from
63e002e
to
8e801e3
Compare
|
@minikube-bot retest this please |
This was referenced Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hat path exists.