Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Add packaging for cri-dockerd #13191

Merged
merged 3 commits into from
Feb 3, 2022
Merged

ISO: Add packaging for cri-dockerd #13191

merged 3 commits into from
Feb 3, 2022

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Dec 17, 2021 •
edited
Loading

Needed for docker, on versions without dockershim

No releases and no binaries yet, so build from git

Needed for PR #12102, only started on-demand

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@afbjorklund

This comment has been minimized.

Sign in to view
@minikube-bot

This comment has been minimized.

Sign in to view
@afbjorklund afbjorklund mentioned this pull request Dec 22, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021
@medyagh
Copy link
Member

medyagh commented Dec 23, 2021 •
edited
Loading

@afbjorklund would you please rebase this

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2021
@minikube-bot

This comment has been minimized.

Sign in to view
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 4, 2022
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@afbjorklund afbjorklund force-pushed the cri-dockerd-bin branch 2 times, most recently from 64322ac to 2db4859 Compare January 5, 2022 22:28
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 46.1s    | 45.8s               |
| enable ingress | 30.3s    | 30.8s               |
+----------------+----------+---------------------+

Times for minikube start: 47.5s 45.9s 45.8s 44.9s 46.6s
Times for minikube (PR 13191) start: 44.7s 45.7s 46.7s 45.5s 46.4s

Times for minikube ingress: 28.8s 32.3s 30.8s 30.2s 29.2s
Times for minikube (PR 13191) ingress: 31.8s 30.2s 31.2s 30.2s 30.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.3s               |
| enable ingress | 31.1s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.9s 26.4s 33.9s 34.4s 26.9s
Times for minikube (PR 13191) ingress: 25.9s 25.9s 26.9s 29.9s 27.9s

Times for minikube start: 22.3s 21.4s 23.0s 21.8s 23.5s
Times for minikube (PR 13191) start: 22.8s 21.9s 22.2s 22.4s 22.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 41.0s               |
| enable ingress | 23.7s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 42.9s 41.9s 41.5s 42.2s 42.1s
Times for minikube (PR 13191) start: 42.6s 36.9s 42.2s 41.1s 42.4s

Times for minikube ingress: 23.4s 22.4s 22.4s 27.9s 22.4s
Times for minikube (PR 13191) ingress: 22.4s 24.4s 23.4s 22.4s 17.9s

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@afbjorklund
Add packaging for cri-dockerd
63f1f3c 
Needed for docker, on versions without dockershim

No releases and no binaries yet, so build from git
@afbjorklund
Copy link
Collaborator Author

ok-to-build-iso

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 45.1s    | 44.4s               |
| enable ingress | 28.6s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube start: 46.5s 44.5s 44.4s 45.2s 44.8s
Times for minikube (PR 13191) start: 45.0s 44.4s 44.1s 44.4s 44.0s

Times for minikube ingress: 25.5s 29.6s 29.0s 28.6s 30.1s
Times for minikube (PR 13191) ingress: 29.1s 29.6s 28.6s 30.0s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 26.8s    | 25.9s               |
| enable ingress | 22.6s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube start: 29.3s 26.2s 26.1s 26.3s 26.1s
Times for minikube (PR 13191) start: 26.3s 26.1s 25.9s 26.1s 25.3s

Times for minikube (PR 13191) ingress: 22.9s 22.9s 21.9s 21.9s 22.4s
Times for minikube ingress: 22.9s 22.4s 21.9s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 41.1s    | 42.2s               |
| enable ingress | 21.7s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 34.2s 46.2s 42.6s 40.6s 41.7s
Times for minikube (PR 13191) start: 41.6s 40.6s 42.5s 45.0s 41.1s

Times for minikube ingress: 19.9s 18.9s 22.9s 23.4s 23.5s
Times for minikube (PR 13191) ingress: 23.5s 23.4s 23.4s 18.9s 23.4s

@afbjorklund afbjorklund mentioned this pull request Feb 2, 2022
Closed
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 56.8s    | 53.5s               |
| enable ingress | 29.3s    | 30.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 13191) start: 53.5s 53.4s 54.2s 53.3s 53.3s
Times for minikube start: 66.6s 54.7s 53.3s 52.8s 56.5s

Times for minikube (PR 13191) ingress: 30.6s 30.1s 26.6s 35.1s 28.6s
Times for minikube ingress: 28.6s 29.1s 30.6s 28.7s 29.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 26.9s    | 27.1s               |
| enable ingress | 23.4s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 27.3s 26.2s 26.6s 26.7s 27.8s
Times for minikube (PR 13191) start: 26.8s 27.7s 26.2s 26.8s 27.9s

Times for minikube ingress: 21.9s 27.0s 22.0s 24.4s 21.9s
Times for minikube (PR 13191) ingress: 22.4s 22.5s 21.0s 21.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 42.6s    | 43.5s               |
| enable ingress | 24.5s    | 24.0s               |
+----------------+----------+---------------------+

Times for minikube start: 42.0s 41.7s 45.7s 41.4s 42.3s
Times for minikube (PR 13191) start: 42.6s 45.6s 45.4s 41.3s 42.5s

Times for minikube (PR 13191) ingress: 23.4s 18.9s 19.9s 33.5s 24.0s
Times for minikube ingress: 23.4s 23.4s 18.9s 33.4s 23.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 4.35 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 4.35 (chart)
Docker_macOS TestCertExpiration (gopogh) 6.52 (chart)
Docker_macOS TestCertOptions (gopogh) 6.52 (chart)
Docker_macOS TestDockerFlags (gopogh) 6.52 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 6.52 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 6.52 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 10.94 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 10.94 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 11.96 (chart)
Docker_Windows TestCertExpiration (gopogh) 12.12 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 13.86 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 15.15 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 16.30 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 17.39 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 17.65 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 17.65 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 17.65 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 17.98 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 18.68 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 19.10 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 19.10 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 19.10 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 20.45 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 20.65 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 20.78 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 20.78 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 20.78 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 20.78 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 20.78 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 45.0s    | 45.0s               |
| enable ingress | 32.5s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube start: 46.6s 44.3s 44.5s 44.9s 44.6s
Times for minikube (PR 13191) start: 45.6s 45.5s 44.7s 44.2s 44.8s

Times for minikube ingress: 30.6s 32.1s 30.6s 35.0s 34.1s
Times for minikube (PR 13191) ingress: 30.1s 30.1s 34.6s 31.0s 31.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 26.3s               |
| enable ingress | 26.6s    | 31.1s               |
+----------------+----------+---------------------+

Times for minikube start: 30.0s 26.6s 26.8s 27.1s 25.8s
Times for minikube (PR 13191) start: 26.3s 26.6s 26.1s 26.1s 26.7s

Times for minikube ingress: 23.9s 26.0s 30.0s 27.9s 25.0s
Times for minikube (PR 13191) ingress: 24.4s 24.9s 31.0s 51.4s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 41.4s               |
| enable ingress | 29.7s    | 70.9s               |
+----------------+----------+---------------------+

Times for minikube start: 30.2s 45.7s 45.9s 41.2s 45.2s
Times for minikube (PR 13191) start: 42.2s 41.9s 40.6s 40.5s 41.7s

Times for minikube ingress: 24.4s 21.9s 40.9s 25.4s 35.9s
Times for minikube (PR 13191) ingress: 68.4s 170.5s 61.4s 28.9s 25.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 12.90 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 15.05 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 15.05 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 17.20 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 18.28 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 18.60 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 18.60 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 18.60 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 18.89 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 20.00 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 20.00 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 20.00 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 21.35 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 21.51 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Stop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh) 21.79 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_macOS TestCertExpiration (gopogh) 7.53 (chart)
Docker_macOS TestCertOptions (gopogh) 7.53 (chart)
Docker_macOS TestDockerFlags (gopogh) 7.53 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 7.53 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 7.53 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 12.90 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 17.20 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 18.28 (chart)
Docker_macOS TestNoKubernetes/serial/ProfileList (gopogh) 18.60 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 18.60 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 18.60 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 18.89 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 20.00 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 20.00 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 20.00 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 21.35 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 21.51 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 21.79 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Stop (gopogh) 21.79 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 44.6s    | 43.8s               |
| enable ingress | 29.0s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 45.0s 44.5s 44.3s 43.9s 45.4s
Times for minikube (PR 13191) start: 44.4s 44.3s 42.6s 43.6s 44.0s

Times for minikube ingress: 32.0s 26.6s 30.5s 27.1s 28.5s
Times for minikube (PR 13191) ingress: 32.0s 30.1s 28.6s 29.6s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 25.4s    | 25.8s               |
| enable ingress | 25.2s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 25.1s 25.3s 25.5s 25.4s
Times for minikube (PR 13191) start: 24.9s 26.1s 25.8s 25.9s 25.9s

Times for minikube ingress: 24.9s 23.4s 27.9s 26.9s 22.9s
Times for minikube (PR 13191) ingress: 22.9s 23.9s 23.9s 22.9s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13191) |
+----------------+----------+---------------------+
| minikube start | 43.5s    | 44.8s               |
| enable ingress | 29.5s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube start: 45.1s 44.9s 40.3s 45.7s 41.7s
Times for minikube (PR 13191) start: 46.1s 45.2s 45.5s 45.7s 41.4s

Times for minikube ingress: 27.9s 50.9s 23.9s 20.4s 24.4s
Times for minikube (PR 13191) ingress: 18.9s 31.9s 31.4s 18.9s 33.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 0.00 (chart)
none_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 5.21 (chart)
KVM_Linux_containerd TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 5.21 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 12.50 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 13.54 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 14.58 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh) 18.07 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/cilium/Start (gopogh) 18.75 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 18.75 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 18.75 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/flannel/Start (gopogh) 20.83 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/bridge/Start (gopogh) 22.92 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 30.43 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 50.00 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 50.54 (chart)
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 59.77 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 61.54 (chart)
Docker_Linux TestNetworkPlugins/group/custom-weave/Start (gopogh) 64.13 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 71.74 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 77.36 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 78.26 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 80.85 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 82.61 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 82.61 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 84.62 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 100.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh) 100.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit 4cc5dd0 into kubernetes:master Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@prezha prezha Awaiting requested review from prezha

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@afbjorklund @minikube-bot @medyagh @sharifelgamal @minikube-pr-bot @k8s-ci-robot