KIC: Upgrade cri-dockerd #13302

afbjorklund · 2022-01-05T22:27:43Z

Upgrade to v0.2.0, but we still might need a fix for the socket path (maybe in 0.2.1?)

Change the documentation to match the systemd unit files Mirantis/cri-dockerd#27

medyagh · 2022-01-11T22:05:57Z

ok-to-build-image

minikube-bot · 2022-01-11T22:18:58Z

Hi @afbjorklund, building a new kicbase image failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/13302/51fa3e9/kic_image_build.txt

afbjorklund · 2022-01-12T07:13:15Z

#190 16.01 Get:3 https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_20.04  cri-o-runc 1.0.1~0 [3016 kB]
: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

See:

Supply package cache for minikube container runtimes #9552

sharifelgamal · 2022-01-25T21:41:43Z

ok-to-build-image

minikube-bot · 2022-01-26T00:32:47Z

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

sharifelgamal · 2022-01-26T17:30:31Z

ok-to-build-image

minikube-bot · 2022-01-26T19:13:35Z

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

sharifelgamal · 2022-01-26T19:38:55Z

/ok-to-test

sharifelgamal · 2022-01-26T20:09:32Z

@afbjorklund could you pull the changes minikube-bot made to this PR and rebase against head so we don't lose the changes to kicbase?

afbjorklund · 2022-02-02T17:40:56Z

ok-to-build-image

minikube-pr-bot · 2022-02-02T18:33:03Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 52.7s    | 52.4s               |
| enable ingress | 29.8s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube start: 53.6s 53.9s 46.7s 56.8s 52.4s
Times for minikube (PR 13302) start: 52.5s 52.0s 52.3s 52.8s 52.2s

Times for minikube ingress: 29.1s 29.6s 29.1s 31.0s 30.1s
Times for minikube (PR 13302) ingress: 31.1s 29.6s 30.6s 30.1s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 28.3s    | 26.7s               |
| enable ingress | 22.5s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 34.0s 26.2s 26.6s 27.5s 27.1s
Times for minikube (PR 13302) start: 26.1s 26.8s 26.6s 26.8s 27.4s

Times for minikube ingress: 22.9s 21.0s 22.5s 22.4s 23.5s
Times for minikube (PR 13302) ingress: 23.0s 22.0s 22.0s 22.9s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 42.5s    | 45.0s               |
| enable ingress | 20.9s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 23.4s 23.4s 19.0s 18.9s 19.9s
Times for minikube (PR 13302) ingress: 19.0s 23.4s 29.9s 19.0s 19.0s

Times for minikube start: 32.8s 41.8s 46.2s 46.4s 45.2s
Times for minikube (PR 13302) start: 46.6s 41.9s 44.4s 45.7s 46.4s

minikube-bot · 2022-02-02T19:23:05Z

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

minikube-pr-bot · 2022-02-02T19:32:46Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 52.9s    | 53.2s               |
| enable ingress | 40.9s    | 29.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.6s 30.2s 29.1s 29.1s 87.6s
Times for minikube (PR 13302) ingress: 29.1s 30.1s 29.1s 29.6s 29.1s

Times for minikube (PR 13302) start: 53.9s 52.8s 53.3s 52.9s 53.2s
Times for minikube start: 55.4s 54.1s 48.5s 53.6s 52.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 27.2s    | 26.8s               |
| enable ingress | 22.8s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 13302) start: 26.4s 26.4s 26.7s 27.6s 26.8s
Times for minikube start: 28.1s 26.6s 27.4s 26.6s 27.0s

Times for minikube ingress: 21.9s 23.4s 23.4s 23.4s 21.9s
Times for minikube (PR 13302) ingress: 22.0s 21.9s 23.4s 22.9s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 41.7s    | 44.9s               |
| enable ingress | 28.8s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 24.4s 28.9s 33.4s 33.0s 23.9s
Times for minikube (PR 13302) ingress: 33.5s 19.0s 19.4s 19.0s 19.0s

Times for minikube start: 31.9s 45.5s 41.8s 43.1s 46.3s
Times for minikube (PR 13302) start: 41.1s 46.8s 45.7s 45.4s 45.4s

minikube-pr-bot · 2022-02-02T21:02:08Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestErrorSpam/setup (gopogh)	0.98 (chart)
Hyperkit_macOS	TestFunctional/serial/ComponentHealth (gopogh)	0.98 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartMultiNode (gopogh)	3.08 (chart)
KVM_Linux	TestGvisorAddon (gopogh)	5.21 (chart)
KVM_Linux	TestForceSystemdFlag (gopogh)	6.25 (chart)
Docker_Windows	TestNetworkPlugins/group/auto/Start (gopogh)	8.96 (chart)
Hyper-V_Windows	TestErrorSpam/setup (gopogh)	10.77 (chart)
Docker_macOS	TestJSONOutput/pause/Command (gopogh)	11.83 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	13.73 (chart)
Docker_Windows	TestNetworkPlugins/group/false/Start (gopogh)	16.42 (chart)
Docker_Windows	TestPause/serial/Pause (gopogh)	27.59 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	34.33 (chart)
Docker_Windows	TestStartStop/group/newest-cni/serial/Pause (gopogh)	44.62 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	46.27 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	54.44 (chart)
Docker_Windows	TestNetworkPlugins/group/custom-weave/Start (gopogh)	58.21 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	59.70 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	59.70 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	62.22 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	63.16 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	63.33 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	70.83 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	73.13 (chart)
Docker_Windows	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	75.38 (chart)
Docker_Windows	TestAddons/parallel/MetricsServer (gopogh)	88.06 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	100.00 (chart)
Docker_Windows	TestNetworkPlugins/group/cilium/Start (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-02-02T21:07:57Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13302) |
+----------------+----------+---------------------+
| minikube start | 56.1s    | 55.1s               |
| enable ingress | 33.5s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube start: 60.8s 55.7s 54.4s 56.0s 53.6s
Times for minikube (PR 13302) start: 58.1s 55.1s 54.8s 53.6s 54.0s

Times for minikube ingress: 43.5s 32.3s 30.2s 30.7s 30.7s
Times for minikube (PR 13302) ingress: 33.3s 33.8s 30.8s 32.6s 30.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

minikube-pr-bot · 2022-02-02T22:29:59Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	0.00 (chart)
Docker_Linux	TestNoKubernetes/serial/Stop (gopogh)	1.14 (chart)
KVM_Linux	TestAddons/Setup (gopogh)	2.08 (chart)
Docker_Linux	TestNoKubernetes/serial/Start (gopogh)	3.30 (chart)
Docker_Linux	TestStartStop/group/embed-certs/serial/Pause (gopogh)	3.30 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	5.38 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	5.38 (chart)
Docker_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	16.13 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/Start (gopogh)	17.65 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/FirstStart (gopogh)	22.78 (chart)
Docker_Linux	TestNetworkPlugins/group/kindnet/DNS (gopogh)	60.78 (chart)
Docker_Linux	TestNetworkPlugins/group/custom-weave/Start (gopogh)	63.74 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	71.43 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/DNS (gopogh)	73.08 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	78.02 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	80.39 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	82.42 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	82.42 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	82.61 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	86.00 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-02-03T00:53:02Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestFunctional/serial/ComponentHealth (gopogh)	0.00 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	5.32 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	5.32 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/DNS (gopogh)	37.14 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	53.85 (chart)
Docker_Cloud_Shell	TestAddons/parallel/MetricsServer (gopogh)	60.00 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	62.07 (chart)
Docker_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	62.64 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	69.86 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	71.43 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	82.42 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	100.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	100.00 (chart)
Docker_macOS	TestDownloadOnly/v1.16.0/preload-exists (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2022-02-03T19:24:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2022

k8s-ci-robot requested review from prezha and spowelljr January 5, 2022 22:28

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022

medyagh mentioned this pull request Jan 25, 2022

Append Changelog to KIC Base Image build and ISO Image build process #13486

Closed

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2022

afbjorklund mentioned this pull request Jan 26, 2022

fix external cri-docker socket name #13488

Closed

afbjorklund force-pushed the cri-dockerd-rel branch from a84970c to 51fa3e9 Compare January 26, 2022 06:58

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2022

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2022

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 26, 2022

This comment has been minimized.

Sign in to view

afbjorklund force-pushed the cri-dockerd-rel branch from 946e973 to 51fa3e9 Compare February 2, 2022 17:10

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2022

Upgrade cri-dockerd

9bfc700

afbjorklund force-pushed the cri-dockerd-rel branch from 51fa3e9 to 9bfc700 Compare February 2, 2022 17:40

afbjorklund mentioned this pull request Feb 2, 2022

Support docker container runtime in Kubernetes 1.24 #13545

Closed

Updating kicbase image to v0.0.29-1643823806-13302

429347e

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2022

sharifelgamal approved these changes Feb 3, 2022

View reviewed changes

sharifelgamal merged commit 3a923b2 into kubernetes:master Feb 3, 2022

spowelljr mentioned this pull request Mar 29, 2022

failed to download kicbase-build anonymously AliYun Mirror #13863

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KIC: Upgrade cri-dockerd #13302

KIC: Upgrade cri-dockerd #13302

afbjorklund commented Jan 5, 2022 •

edited

medyagh commented Jan 11, 2022

minikube-bot commented Jan 11, 2022

afbjorklund commented Jan 12, 2022

sharifelgamal commented Jan 25, 2022

minikube-bot commented Jan 26, 2022

sharifelgamal commented Jan 26, 2022

minikube-bot commented Jan 26, 2022

sharifelgamal commented Jan 26, 2022

sharifelgamal commented Jan 26, 2022

This comment has been minimized.

This comment has been minimized.

afbjorklund commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 3, 2022

k8s-ci-robot commented Feb 3, 2022

KIC: Upgrade cri-dockerd #13302

KIC: Upgrade cri-dockerd #13302

Conversation

afbjorklund commented Jan 5, 2022 • edited

medyagh commented Jan 11, 2022

minikube-bot commented Jan 11, 2022

afbjorklund commented Jan 12, 2022

sharifelgamal commented Jan 25, 2022

minikube-bot commented Jan 26, 2022

sharifelgamal commented Jan 26, 2022

minikube-bot commented Jan 26, 2022

sharifelgamal commented Jan 26, 2022

sharifelgamal commented Jan 26, 2022

This comment has been minimized.

This comment has been minimized.

afbjorklund commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 2, 2022

minikube-pr-bot commented Feb 3, 2022

k8s-ci-robot commented Feb 3, 2022

afbjorklund commented Jan 5, 2022 •

edited