Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIC: Update kicbase base image #13815

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Mar 20, 2022

BEFORE

34 packages can be upgraded.

AFTER

All packages are up to date.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2022
@afbjorklund
Copy link
Collaborator Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 20, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2022
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, building a new kicbase image failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/13815/5da2fb7/kic_image_build.txt

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Mar 20, 2022

Looks like auto-pause is broken:

#69 93.03 /go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

It needs go1.17 (and a git repo...)

@afbjorklund
Copy link
Collaborator Author

ok-to-build-image

@afbjorklund afbjorklund changed the title Update kicbase base image KIC: Update kicbase base image Mar 20, 2022
@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2022
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 20, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13815) |
+----------------+----------+---------------------+
| minikube start | 52.4s    | 52.0s               |
| enable ingress | 26.6s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 54.1s 51.8s 52.0s 52.2s 51.8s
Times for minikube (PR 13815) start: 53.3s 51.5s 50.6s 52.3s 52.4s

Times for minikube ingress: 25.0s 29.0s 25.5s 25.0s 28.5s
Times for minikube (PR 13815) ingress: 30.5s 28.6s 29.5s 29.0s 27.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13815) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 35.5s               |
| enable ingress | 22.5s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 29.7s 25.6s 25.2s 25.0s 26.0s
Times for minikube (PR 13815) start: 75.2s 26.1s 25.5s 25.7s 25.2s

Times for minikube ingress: 23.4s 22.4s 22.9s 21.9s 21.9s
Times for minikube (PR 13815) ingress: 23.9s 21.9s 23.4s 21.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13815) |
+----------------+----------+---------------------+
| minikube start | 40.4s    | 42.2s               |
| enable ingress | 32.5s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 31.9s 42.5s 45.4s 41.2s 41.2s
Times for minikube (PR 13815) start: 39.9s 45.2s 44.7s 40.7s 40.5s

Times for minikube ingress: 32.9s 23.4s 18.9s 32.9s 54.4s
Times for minikube (PR 13815) ingress: 22.4s 18.9s 17.9s 22.4s 22.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestNetworkPlugins/group/kubenet/NetCatPod (gopogh) 0.00 (chart)
Docker_Windows TestMissingContainerUpgrade (gopogh) 0.88 (chart)
Docker_Windows TestCertExpiration (gopogh) 5.26 (chart)
Docker_Windows TestPause/serial/Start (gopogh) 5.26 (chart)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 6.75 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 13.17 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 19.84 (chart)
Docker_Windows TestNoKubernetes/serial/ProfileList (gopogh) 21.43 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 26.38 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 32.79 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 34.25 (chart)
Docker_macOS TestFunctional/serial/ComponentHealth (gopogh) 42.86 (chart)
Docker_macOS TestFunctional/serial/ExtraConfig (gopogh) 42.86 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 42.94 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 46.84 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 48.10 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 51.13 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 54.43 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 60.15 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 61.65 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/DNS (gopogh) 70.30 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 71.79 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 72.03 (chart)
Docker_macOS TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 73.04 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 75.46 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 75.46 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 77.91 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 78.53 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 80.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Mar 21, 2022

/lgtm

@medyagh medyagh merged commit 812f6b4 into kubernetes:master Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants