Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx image #14028

Merged
merged 1 commit into from Apr 25, 2022
Merged

Update nginx image #14028

merged 1 commit into from Apr 25, 2022

Conversation

spowelljr
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14028) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 51.1s               |
| enable ingress | 27.5s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.0s 51.8s 50.8s 50.9s 49.7s
Times for minikube (PR 14028) start: 52.0s 50.4s 50.4s 51.4s 51.3s

Times for minikube ingress: 30.0s 28.6s 24.6s 29.0s 25.5s
Times for minikube (PR 14028) ingress: 25.1s 30.1s 26.5s 29.5s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14028) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 24.2s               |
| enable ingress | 22.8s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 24.7s 24.8s 24.6s 24.4s
Times for minikube (PR 14028) start: 23.6s 25.0s 24.5s 23.9s 24.1s

Times for minikube ingress: 22.9s 22.4s 23.4s 22.9s 22.4s
Times for minikube (PR 14028) ingress: 22.9s 22.9s 20.9s 22.0s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14028) |
+----------------+----------+---------------------+
| minikube start | 37.9s    | 40.7s               |
| enable ingress | 23.5s    | 23.3s               |
+----------------+----------+---------------------+

Times for minikube start: 29.5s 38.8s 43.3s 38.4s 39.7s
Times for minikube (PR 14028) start: 40.1s 40.0s 43.6s 39.7s 40.1s

Times for minikube ingress: 22.4s 22.4s 27.9s 22.4s 22.4s
Times for minikube (PR 14028) ingress: 21.4s 22.4s 28.4s 22.0s 22.4s

@sharifelgamal
Copy link
Collaborator

Remove the swp file before merging.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

Remove the swp file before merging.

Removed, thanks for catching that

@spowelljr spowelljr merged commit 889ee1c into kubernetes:master Apr 25, 2022
@spowelljr spowelljr deleted the updateNginxImage branch April 25, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants