Reduce package duplication for ISO building #14265

sharifelgamal · 2022-06-01T20:58:22Z

This is an effort to reduce duplication for building packages for the ISOs that only differ in GOARCH and nothing else. This also fixes conmon not getting installed on the arm64 ISO, which was breaking the crio container runtime.

This also updates conmon to 2.0.24, which is the earliest version compatible with the current version of crio.

This also adds missing kernel modules to make containerd work for the arm64 ISO.

Related: #14146

…-containerd

sharifelgamal · 2022-06-02T20:24:46Z

/ok-to-build-iso

minikube-bot · 2022-06-02T21:42:58Z

Hi @sharifelgamal, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14265/b7b5395/iso_build.txt

sharifelgamal · 2022-06-02T21:50:57Z

/ok-to-build-iso

minikube-bot · 2022-06-02T22:58:49Z

Hi @sharifelgamal, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14265/f1f5c66/iso_build.txt

minikube-bot · 2022-06-09T17:01:21Z

Hi @sharifelgamal, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14265/c9c720c/iso_build.txt

sharifelgamal · 2022-06-09T17:03:10Z

/ok-to-build-iso

minikube-bot · 2022-06-09T19:26:24Z

Hi @sharifelgamal, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14265/962f2b6/iso_build.txt

sharifelgamal · 2022-06-09T19:55:14Z

/ok-to-build-iso

minikube-bot · 2022-06-09T23:16:07Z

Hi @sharifelgamal, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

…ntainerd

…into arm64-containerd

sharifelgamal · 2022-06-10T00:02:28Z

/ok-to-test

minikube-pr-bot · 2022-06-10T00:52:51Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 52.3s    | 51.0s               |
| enable ingress | 29.3s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 14265) start: 50.3s 52.2s 51.0s 51.9s 49.8s
Times for minikube start: 53.3s 53.5s 52.7s 50.0s 51.9s

Times for minikube ingress: 29.7s 29.7s 28.7s 29.2s 29.2s
Times for minikube (PR 14265) ingress: 29.2s 29.7s 30.6s 29.6s 30.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 26.9s    | 26.3s               |
| enable ingress | 22.8s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 30.7s 25.5s 25.6s 26.3s 26.3s
Times for minikube (PR 14265) start: 26.6s 26.1s 26.3s 26.3s 26.1s

Times for minikube ingress: 23.0s 23.5s 22.0s 22.5s 23.0s
Times for minikube (PR 14265) ingress: 23.0s 22.0s 23.0s 22.5s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 35.5s    | 33.6s               |
| enable ingress | 23.6s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 14265) start: 29.6s 40.7s 30.1s 33.4s 33.9s
Times for minikube start: 31.8s 44.7s 40.7s 30.5s 29.6s

Times for minikube (PR 14265) ingress: 23.5s 22.1s 32.5s 19.0s 17.0s
Times for minikube ingress: 22.0s 18.0s 23.0s 23.0s 32.0s

minikube-pr-bot · 2022-06-10T03:08:21Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestSkaffold (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestOffline (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.83 (chart)
Hyperkit_macOS	TestFunctional/serial/ComponentHealth (gopogh)	10.57 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	29.82 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	41.67 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	50.00 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	64.34 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	72.59 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	75.20 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	75.97 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	78.46 (chart)
Docker_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	80.00 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	81.25 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	87.50 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	87.50 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	87.50 (chart)
Docker_macOS	TestPreload (gopogh)	87.50 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	87.50 (chart)
Docker_macOS	TestPause/serial/VerifyStatus (gopogh)	88.42 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	88.42 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	88.54 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	88.54 (chart)
Docker_Windows	TestNoKubernetes/serial/Start (gopogh)	91.60 (chart)
Docker_macOS	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	94.32 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Pause (gopogh)	94.32 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	94.32 (chart)
Docker_macOS	TestStartStop/group/no-preload/serial/Pause (gopogh)	94.32 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	94.32 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

…ntainerd

minikube-pr-bot · 2022-06-11T00:55:28Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 51.6s    | 50.6s               |
| enable ingress | 30.3s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.8s 51.0s 51.6s 51.2s 51.2s
Times for minikube (PR 14265) start: 51.0s 50.7s 49.9s 50.9s 50.1s

Times for minikube ingress: 28.6s 34.1s 30.1s 29.1s 29.6s
Times for minikube (PR 14265) ingress: 28.1s 29.1s 29.2s 28.5s 30.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 24.9s    | 25.0s               |
| enable ingress | 23.8s    | 23.5s               |
+----------------+----------+---------------------+

Times for minikube start: 24.9s 24.8s 24.6s 25.4s 24.7s
Times for minikube (PR 14265) start: 25.1s 24.7s 25.8s 24.6s 24.6s

Times for minikube ingress: 21.4s 25.5s 25.4s 23.9s 22.9s
Times for minikube (PR 14265) ingress: 22.9s 23.4s 24.5s 22.9s 23.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 32.7s    | 32.3s               |
| enable ingress | 20.9s    | 23.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 18.9s 21.9s 18.9s 22.4s
Times for minikube (PR 14265) ingress: 22.4s 22.4s 18.9s 21.9s 32.4s

Times for minikube start: 29.3s 32.0s 40.5s 33.3s 28.8s
Times for minikube (PR 14265) start: 29.6s 41.0s 32.1s 29.3s 29.5s

minikube-pr-bot · 2022-06-11T02:15:15Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestSkaffold (gopogh)	0.81 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/NetCatPod (gopogh)	3.30 (chart)
Docker_macOS	TestFunctional/parallel/MountCmd/any-port (gopogh)	4.95 (chart)
Docker_macOS	TestAddons/Setup (gopogh)	6.67 (chart)
Docker_macOS	TestBinaryMirror (gopogh)	6.67 (chart)
Docker_macOS	TestErrorSpam/setup (gopogh)	6.67 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.83 (chart)
Docker_macOS	TestDownloadOnlyKic (gopogh)	9.52 (chart)
Docker_macOS	TestDownloadOnly/v1.23.6/preload-exists (gopogh)	9.52 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	9.52 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/DNS (gopogh)	13.11 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	13.25 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	20.00 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	26.45 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	27.05 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	28.69 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	28.70 (chart)
Docker_Linux_containerd	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	29.27 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	30.58 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/SecondStart (gopogh)	30.58 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh)	31.15 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/Start (gopogh)	31.20 (chart)
Docker_Linux_containerd	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	32.26 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	33.06 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	33.06 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	33.61 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	34.68 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	37.96 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/DNS (gopogh)	41.67 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh)	49.59 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-06-11T03:46:47Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 51.8s    | 51.1s               |
| enable ingress | 27.9s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 53.3s 51.6s 51.4s 52.2s 50.3s
Times for minikube (PR 14265) start: 51.4s 51.4s 51.0s 50.6s 50.9s

Times for minikube ingress: 26.0s 25.0s 29.6s 30.0s 29.0s
Times for minikube (PR 14265) ingress: 26.1s 27.5s 29.1s 28.0s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 24.4s               |
| enable ingress | 34.6s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube start: 26.6s 24.4s 24.4s 23.9s 23.7s
Times for minikube (PR 14265) start: 24.3s 25.3s 23.5s 24.4s 24.4s

Times for minikube ingress: 83.9s 21.9s 23.0s 21.9s 22.5s
Times for minikube (PR 14265) ingress: 21.9s 21.9s 22.9s 22.9s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 32.4s    | 29.9s               |
| enable ingress | 26.4s    | 24.2s               |
+----------------+----------+---------------------+

Times for minikube start: 33.6s 27.7s 32.6s 28.3s 39.6s
Times for minikube (PR 14265) start: 28.4s 32.7s 32.4s 27.9s 28.2s

Times for minikube ingress: 17.9s 22.4s 17.9s 52.4s 21.4s
Times for minikube (PR 14265) ingress: 21.4s 17.9s 27.9s 22.4s 31.4s

minikube-pr-bot · 2022-06-11T05:08:55Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestMinikubeProfile (gopogh)	n/a
Docker_macOS	TestSkaffold (gopogh)	0.00 (chart)
Docker_Windows	TestNoKubernetes/serial/Stop (gopogh)	0.00 (chart)
Hyperkit_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	0.81 (chart)
Hyperkit_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	0.81 (chart)
Hyperkit_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh)	0.81 (chart)
Hyperkit_macOS	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	0.81 (chart)
Hyperkit_macOS	TestSkaffold (gopogh)	0.81 (chart)
Hyperkit_macOS	TestAddons/parallel/CSI (gopogh)	0.82 (chart)
Hyperkit_macOS	TestAddons/parallel/Ingress (gopogh)	0.82 (chart)
Hyperkit_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	1.63 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.83 (chart)
Hyperkit_macOS	TestMultiNode/serial/AddNode (gopogh)	9.76 (chart)
Hyperkit_macOS	TestMultiNode/serial/StartAfterStop (gopogh)	9.76 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	13.89 (chart)
Hyperkit_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	14.63 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/SecondStart (gopogh)	16.97 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Audit (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	20.86 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

sharifelgamal · 2022-06-13T15:39:20Z

/ok-to-build-iso

minikube-bot · 2022-06-13T18:32:15Z

Hi @sharifelgamal, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

minikube-pr-bot · 2022-06-13T21:11:30Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14265) |
+----------------+----------+---------------------+
| minikube start | 51.9s    | 51.4s               |
| enable ingress | 38.6s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.6s 25.5s 28.6s 25.5s 84.5s
Times for minikube (PR 14265) ingress: 28.1s 28.6s 25.6s 26.6s 27.1s

Times for minikube start: 54.0s 50.9s 50.5s 51.6s 52.4s
Times for minikube (PR 14265) start: 51.1s 51.2s 51.8s 51.7s 51.3s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

minikube-pr-bot · 2022-06-13T22:39:51Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestSkaffold (gopogh)	0.00 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/NetCatPod (gopogh)	0.00 (chart)
Hyperkit_macOS	TestSkaffold (gopogh)	0.81 (chart)
KVM_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	7.83 (chart)
Docker_Windows	TestPause/serial/PauseAgain (gopogh)	9.52 (chart)
Docker_Cloud_Shell	TestStartStop/group/cloud-shell/serial/UserAppExistsAfterStop (gopogh)	17.47 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Audit (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeleteNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartKeepsNodes (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	20.86 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	25.15 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	29.82 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	30.06 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	30.06 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2022-06-13T23:20:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sharifelgamal added 13 commits May 26, 2022 13:46

build conmon regardless of arch

bc133a9

remove arch dep

6902580

upgrade conmon to v2.0.24

cd01efd

remove deprecated config

fd3f8d3

Merge branch 'master' of github.com:sharifelgamal/minikube into arm64…

1e7c257

…-containerd

build crio-bin in the same way for both arch

bb1e25e

build cni the same way

d1c261e

build cri-dockerd the same way

83f8b00

build podman the same way

a0c00f4

build runc the same way

e0ce53c

select common packages for all arch

7a0119d

dynamically supply GOARCH

9e78a3a

don't set GOBIN anymore

4ba5162

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 1, 2022

k8s-ci-robot requested review from blueelvis and medyagh June 1, 2022 20:58

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022

sharifelgamal added 4 commits June 2, 2022 08:38

add cfs kernel modules for arm64

79da2bc

fix crio conf

bc3517a

adding more kernel modules

3ad46b4

turn off crio for qemu for now

b7b5395

swap default for testing

f1f5c66

sharifelgamal added 3 commits June 2, 2022 17:41

revert cri-dockerd to old way, they're slightly different

7ef3712

fix aarch mk file

a1be913

add comment back

eb26a8d

fix syntax

962f2b6

remove vbox-guest config entry

a64f828

Updating ISO to v1.26.0-1654804800-14265

5d5cdc7

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022

sharifelgamal added 2 commits June 9, 2022 16:27

Merge branch 'master' of github.com:kubernetes/minikube into arm64-co…

d642c40

…ntainerd

Merge branch 'arm64-containerd' of github.com:sharifelgamal/minikube …

9622fae

…into arm64-containerd

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 10, 2022

sharifelgamal added 2 commits June 10, 2022 13:40

Merge branch 'master' of github.com:kubernetes/minikube into arm64-co…

460b942

…ntainerd

Merge branch 'master' of github.com:kubernetes/minikube into arm64-co…

1801630

…ntainerd

Updating ISO to v1.26.0-1655134933-14265

33cb8cb

spowelljr approved these changes Jun 13, 2022

View reviewed changes

sharifelgamal merged commit 98c0e9f into kubernetes:master Jun 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce package duplication for ISO building #14265

Reduce package duplication for ISO building #14265

sharifelgamal commented Jun 1, 2022 •

edited

sharifelgamal commented Jun 2, 2022

minikube-bot commented Jun 2, 2022

sharifelgamal commented Jun 2, 2022

minikube-bot commented Jun 2, 2022

minikube-bot commented Jun 9, 2022

sharifelgamal commented Jun 9, 2022

minikube-bot commented Jun 9, 2022

sharifelgamal commented Jun 9, 2022

minikube-bot commented Jun 9, 2022

sharifelgamal commented Jun 10, 2022

minikube-pr-bot commented Jun 10, 2022

minikube-pr-bot commented Jun 10, 2022

minikube-pr-bot commented Jun 11, 2022

minikube-pr-bot commented Jun 11, 2022

minikube-pr-bot commented Jun 11, 2022

minikube-pr-bot commented Jun 11, 2022

sharifelgamal commented Jun 13, 2022

minikube-bot commented Jun 13, 2022

minikube-pr-bot commented Jun 13, 2022

minikube-pr-bot commented Jun 13, 2022

k8s-ci-robot commented Jun 13, 2022

Reduce package duplication for ISO building #14265

Reduce package duplication for ISO building #14265

Conversation

sharifelgamal commented Jun 1, 2022 • edited

sharifelgamal commented Jun 2, 2022

minikube-bot commented Jun 2, 2022

sharifelgamal commented Jun 2, 2022

minikube-bot commented Jun 2, 2022

minikube-bot commented Jun 9, 2022

sharifelgamal commented Jun 9, 2022

minikube-bot commented Jun 9, 2022

sharifelgamal commented Jun 9, 2022

minikube-bot commented Jun 9, 2022

sharifelgamal commented Jun 10, 2022

minikube-pr-bot commented Jun 10, 2022

minikube-pr-bot commented Jun 10, 2022

minikube-pr-bot commented Jun 11, 2022

minikube-pr-bot commented Jun 11, 2022

minikube-pr-bot commented Jun 11, 2022

minikube-pr-bot commented Jun 11, 2022

sharifelgamal commented Jun 13, 2022

minikube-bot commented Jun 13, 2022

minikube-pr-bot commented Jun 13, 2022

minikube-pr-bot commented Jun 13, 2022

k8s-ci-robot commented Jun 13, 2022

sharifelgamal commented Jun 1, 2022 •

edited