Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to supply custom QEMU firmware path #14283

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Jun 6, 2022

Currently minikube looks for qemu firmware in sane default locations. This PR allows users with non-standard (or non-brew) qemu installations to use qemu.

Related: #14146

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 6, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14283) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.6s               |
| enable ingress | 28.2s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 50.6s 51.0s 50.8s 49.7s
Times for minikube (PR 14283) start: 50.4s 51.5s 51.4s 50.3s 49.4s

Times for minikube ingress: 29.6s 27.0s 28.5s 29.1s 27.0s
Times for minikube (PR 14283) ingress: 28.5s 30.0s 26.6s 26.6s 29.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14283) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 24.0s               |
| enable ingress | 23.9s    | 24.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.9s 23.9s 22.0s 26.9s 23.9s
Times for minikube (PR 14283) ingress: 27.9s 23.4s 23.9s 23.9s 22.9s

Times for minikube start: 25.3s 23.6s 23.9s 24.2s 25.0s
Times for minikube (PR 14283) start: 24.2s 24.5s 23.3s 23.9s 23.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14283) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 30.9s    | 36.1s ⚠️             |
| enable ingress    | 27.2s    | 26.7s               |
+-------------------+----------+---------------------+

Times for minikube start: 29.6s 40.0s 28.3s 28.0s 28.5s
Times for minikube (PR 14283) start: 28.7s 43.3s 44.9s 31.8s 32.0s

Times for minikube ingress: 23.4s 33.4s 23.4s 32.4s 23.4s
Times for minikube (PR 14283) ingress: 32.4s 29.4s 29.0s 18.9s 23.9s

@sharifelgamal sharifelgamal merged commit b465bac into kubernetes:master Jun 6, 2022
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMinikubeProfile (gopogh) n/a
Docker_Windows TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 1.85 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 9.52 (chart)
Docker_macOS TestDownloadOnly/v1.23.6/preload-exists (gopogh) 9.52 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 13.25 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 14.63 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 31.20 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 36.88 (chart)
Docker_Linux TestNetworkPlugins/group/calico/DNS (gopogh) 48.15 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 50.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 50.93 (chart)
Docker_Windows TestAddons/Setup (gopogh) 51.85 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/DockerEnv/powershell (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 51.85 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 51.85 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants