Fix overwriting err for OCI "minikube start"

[criztovyl]

fixes #14424

[k8s-ci-robot]

Welcome @criztovyl!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @criztovyl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[spowelljr]

Hi @criztovyl, thanks for the PR! Looking at this I see a cleaner way to resolve this issue.

Line 402, if the if is moved to the front of the line like how line 400 is, that will keep the scope of the error within that block, leaving the error from StartContainer untouched

Could you make that change and revert the variable names to what they were, thanks!

[criztovyl]

Thx, yes, I'll look into that :)

[criztovyl]

I could verify locally minikube now reports an start-up error properly:

$ ./out/minikube start                                                                                    
[...]
🔄  Restarting existing podman container for "minikube" ...
🤦  StartHost failed, but will try again: driver start: start: podman start minikube: exit status 125
stdout:  
                                                                               
stderr:                                                                                                                                                       
Error: unable to start container "531125149ee6386faca554d0389b0383ea7e97021776b9401e30459f9dcc76aa": error stat'ing file `/dev/bus/usb/003/003`: No such file or directory: OCI not found

🔄  Restarting existing podman container for "minikube" ...         
😿  Failed to start podman container. Running "minikube delete" may fix it: driver start: start: podman start minikube: exit status 125
stdout:                                        

stderr:                                      
Error: unable to start container "531125149ee6386faca554d0389b0383ea7e97021776b9401e30459f9dcc76aa": error stat'ing file `/dev/bus/usb/003/003`: No such file or directory: OCI not found
                                                                          
[...]

(that's containers/podman#4900, it's fixed upstream but not yet in my distro.)

[spowelljr]

Thanks for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: criztovyl, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[criztovyl]

I hope I am not too impatient; when is the next release, containing this fix, planned? :)

[spowelljr]

We're considering doing a point/patch release, if we do that it'll be included then. Otherwise it would be included with the next minor release with will in a month and a half or so.

[criztovyl]

I see 1.26.1 was released with this fix, thank you!