Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes url index out of range error in service #14658

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fixes url index out of range error in service #14658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2080f
Fix url index out of range error in service
anoop142 Jul 28, 2022
13680ff
fix linting
anoop142 Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/minikube/cmd/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,12 @@ func mutateURLs(serviceName string, urls []string) ([]string, error) {

func openURLs(urls [][]string) {
for _, u := range urls {

if len(u) < 4 {
klog.Warning("No URL found")
continue
}

_, err := url.Parse(u[3])
if err != nil {
klog.Warningf("failed to parse url %q: %v (will not open)", u[3], err)
Expand Down