Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Update Docker from 20.10.17 to 20.10.18 #14935

Merged
merged 4 commits into from Sep 12, 2022
Merged

ISO: Update Docker from 20.10.17 to 20.10.18 #14935

merged 4 commits into from Sep 12, 2022

Conversation

spowelljr
Copy link
Member

https://docs.docker.com/engine/release-notes/#201018

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2022
@spowelljr
Copy link
Member Author

/ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14935/c82d7f3/iso_build.txt

@spowelljr
Copy link
Member Author

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14935/0994a96/iso_build.txt

@spowelljr
Copy link
Member Author

/ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2022
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, building a new ISO failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/14935/2d61bf6/iso_build.txt

@spowelljr
Copy link
Member Author

/ok-to-build-iso

klaases
klaases approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the release notes link and found:

Fix a security vulnerability relating to supplementary group permissions, which could allow a container process to bypass primary group restrictions within the container

Good to have this update to help make minikube more secure.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 12, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14935) |
+----------------+----------+---------------------+
| minikube start | 56.5s    | 57.7s               |
| enable ingress | 26.7s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 57.2s 57.4s 56.7s 56.4s 54.6s
Times for minikube (PR 14935) start: 55.7s 59.2s 59.2s 57.5s 56.8s

Times for minikube ingress: 25.1s 25.1s 29.6s 25.2s 28.7s
Times for minikube (PR 14935) ingress: 29.6s 25.2s 28.6s 29.1s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14935) |
+----------------+----------+---------------------+
| minikube start | 28.7s    | 28.4s               |
| enable ingress | 22.2s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 23.0s 21.9s 21.9s 22.0s
Times for minikube (PR 14935) ingress: 21.4s 26.5s 23.0s 22.0s 23.0s

Times for minikube start: 27.9s 28.1s 28.4s 27.9s 31.4s
Times for minikube (PR 14935) start: 28.9s 28.4s 28.5s 28.6s 27.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14935) |
+----------------+----------+---------------------+
| minikube start | 23.9s    | 25.8s               |
| enable ingress | 27.2s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 25.4s 23.7s 23.0s 24.2s
Times for minikube (PR 14935) start: 23.4s 35.1s 23.8s 23.1s 23.8s

Times for minikube ingress: 26.9s 27.0s 27.4s 27.0s 27.5s
Times for minikube (PR 14935) ingress: 26.9s 26.9s 27.0s 27.0s 26.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNetworkPlugins/group/false/Start (gopogh) 0.65 (chart)
Hyperkit_macOS TestForceSystemdEnv (gopogh) 1.94 (chart)
Hyperkit_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 1.94 (chart)
Hyperkit_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 1.94 (chart)
Docker_macOS TestCertExpiration (gopogh) 6.16 (chart)
Docker_macOS TestCertOptions (gopogh) 6.16 (chart)
Docker_macOS TestDockerFlags (gopogh) 6.16 (chart)
Docker_macOS TestForceSystemdEnv (gopogh) 6.16 (chart)
Docker_macOS TestForceSystemdFlag (gopogh) 6.16 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 6.16 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 6.16 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithK8s (gopogh) 6.16 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 6.16 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 6.16 (chart)
Docker_macOS TestPause/serial/Start (gopogh) 6.16 (chart)
Docker_macOS TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 6.25 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 6.52 (chart)
Docker_macOS TestNetworkPlugins/group/calico/Start (gopogh) 6.52 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 6.52 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 6.52 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonAfterStop (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/EnableAddonWhileActive (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/Stop (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 6.52 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 6.52 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 0ea51c7 into kubernetes:master Sep 12, 2022
@spowelljr spowelljr deleted the updateDocker branch September 12, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spowelljr @minikube-bot @k8s-ci-robot @minikube-pr-bot @klaases