Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QEMU delete errors #14950

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Fix QEMU delete errors #14950

merged 3 commits into from
Sep 13, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Sep 13, 2022

Sometimes QEMU was returning two JSON objects in the response and minikube was failing to unmarshal the response as it's only expecting one JSON object.

Response:

{"return": {}}
{"timestamp": {"seconds": 1663094607, "microseconds": 836663}, "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}

Split the response on \n and only unmarshal the first JSON object.

Also wrapped returns on all the errors for better logging.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/drivers/qemu/qemu.go Outdated Show resolved Hide resolved
@klaases
Copy link
Contributor

klaases commented Sep 13, 2022

Great to see error wrapping for better logging.

@spowelljr spowelljr merged commit 98b27f9 into kubernetes:master Sep 13, 2022
@spowelljr spowelljr deleted the fixQEMUDelete branch September 13, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants