Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kicbase base image #15075

Merged
merged 4 commits into from Oct 10, 2022
Merged

Update kicbase base image #15075

merged 4 commits into from Oct 10, 2022

Conversation

spowelljr
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2022
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 5, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 58.4s    | 58.9s               |
| enable ingress | 29.6s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube start: 57.8s 58.7s 56.7s 57.7s 60.8s
Times for minikube (PR 15075) start: 57.7s 60.1s 57.5s 58.9s 60.4s

Times for minikube ingress: 29.3s 29.3s 29.8s 29.4s 30.3s
Times for minikube (PR 15075) ingress: 28.8s 30.3s 29.3s 28.3s 29.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 30.0s    | 29.7s               |
| enable ingress | 23.0s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube start: 31.6s 31.4s 29.0s 29.0s 28.9s
Times for minikube (PR 15075) start: 28.9s 29.9s 28.8s 31.5s 29.3s

Times for minikube (PR 15075) ingress: 21.5s 21.0s 22.0s 23.1s 22.5s
Times for minikube ingress: 22.1s 22.0s 23.1s 25.1s 22.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 25.3s    | 25.4s               |
| enable ingress | 27.0s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 15075) start: 25.0s 27.8s 24.5s 25.2s 24.3s
Times for minikube start: 27.0s 25.0s 24.3s 25.0s 25.3s

Times for minikube ingress: 27.0s 27.1s 27.0s 27.1s 27.0s
Times for minikube (PR 15075) ingress: 27.1s 27.1s 28.0s 27.1s 28.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/specific-port (gopogh) 0.62 (chart)
Docker_Cloud_Shell TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 1.97 (chart)
Hyper-V_Windows TestStartStop/group/embed-certs/serial/Pause (gopogh) 2.10 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 3.50 (chart)
KVM_Linux_containerd TestPreload (gopogh) 5.73 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/DNS (gopogh) 10.39 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 18.88 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 31.48 (chart)
Docker_Linux_containerd TestPreload (gopogh) 31.48 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 33.55 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 39.87 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 43.42 (chart)
Docker_Windows TestAddons/Setup (gopogh) 49.29 (chart)
Docker_Windows TestCertExpiration (gopogh) 49.29 (chart)
Docker_Windows TestCertOptions (gopogh) 49.29 (chart)
Docker_Windows TestDockerFlags (gopogh) 49.29 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 49.29 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 49.29 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 49.29 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 49.29 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2022
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 56.7s    | 56.2s               |
| enable ingress | 28.0s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 55.1s 56.8s 56.5s 58.0s 56.9s
Times for minikube (PR 15075) start: 55.6s 55.7s 55.6s 59.1s 55.0s

Times for minikube ingress: 29.6s 29.7s 29.2s 27.1s 24.7s
Times for minikube (PR 15075) ingress: 29.2s 25.1s 29.1s 28.2s 28.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 27.5s    | 29.0s               |
| enable ingress | 22.2s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 26.6s 28.0s 27.5s 26.9s 28.5s
Times for minikube (PR 15075) start: 28.6s 29.4s 29.0s 29.1s 29.0s

Times for minikube ingress: 21.5s 22.4s 24.0s 21.5s 21.4s
Times for minikube (PR 15075) ingress: 23.0s 23.0s 21.5s 21.0s 26.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 24.8s               |
| enable ingress | 27.1s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 25.9s 22.5s 37.3s 22.5s
Times for minikube (PR 15075) start: 25.4s 24.8s 24.9s 24.2s 24.9s

Times for minikube ingress: 27.4s 27.0s 27.0s 26.9s 27.0s
Times for minikube (PR 15075) ingress: 27.5s 27.0s 27.0s 27.0s 26.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 55.7s    | 54.9s               |
| enable ingress | 27.9s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 55.9s 56.0s 56.0s 54.5s 55.8s
Times for minikube (PR 15075) start: 55.5s 54.1s 54.1s 55.3s 55.5s

Times for minikube ingress: 28.7s 24.2s 28.6s 29.2s 28.6s
Times for minikube (PR 15075) ingress: 28.7s 25.7s 29.7s 29.1s 30.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15075) |
+-------------------+----------+---------------------+
| minikube start    | 29.2s    | 27.3s               |
| ⚠️  enable ingress | 21.8s    | 34.0s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 27.6s 30.7s 31.9s 27.9s 28.1s
Times for minikube (PR 15075) start: 27.9s 28.4s 27.2s 26.8s 26.0s

Times for minikube ingress: 20.5s 22.5s 21.5s 23.0s 21.5s
Times for minikube (PR 15075) ingress: 22.0s 21.5s 83.0s 21.5s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15075) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.6s               |
| enable ingress | 27.1s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.0s 27.5s 27.0s 27.0s 27.0s
Times for minikube (PR 15075) ingress: 27.0s 27.5s 27.0s 27.5s 27.5s

Times for minikube start: 25.7s 23.3s 23.3s 22.5s 22.8s
Times for minikube (PR 15075) start: 22.0s 23.0s 23.3s 26.4s 23.3s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 0d46008 into kubernetes:master Oct 10, 2022
@spowelljr spowelljr deleted the updateUbuntu branch October 10, 2022 19:18
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestFunctional/serial/LogsFileCmd (gopogh) 1.21 (chart)
Docker_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 6.76 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 29.09 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 39.22 (chart)
KVM_Linux_containerd TestPreload (gopogh) 40.00 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 43.48 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 54.66 (chart)
Docker_Linux_containerd TestPreload (gopogh) 56.36 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 76.47 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 79.62 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 82.17 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 82.80 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 84.71 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 89.81 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestDownloadOnly/v1.16.0/preload-exists (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestErrorSpam/setup (gopogh) 0.00 (chart)
Docker_Linux TestErrorSpam/setup (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.16.0/preload-exists (gopogh) 0.00 (chart)
Docker_macOS TestDownloadOnlyKic (gopogh) 0.62 (chart)
Docker_macOS TestErrorSpam/setup (gopogh) 0.62 (chart)
Docker_macOS TestDownloadOnly/v1.25.2/preload-exists (gopogh) 0.74 (chart)
Hyperkit_macOS TestNoKubernetes/serial/Stop (gopogh) 2.05 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 39.22 (chart)
KVM_Linux_containerd TestPreload (gopogh) 40.00 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 41.18 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 42.15 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 42.62 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 43.70 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 43.70 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 43.70 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 44.17 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 44.88 (chart)
Docker_Windows TestAddons/Setup (gopogh) 49.30 (chart)
Docker_Windows TestCertExpiration (gopogh) 49.30 (chart)
Docker_Windows TestCertOptions (gopogh) 49.30 (chart)
Docker_Windows TestDockerFlags (gopogh) 49.30 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 49.30 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 49.30 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 49.30 (chart)
Docker_Windows TestFunctional/parallel/CertSync (gopogh) 49.30 (chart)
Docker_Windows TestFunctional/parallel/CpCmd (gopogh) 49.30 (chart)
Docker_Windows TestFunctional/parallel/FileSync (gopogh) 49.30 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 49.30 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 49.30 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 49.30 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spowelljr @minikube-bot @minikube-pr-bot @k8s-ci-robot @medyagh