Added version.json and CHANGELOG to kicbase image and ISO. Added version validation to start.go. #15235

ckannon · 2022-10-28T20:37:22Z

Adds version.json to iso and kicbase image, fixes #10561 also adds version validation.

k8s-ci-robot · 2022-10-28T20:37:31Z

Hi @ckannon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-10-28T20:39:03Z

Can one of the admins verify this patch?

cmd/minikube/cmd/start.go

spowelljr · 2022-11-02T16:57:04Z

ok-to-build-iso

spowelljr · 2022-11-02T16:57:11Z

ok-to-build-image

minikube-bot · 2022-11-02T17:12:37Z

Hi @ckannon, building a new kicbase image failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/15235/cd825bd/kic_image_build.txt

spowelljr · 2022-11-02T17:53:36Z

ok-to-build-image

minikube-bot · 2022-11-02T18:12:45Z

Hi @ckannon, building a new kicbase image failed.
See the logs at: https://storage.cloud.google.com/minikube-builds/logs/15235/47f9fd1/kic_image_build.txt

Added CHANGELOG to kicbase and ISO. Updated gh to latest version 2.18.1.

spowelljr · 2022-11-02T18:24:53Z

ok-to-build-image

minikube-bot · 2022-11-02T18:52:24Z

Hi @ckannon, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

.gitignore

hack/jenkins/build_changelog.sh

…tead

spowelljr · 2022-11-17T15:46:56Z

ok-to-build-iso

minikube-pr-bot · 2022-11-17T16:10:23Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 54.1s    | 54.5s               |
| enable ingress | 26.8s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 53.4s 53.3s 55.6s 55.4s 52.7s
Times for minikube (PR 15235) start: 54.2s 54.0s 53.8s 54.4s 56.3s

Times for minikube ingress: 25.2s 27.6s 26.6s 27.1s 27.6s
Times for minikube (PR 15235) ingress: 28.1s 24.2s 25.1s 28.1s 27.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 27.2s               |
| enable ingress | 22.2s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 15235) ingress: 21.5s 21.5s 21.0s 22.0s 22.0s
Times for minikube ingress: 23.5s 22.0s 21.5s 22.0s 22.0s

Times for minikube start: 25.2s 25.7s 28.4s 26.0s 26.4s
Times for minikube (PR 15235) start: 26.5s 27.1s 26.6s 27.8s 28.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 24.2s               |
| enable ingress | 27.2s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 22.1s 21.5s 22.0s 22.5s
Times for minikube (PR 15235) start: 26.3s 24.0s 23.2s 23.5s 24.1s

Times for minikube ingress: 27.0s 27.0s 27.4s 27.0s 27.5s
Times for minikube (PR 15235) ingress: 27.0s 27.0s 27.5s 27.4s 26.0s

minikube-pr-bot · 2022-11-17T16:51:37Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 53.1s    | 52.9s               |
| enable ingress | 28.2s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 15235) start: 53.6s 52.5s 51.6s 54.6s 51.9s
Times for minikube start: 52.7s 53.6s 52.6s 53.9s 52.6s

Times for minikube ingress: 28.7s 26.2s 29.2s 28.7s 28.2s
Times for minikube (PR 15235) ingress: 28.2s 29.1s 28.7s 28.2s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 27.8s    | 27.0s               |
| enable ingress | 28.5s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.5s 22.4s 22.5s 50.5s 21.5s
Times for minikube (PR 15235) ingress: 22.0s 22.5s 21.5s 22.5s 21.5s

Times for minikube start: 28.6s 26.6s 28.5s 28.3s 26.8s
Times for minikube (PR 15235) start: 28.6s 25.7s 25.5s 26.8s 28.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 23.6s               |
| enable ingress | 26.7s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.0s 27.0s 27.0s 26.0s 26.5s
Times for minikube (PR 15235) ingress: 27.0s 26.5s 26.0s 27.0s 27.0s

Times for minikube start: 21.9s 22.5s 22.4s 22.6s 22.3s
Times for minikube (PR 15235) start: 22.7s 22.2s 25.7s 21.9s 25.2s

minikube-pr-bot · 2022-11-17T19:21:06Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestErrorSpam/setup (gopogh)	0.00 (chart)
Docker_Linux	TestErrorSpam/setup (gopogh)	0.00 (chart)
Docker_macOS	TestErrorSpam/setup (gopogh)	0.00 (chart)
Docker_Windows	TestErrorSpam/setup (gopogh)	0.00 (chart)
Docker_macOS	TestNetworkPlugins/group/cilium/Start (gopogh)	10.53 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	11.18 (chart)
Docker_macOS	TestNetworkPlugins/group/false/Start (gopogh)	11.18 (chart)
Docker_macOS	TestNetworkPlugins/group/calico/Start (gopogh)	12.50 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	13.16 (chart)
Docker_macOS	TestMultiNode/serial/RestartMultiNode (gopogh)	27.78 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	35.71 (chart)
Docker_Windows	TestNetworkPlugins/group/false/DNS (gopogh)	43.62 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	45.76 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	46.22 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	46.67 (chart)
Docker_Linux_containerd	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	47.11 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	50.00 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	50.00 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	50.83 (chart)
Docker_Linux_containerd	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	51.24 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	51.30 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	83.97 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	83.97 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	87.18 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/NetCatPod (gopogh)	87.50 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	99.15 (chart)
Docker_Linux_containerd	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2022-11-17T20:35:50Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/DNS (gopogh)	4.07 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/flannel/Start (gopogh)	12.99 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	20.13 (chart)
Hyperkit_macOS	TestPause/serial/SecondStartNoReconfiguration (gopogh)	22.93 (chart)
Docker_Linux_containerd	TestPause/serial/Start (gopogh)	23.95 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	26.62 (chart)
Docker_Linux_containerd	TestAddons/Setup (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/ServiceCmdConnect (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/serial/ExtraConfig (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/serial/SoftStart (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestFunctional/serial/StartWithProxy (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestJSONOutput/start/Command (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/AddNode (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/DeployApp2Nodes (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/FreshStart2Nodes (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/ProfileList (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StartAfterStop (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/StopNode (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestOffline (gopogh)	29.34 (chart)
Docker_Linux_containerd	TestMultiNode/serial/RestartMultiNode (gopogh)	29.94 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-bot · 2022-11-17T21:10:18Z

Hi @ckannon, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

minikube-pr-bot · 2022-11-17T22:10:29Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 53.0s    | 53.6s               |
| enable ingress | 27.1s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube start: 51.5s 52.8s 54.2s 52.0s 54.6s
Times for minikube (PR 15235) start: 54.2s 53.2s 51.6s 53.5s 55.4s

Times for minikube (PR 15235) ingress: 28.2s 24.2s 24.7s 28.2s 28.3s
Times for minikube ingress: 24.7s 28.6s 25.2s 28.2s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 25.9s    | 26.2s               |
| enable ingress | 21.1s    | 20.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.5s 21.9s 21.9s 21.0s 20.0s
Times for minikube (PR 15235) ingress: 20.5s 21.5s 19.4s 21.4s 20.4s

Times for minikube start: 25.1s 25.1s 28.3s 25.0s 26.0s
Times for minikube (PR 15235) start: 28.5s 25.9s 24.7s 26.0s 25.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 24.6s               |
| enable ingress | 26.3s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 24.5s 22.6s 21.8s 21.4s
Times for minikube (PR 15235) start: 21.7s 21.8s 32.9s 21.3s 25.1s

Times for minikube ingress: 26.4s 25.9s 25.9s 27.4s 26.0s
Times for minikube (PR 15235) ingress: 26.4s 26.4s 26.4s 26.4s 26.0s

spowelljr

Looks like you're changing the time-to-k8s repo version back, once that gets reverted this looks good to merge

(cherry picked from commit 9c10fe2)

k8s-ci-robot · 2022-11-18T15:43:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckannon, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2022-11-18T16:08:59Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 53.4s               |
| enable ingress | 27.2s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 24.1s 28.1s 27.6s 28.6s 27.6s
Times for minikube (PR 15235) ingress: 29.6s 24.1s 30.1s 28.7s 27.6s

Times for minikube start: 53.5s 52.5s 51.2s 53.8s 55.8s
Times for minikube (PR 15235) start: 53.9s 51.2s 54.1s 53.9s 54.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 25.6s    | 26.0s               |
| enable ingress | 20.9s    | 21.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 15235) start: 25.9s 25.0s 25.1s 25.9s 28.0s
Times for minikube start: 27.2s 26.0s 24.9s 25.1s 25.0s

Times for minikube ingress: 22.0s 19.5s 20.5s 22.0s 20.5s
Times for minikube (PR 15235) ingress: 19.4s 21.0s 22.0s 22.5s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 24.0s               |
| enable ingress | 26.4s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 21.0s 21.8s 21.4s 21.8s
Times for minikube (PR 15235) start: 21.0s 21.3s 21.5s 22.2s 34.2s

Times for minikube ingress: 26.0s 27.4s 26.4s 26.5s 26.0s
Times for minikube (PR 15235) ingress: 26.4s 25.9s 26.4s 26.4s 26.4s

minikube-pr-bot · 2022-11-18T16:52:22Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 54.1s               |
| enable ingress | 27.1s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.7s 25.7s 28.7s 27.6s 27.8s
Times for minikube (PR 15235) ingress: 29.2s 28.7s 28.7s 28.2s 27.2s

Times for minikube start: 54.3s 52.9s 52.6s 53.2s 54.0s
Times for minikube (PR 15235) start: 54.7s 53.0s 54.0s 53.1s 55.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 25.2s               |
| enable ingress | 20.6s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube start: 25.1s 26.7s 25.7s 28.6s 25.8s
Times for minikube (PR 15235) start: 24.6s 25.2s 25.0s 26.3s 24.9s

Times for minikube ingress: 22.0s 20.5s 19.4s 20.9s 20.0s
Times for minikube (PR 15235) ingress: 20.5s 21.0s 22.5s 20.5s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15235) |
+----------------+----------+---------------------+
| minikube start | 24.9s    | 22.3s               |
| enable ingress | 26.2s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.5s 26.0s 26.0s 26.0s 26.4s
Times for minikube (PR 15235) ingress: 25.9s 26.0s 27.4s 26.4s 26.0s

Times for minikube start: 22.0s 33.0s 25.2s 21.5s 22.7s
Times for minikube (PR 15235) start: 22.5s 22.3s 22.6s 22.0s 22.3s

minikube-pr-bot · 2022-11-18T19:11:33Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	0.63 (chart)
Hyperkit_macOS	TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh)	0.63 (chart)
Hyperkit_macOS	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	0.63 (chart)
Hyperkit_macOS	TestForceSystemdEnv (gopogh)	1.27 (chart)
KVM_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	3.03 (chart)
Hyperkit_macOS	TestPause/serial/SecondStartNoReconfiguration (gopogh)	22.78 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	35.53 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	49.34 (chart)
Docker_Linux	TestNetworkPlugins/group/calico/Start (gopogh)	80.00 (chart)
Docker_Linux	TestNetworkPlugins/group/bridge/DNS (gopogh)	83.87 (chart)
Docker_Linux	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	83.87 (chart)
Docker_Linux	TestNetworkPlugins/group/false/DNS (gopogh)	83.87 (chart)
Docker_Linux	TestNetworkPlugins/group/kubenet/DNS (gopogh)	87.10 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	99.15 (chart)
Docker_Linux_containerd	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_Linux_containerd	TestPreload (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/HairPin (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2022

k8s-ci-robot requested review from afbjorklund and spowelljr October 28, 2022 20:38

ckannon force-pushed the master branch from 7296f1f to 3bd9005 Compare October 28, 2022 20:58

spowelljr requested changes Oct 28, 2022

View reviewed changes

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

ckannon force-pushed the master branch from 3bd9005 to 70c85bc Compare October 31, 2022 13:47

ckannon marked this pull request as draft November 1, 2022 20:56

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2022

ckannon force-pushed the master branch from 70c85bc to 50635d9 Compare November 2, 2022 16:28

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2022

ckannon changed the title ~~Added version.json to kicbase image and version validation to start.go~~ Added version.json and CHANGELOG to kicbase image and ISO. Added version validation to start.go. Nov 2, 2022

ckannon force-pushed the master branch 3 times, most recently from 5c388b3 to cd825bd Compare November 2, 2022 16:34

ckannon force-pushed the master branch from cd825bd to 47f9fd1 Compare November 2, 2022 17:21

Added version.json to kicbase image and version validation to start.go.

320c41f

Added CHANGELOG to kicbase and ISO. Updated gh to latest version 2.18.1.

ckannon force-pushed the master branch from 47f9fd1 to 320c41f Compare November 2, 2022 18:17

Updating kicbase image to v0.0.35-1667414058-15235

a32eee2

spowelljr requested changes Nov 17, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

hack/jenkins/build_changelog.sh Outdated Show resolved Hide resolved

Remove startup error message on older version of ISO, sent to log ins…

c4c05a7

…tead

ckannon force-pushed the master branch from 06f13a1 to c4c05a7 Compare November 17, 2022 14:51

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2022

Merge branch 'master' into master

2a86770

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2022

Updating docs, fixing kicbase SHA

b66666a

Updating ISO to v1.28.0-1668700269-15235

4aa487e

spowelljr requested changes Nov 18, 2022

View reviewed changes

spowelljr mentioned this pull request Nov 18, 2022

Revert setting snapshotter to fuse-overlayfs #15272

Merged

Merge updated time-to-k8s-repo

9d67cba

ckannon force-pushed the master branch from 51671e4 to 507f62b Compare November 18, 2022 15:36

update docsy

ed00f31

(cherry picked from commit 9c10fe2)

ckannon force-pushed the master branch from 507f62b to ed00f31 Compare November 18, 2022 15:40

spowelljr approved these changes Nov 18, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022

spowelljr merged commit 6754740 into kubernetes:master Nov 18, 2022

This was referenced Nov 28, 2022

Add minimum ISO version check #14490

Closed

kicbase automation: include the changelog in the PR since last stable kic release #10605

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added version.json and CHANGELOG to kicbase image and ISO. Added version validation to start.go. #15235

Added version.json and CHANGELOG to kicbase image and ISO. Added version validation to start.go. #15235

ckannon commented Oct 28, 2022 •

edited

k8s-ci-robot commented Oct 28, 2022

minikube-bot commented Oct 28, 2022

spowelljr commented Nov 2, 2022

spowelljr commented Nov 2, 2022

minikube-bot commented Nov 2, 2022

spowelljr commented Nov 2, 2022

minikube-bot commented Nov 2, 2022

spowelljr commented Nov 2, 2022

minikube-bot commented Nov 2, 2022

spowelljr commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

spowelljr left a comment

k8s-ci-robot commented Nov 18, 2022

minikube-pr-bot commented Nov 18, 2022

minikube-pr-bot commented Nov 18, 2022

minikube-pr-bot commented Nov 18, 2022

Added version.json and CHANGELOG to kicbase image and ISO. Added version validation to start.go. #15235

Added version.json and CHANGELOG to kicbase image and ISO. Added version validation to start.go. #15235

Conversation

ckannon commented Oct 28, 2022 • edited

k8s-ci-robot commented Oct 28, 2022

minikube-bot commented Oct 28, 2022

spowelljr commented Nov 2, 2022

spowelljr commented Nov 2, 2022

minikube-bot commented Nov 2, 2022

spowelljr commented Nov 2, 2022

minikube-bot commented Nov 2, 2022

spowelljr commented Nov 2, 2022

minikube-bot commented Nov 2, 2022

spowelljr commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

minikube-bot commented Nov 17, 2022

minikube-pr-bot commented Nov 17, 2022

spowelljr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 18, 2022

minikube-pr-bot commented Nov 18, 2022

minikube-pr-bot commented Nov 18, 2022

minikube-pr-bot commented Nov 18, 2022

ckannon commented Oct 28, 2022 •

edited