Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows installer script to create system-wide shortcut #15405

Merged
merged 3 commits into from Nov 30, 2022
Merged

Update Windows installer script to create system-wide shortcut #15405

merged 3 commits into from Nov 30, 2022

Conversation

correialabbate
Copy link
Contributor

Related issue: #13029
Problem: when using the Windows installer, it only creates a shortcut in the Start Menu for the user installing minikube. Since the installation process is a system-wide process, it should also create a Start Menu shortcut for other users on the machine.

Implemented the solution suggested by https://github.com/xenophonf - who opened the issue.
Tested both install and uninstall locally using a Windows 10 - Version 21H2 machine, and got the new expected behaviour.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 25, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @correialabbate!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @correialabbate. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2022
@correialabbate correialabbate mentioned this pull request Nov 25, 2022
Closed
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15405) |
+----------------+----------+---------------------+
| minikube start | 54.7s    | 55.2s               |
| enable ingress | 26.9s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 54.7s 54.1s 55.1s 55.2s 54.6s
Times for minikube (PR 15405) start: 57.5s 54.9s 55.7s 53.9s 53.8s

Times for minikube ingress: 25.1s 27.7s 28.1s 25.1s 28.2s
Times for minikube (PR 15405) ingress: 27.2s 28.1s 27.7s 27.7s 25.2s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 90

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestMultiNode/serial/ValidateNameConflict (gopogh) 3.40 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 12.78 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 20.00 (chart)
Docker_Linux_containerd TestOffline (gopogh) 21.94 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 25.16 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 25.16 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 25.16 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 25.16 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/ProfileList (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/StartAfterStop (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/StopNode (gopogh) 25.16 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 28.39 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 28.39 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 43.90 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr
spowelljr approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and confirm that it worked, thanks for the PR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: correialabbate, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@spowelljr spowelljr merged commit 0ff5db3 into kubernetes:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@correialabbate @k8s-ci-robot @minikube-bot @spowelljr @minikube-pr-bot @felipe-labbate