Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add functional_docker_rootless_containerd_ubuntu #15450

Merged
merged 3 commits into from Jan 17, 2023
Merged

CI: add functional_docker_rootless_containerd_ubuntu #15450

merged 3 commits into from Jan 17, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 2, 2022 •
edited

For testing the docker driver with Rootless Docker.

The ubuntu-22.04 image on GHA is used as the cgroup v2 infra.

Fix #12456

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@AkihiroSuda AkihiroSuda force-pushed the ci-rootless branch 4 times, most recently from 9712ea5 to 7e77cc2 Compare December 2, 2022 09:22
@medyagh
Copy link
Member

medyagh commented Dec 3, 2022

nice ! @AkihiroSuda

@medyagh
Copy link
Member

medyagh commented Dec 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 3, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 55.8s    | 53.4s               |
| enable ingress | 27.5s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 56.0s 54.6s 54.0s 58.6s 55.7s
Times for minikube (PR 15450) start: 53.9s 52.8s 55.7s 52.3s 52.5s

Times for minikube ingress: 28.2s 26.2s 28.2s 29.2s 25.6s
Times for minikube (PR 15450) ingress: 26.2s 25.7s 28.2s 26.6s 24.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 26.5s               |
| enable ingress | 21.0s    | 20.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.5s 21.4s 21.0s 19.5s 21.5s
Times for minikube (PR 15450) ingress: 22.0s 19.0s 20.5s 21.0s 21.0s

Times for minikube start: 24.2s 25.4s 24.0s 24.8s 24.7s
Times for minikube (PR 15450) start: 30.0s 24.6s 27.9s 24.9s 25.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 23.4s               |
| enable ingress | 26.4s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 22.0s 22.5s 23.4s 22.6s
Times for minikube (PR 15450) start: 22.2s 24.9s 22.4s 22.5s 24.9s

Times for minikube ingress: 26.4s 26.4s 26.4s 25.9s 26.5s
Times for minikube (PR 15450) ingress: 25.9s 26.5s 26.0s 26.5s 26.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/EnableAddonAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/Stop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 0.68 (chart)
Docker_Windows TestPause/serial/Pause (gopogh) 8.90 (chart)
Docker_Windows TestMultiNode/serial/StartAfterStop (gopogh) 9.33 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 9.70 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 9.70 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 9.70 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 9.70 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 9.70 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 9.70 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 9.70 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Stop (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 9.70 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 9.70 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@AkihiroSuda
Copy link
Member Author

@medyagh @afbjorklund Could you take a look?

@AkihiroSuda
Copy link
Member Author

Rebased

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 54.9s    | 54.2s               |
| enable ingress | 27.1s    | 25.7s               |
+----------------+----------+---------------------+

Times for minikube start: 54.0s 54.3s 55.9s 57.0s 53.4s
Times for minikube (PR 15450) start: 55.5s 53.6s 53.8s 55.4s 52.8s

Times for minikube (PR 15450) ingress: 24.7s 24.6s 24.7s 25.6s 28.6s
Times for minikube ingress: 27.7s 25.6s 28.6s 25.2s 28.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15450) |
+-------------------+----------+---------------------+
| minikube start    | 26.1s    | 26.2s               |
| ⚠️  enable ingress | 21.1s    | 37.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 25.0s 24.7s 24.2s 27.8s 28.8s
Times for minikube (PR 15450) start: 26.3s 25.5s 24.8s 25.6s 28.9s

Times for minikube ingress: 20.4s 22.5s 19.5s 22.5s 20.4s
Times for minikube (PR 15450) ingress: 49.5s 20.0s 49.5s 49.0s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 22.1s               |
| enable ingress | 26.3s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.5s 25.1s 22.2s 22.8s 21.8s
Times for minikube (PR 15450) start: 22.6s 22.0s 21.7s 21.8s 22.3s

Times for minikube ingress: 26.0s 26.5s 26.0s 26.4s 26.4s
Times for minikube (PR 15450) ingress: 26.5s 26.5s 26.0s 25.9s 26.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) n/a
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) n/a
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) n/a
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) n/a
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/Setup (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/serial/CacheCmd/cache/add_local (gopogh) 0.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/DNS (gopogh) 5.79 (chart)
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 8.70 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 8.70 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 8.70 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 8.70 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 9.09 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 9.09 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 9.09 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 9.09 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 9.09 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 9.09 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 9.09 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh) 9.09 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr
spowelljr requested changes Jan 11, 2023
View reviewed changes
.github/workflows/pr.yml Show resolved Hide resolved
@AkihiroSuda
minikube image load: print more debug logs
98d5467 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
main: propagate the current Docker CLI context to $DOCKER_HOST
ba11072 
So that google/go-containerregistry can pick it up

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
CI: add functional_docker_rootless_containerd_ubuntu
6ab61b7 
Fix issue 12456

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 57.7s    | 54.7s               |
| enable ingress | 28.3s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 57.1s 54.2s 67.4s 53.9s 55.9s
Times for minikube (PR 15450) start: 54.4s 55.0s 54.7s 54.9s 54.7s

Times for minikube ingress: 27.7s 28.7s 28.7s 28.7s 27.7s
Times for minikube (PR 15450) ingress: 28.3s 28.7s 28.7s 28.2s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 27.3s               |
| enable ingress | 32.4s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 15450) start: 25.5s 25.3s 27.8s 29.3s 28.7s
Times for minikube start: 24.3s 26.4s 24.6s 26.3s 25.7s

Times for minikube ingress: 20.0s 19.5s 20.5s 81.4s 20.5s
Times for minikube (PR 15450) ingress: 25.0s 20.5s 21.0s 20.9s 81.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15450) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 23.8s               |
| enable ingress | 32.6s    | 26.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.7s 21.6s 22.4s 22.3s 25.2s
Times for minikube (PR 15450) start: 21.2s 21.2s 21.6s 32.9s 22.2s

Times for minikube (PR 15450) ingress: 26.0s 26.0s 26.0s 26.0s 26.0s
Times for minikube ingress: 26.5s 26.4s 26.4s 26.0s 57.5s

@AkihiroSuda AkihiroSuda requested review from spowelljr and removed request for medyagh January 17, 2023 01:14
spowelljr
spowelljr approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR

@spowelljr spowelljr merged commit a8ea194 into kubernetes:master Jan 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: cgroup v2 CI infra (for testing Rootless Docker driver)
6 participants
@AkihiroSuda @minikube-bot @medyagh @minikube-pr-bot @spowelljr @k8s-ci-robot