Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --static-ip flag #15553

Merged
merged 3 commits into from Jan 9, 2023
Merged

Implement --static-ip flag #15553

merged 3 commits into from Jan 9, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Dec 27, 2022 •
edited

Closes #15523

Includes entry to FAQ and Tutorial pages of website

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 27, 2022
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 27, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 54.2s    | 54.2s               |
| enable ingress | 26.6s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube start: 53.1s 53.3s 56.0s 52.9s 55.6s
Times for minikube (PR 15553) start: 55.5s 54.1s 55.0s 53.1s 53.3s

Times for minikube ingress: 24.1s 27.7s 23.7s 29.2s 28.3s
Times for minikube (PR 15553) ingress: 28.2s 29.7s 25.7s 25.1s 25.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15553) |
+-------------------+----------+---------------------+
| minikube start    | 25.9s    | 27.0s               |
| ⚠️  enable ingress | 20.4s    | 27.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 25.4s 27.2s 26.1s 26.1s 24.8s
Times for minikube (PR 15553) start: 26.6s 29.2s 29.2s 24.3s 25.6s

Times for minikube (PR 15553) ingress: 22.0s 21.4s 21.5s 22.0s 49.0s
Times for minikube ingress: 20.9s 20.9s 18.4s 21.0s 20.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 23.6s    | 25.5s               |
| enable ingress | 26.4s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.9s 26.4s 26.4s 26.4s 26.5s
Times for minikube (PR 15553) ingress: 26.5s 26.0s 26.0s 26.5s 26.4s

Times for minikube start: 25.5s 21.3s 21.3s 25.4s 24.4s
Times for minikube (PR 15553) start: 21.4s 22.3s 33.1s 25.2s 25.6s

medyagh
medyagh reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add both FAQ and tutorial on website and fix the lint

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 55.3s    | 55.3s               |
| enable ingress | 27.9s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 55.0s 53.9s 56.8s 54.6s 56.1s
Times for minikube (PR 15553) start: 53.4s 54.4s 56.3s 57.5s 54.8s

Times for minikube ingress: 28.2s 26.1s 28.7s 27.2s 29.2s
Times for minikube (PR 15553) ingress: 26.2s 28.2s 27.7s 27.8s 27.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 25.4s    | 25.4s               |
| enable ingress | 38.9s    | 33.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.4s 19.5s 82.9s 50.0s 20.5s
Times for minikube (PR 15553) ingress: 20.0s 22.0s 21.0s 81.5s 21.5s

Times for minikube start: 24.7s 24.7s 26.4s 25.6s 25.6s
Times for minikube (PR 15553) start: 24.7s 28.0s 24.5s 24.1s 25.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 24.1s    | 25.2s               |
| enable ingress | 26.3s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 33.5s 21.9s 22.1s 21.8s
Times for minikube (PR 15553) start: 23.1s 21.8s 35.6s 22.7s 22.5s

Times for minikube ingress: 25.9s 25.9s 26.0s 27.0s 26.4s
Times for minikube (PR 15553) ingress: 26.5s 26.5s 26.9s 26.4s 26.4s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) n/a
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/calico/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) n/a
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) n/a
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) n/a
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 8.26 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 21.21 (chart)
Docker_Linux_containerd TestOffline (gopogh) 24.85 (chart)
Docker_Linux_containerd TestAddons/Setup (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 26.67 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 26.67 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 26.67 (chart)
Docker_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 26.67 (chart)
Docker_Linux_containerd TestJSONOutput/start/Command (gopogh) 26.67 (chart)
Docker_Linux_containerd TestMultiNode/serial/AddNode (gopogh) 26.67 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 26.67 (chart)
Docker_Linux_containerd TestMultiNode/serial/FreshStart2Nodes (gopogh) 26.67 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 54.0s    | 53.6s               |
| enable ingress | 26.6s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 53.7s 52.7s 53.8s 53.8s 55.8s
Times for minikube (PR 15553) start: 54.6s 53.8s 52.5s 54.0s 53.0s

Times for minikube ingress: 27.2s 27.7s 24.7s 29.1s 24.2s
Times for minikube (PR 15553) ingress: 24.2s 28.7s 25.2s 28.2s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 26.9s               |
| enable ingress | 33.5s    | 33.4s               |
+----------------+----------+---------------------+

Times for minikube start: 24.7s 29.3s 25.5s 28.8s 28.1s
Times for minikube (PR 15553) start: 25.4s 28.0s 26.2s 27.4s 27.7s

Times for minikube ingress: 21.4s 81.0s 21.5s 20.5s 23.0s
Times for minikube (PR 15553) ingress: 22.0s 21.0s 21.0s 82.0s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 23.1s               |
| enable ingress | 26.2s    | 26.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.0s 26.5s 25.9s 26.4s 26.0s
Times for minikube (PR 15553) ingress: 26.4s 27.4s 26.5s 26.4s 26.5s

Times for minikube start: 21.8s 23.1s 21.7s 25.3s 21.8s
Times for minikube (PR 15553) start: 25.2s 21.4s 22.3s 21.3s 25.5s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 54.7s    | 54.6s               |
| enable ingress | 27.1s    | 26.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.6s 27.2s 27.7s 24.7s 28.2s
Times for minikube (PR 15553) ingress: 24.7s 25.2s 27.2s 25.1s 29.2s

Times for minikube start: 54.8s 54.5s 55.4s 54.9s 54.1s
Times for minikube (PR 15553) start: 55.2s 54.3s 55.3s 53.8s 54.3s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15553) |
+-------------------+----------+---------------------+
| minikube start    | 25.9s    | 26.6s               |
| ⚠️  enable ingress | 26.5s    | 32.6s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 25.9s 26.0s 24.9s 28.4s 24.6s
Times for minikube (PR 15553) start: 25.9s 26.1s 28.9s 26.3s 25.7s

Times for minikube ingress: 20.9s 21.4s 20.9s 49.9s 19.4s
Times for minikube (PR 15553) ingress: 22.4s 20.9s 19.9s 19.4s 80.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15553) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 22.6s               |
| enable ingress | 26.4s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 22.2s 25.0s 21.9s 24.7s
Times for minikube (PR 15553) start: 21.6s 23.0s 21.9s 24.7s 21.6s

Times for minikube ingress: 26.4s 26.4s 26.4s 26.4s 26.4s
Times for minikube (PR 15553) ingress: 26.5s 25.9s 25.9s 26.0s 26.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestErrorSpam/setup (gopogh) n/a
Hyper-V_Windows TestMultiNode/serial/DeployApp2Nodes (gopogh) n/a
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) n/a
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) n/a
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) n/a
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) n/a
Docker_Windows TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 2.63 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/kindnet/Start (gopogh) 5.26 (chart)
Docker_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 26.57 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 30.61 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 38.46 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 40.71 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 40.71 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 41.23 (chart)
Docker_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 41.23 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/FirstStart (gopogh) 43.36 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 43.36 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 43.86 (chart)
Docker_Linux_containerd TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 45.30 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 49.56 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 50.43 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 50.43 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 50.86 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 52.45 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 73.73 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 74.59 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 85.96 (chart)
Docker_Linux TestNetworkPlugins/group/calico/NetCatPod (gopogh) 88.89 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 98.23 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) n/a
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) n/a
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) n/a
Docker_macOS TestNoKubernetes/serial/Start (gopogh) 8.76 (chart)
Docker_macOS TestNoKubernetes/serial/StartNoArgs (gopogh) 8.76 (chart)
Docker_macOS TestNoKubernetes/serial/StartWithStopK8s (gopogh) 8.76 (chart)
Docker_macOS TestNoKubernetes/serial/Stop (gopogh) 8.76 (chart)
Docker_macOS TestNetworkPlugins/group/auto/Start (gopogh) 9.16 (chart)
Docker_macOS TestNetworkPlugins/group/bridge/Start (gopogh) 9.16 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 9.16 (chart)
Docker_macOS TestNetworkPlugins/group/false/Start (gopogh) 9.16 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/Stop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/DeployApp (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Pause (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/SecondStart (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/Stop (gopogh) 9.16 (chart)
Docker_macOS TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh) 9.16 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 0fee35b into kubernetes:master Jan 9, 2023
@spowelljr spowelljr deleted the addStaticIP branch January 9, 2023 19:20
@medyagh medyagh mentioned this pull request Jan 11, 2023
Closed
@afbjorklund afbjorklund mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --static-ip flag
4 participants
@spowelljr @minikube-pr-bot @k8s-ci-robot @medyagh