Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new flag --skip-audit and skip profile cmd from audit by default #15872

Merged
merged 3 commits into from Feb 17, 2023

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 16, 2023

$ make && mk cp --skip-audit

❌  Exiting due to MK_USAGE: Please specify the path to copy: 
        minikube cp <source file path> <target file absolute path> (example: "minikube cp a/b.txt /copied.txt")

$ mk logs --audit
==> Audit <==
|---------|------|---------|------|---------|------------|----------|
| Command | Args | Profile | User | Version | Start Time | End Time |
|---------|------|---------|------|---------|------------|----------|
|---------|------|---------|------|---------|------------|----------|

$ make && mk cp

make: `out/minikube' is up to date.
❌  Exiting due to MK_USAGE: Please specify the path to copy: 
        minikube cp <source file path> <target file absolute path> (example: "minikube cp a/b.txt /copied.txt")

$ mk logs --audit
==> Audit <==
|---------|------|----------|-------|---------|---------------------|----------|
| Command | Args | Profile | User | Version | Start Time | End Time |
|---------|------|----------|-------|---------|---------------------|----------|
| cp | | minikube | medya | v1.29.0 | 16 Feb 23 12:55 PST | |
|---------|------|----------|-------|---------|---------------------|----------|



since profile list is used a lot by other tools it is better to not add to audit to declutter for more important commands

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2023
@medyagh medyagh changed the title add a new flag called --skip-aduit new flag --skip-aduit to skip recording current command in audit and skip "profile" command by default Feb 16, 2023
@medyagh medyagh changed the title new flag --skip-aduit to skip recording current command in audit and skip "profile" command by default new flag --skip-audit to skip recording current command in audit and skip "profile" command by default Feb 16, 2023
@medyagh medyagh changed the title new flag --skip-audit to skip recording current command in audit and skip "profile" command by default new flag --skip-audit and skip profile command from audit by default Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2023
pkg/minikube/config/config.go Outdated Show resolved Hide resolved
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
@medyagh
Copy link
Member Author

medyagh commented Feb 16, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 16, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15872) |
+----------------+----------+---------------------+
| minikube start | 54.6s    | 54.4s               |
| enable ingress | 27.4s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 15872) start: 54.2s 54.2s 51.9s 54.5s 57.3s
Times for minikube start: 53.1s 54.9s 56.4s 55.0s 53.9s

Times for minikube (PR 15872) ingress: 29.3s 26.8s 25.2s 27.8s 29.2s
Times for minikube ingress: 28.3s 28.7s 25.7s 28.7s 25.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15872) |
+----------------+----------+---------------------+
| minikube start | 26.4s    | 27.2s               |
| enable ingress | 32.3s    | 27.6s               |
+----------------+----------+---------------------+

Times for minikube start: 27.4s 26.7s 25.9s 26.7s 25.4s
Times for minikube (PR 15872) start: 26.7s 27.3s 26.8s 26.6s 28.8s

Times for minikube ingress: 21.1s 20.1s 50.6s 49.6s 20.1s
Times for minikube (PR 15872) ingress: 22.1s 20.1s 50.1s 23.1s 22.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15872) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.3s               |
| enable ingress | 39.0s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.2s 22.3s 21.7s 21.8s
Times for minikube (PR 15872) start: 22.1s 22.0s 22.9s 22.5s 22.1s

Times for minikube ingress: 19.6s 79.6s 31.6s 32.6s 31.6s
Times for minikube (PR 15872) ingress: 32.6s 31.6s 31.6s 31.6s 31.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/parallel/CloudSpanner (gopogh) 0.00 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 5.92 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 5.92 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 7.45 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 7.45 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.76 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh changed the title new flag --skip-audit and skip profile command from audit by default new flag --skip-audit and skip profile cmd from audit by default Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 7d2c71b into kubernetes:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants