Add default cni logs to `minikbue logs` #15909

medyagh · 2023-02-22T21:32:46Z

After this PR

minikube logs will have a new block and when there is no kindnet it will just skip it

* ==> kindnet [fd5dc3e193c4] <==
* I0222 21:43:26.005057       1 main.go:102] connected to apiserver: https://10.96.0.1:443
I0222 21:43:26.005078       1 main.go:107] hostIP = 192.168.49.2
podIP = 192.168.49.2
I0222 21:43:26.005167       1 main.go:116] setting mtu 1500 for CNI 
I0222 21:43:26.005175       1 main.go:146] kindnetd IP family: "ipv4"
I0222 21:43:26.005181       1 main.go:150] noMask IPv4 subnets: [10.244.0.0/16]
I0222 21:43:26.304772       1 main.go:223] Handling node with IPs: map[192.168.49.2:{}]
I0222 21:43:26.304794       1 main.go:227] handling current node
I0222 21:43:26.397420       1 main.go:223] Handling node with IPs: map[192.168.49.3:{}]
I0222 21:43:26.397447       1 main.go:250] Node minikube-m02 has CIDR [10.244.1.0/24] 
I0222 21:43:26.397535       1 routes.go:62] Adding route {Ifindex: 0 Dst: 10.244.1.0/24 Src: <nil> Gw: 192.168.49.3 Flags: [] Table: 0} 
I0222 21:43:36.409082       1 main.go:223] Handling node with IPs: map[192.168.49.2:{}]
I0222 21:43:36.409152       1 main.go:227] handling current node
I0222 21:43:36.409175       1 main.go:223] Handling node with IPs: map[192.168.49.3:{}]
I0222 21:43:36.409186       1 main.go:250] Node minikube-m02 has CIDR [10.244.1.0/24] 

* 
* ==> storage-provisioner [490b4598d868] <==
* I0222 21:37:04.892201       1 storage_provisioner.go:116] Initializing the minikube storage provisioner...
I0222 21:37:04.896794       1 storage_provisioner.go:141] Storage provisioner initialized, now starting service!
I0222 21:37:04.896867       1 leaderelection.go:243] attempting to acquire leader lease kube-system/k8s.io-minikube-hostpath...
I0222 21:37:04.899874       1 leaderelection.go:253] successfully acquired lease kube-system/k8s.io-minikube-hostpath
I0222 21:37:04.899973       1 controller.go:835] Starting provisioner controller k8s.io/minikube-hostpath_minikube_4ea15022-c157-4183-9eeb-43eb847f4c7c!
I0222 21:37:04.899960       1 event.go:282] Event(v1.ObjectReference{Kind:"Endpoints", Namespace:"kube-system", Name:"k8s.io-minikube-hostpath", UID:"97606d00-670a-4117-b7be-404881625386", APIVersion:"v1", ResourceVersion:"375", FieldPath:""}): type: 'Normal' reason: 'LeaderElection' minikube_4ea15022-c157-4183-9eeb-43eb847f4c7c became leader
I0222 21:37:05.000381       1 controller.go:884] Started provisioner controller k8s.io/minikube-hostpath_minikube_4ea15022-c157-4183-9eeb-43eb847f4c7c!

* 
* ==> storage-provisioner [bc0733949d40] <==
* I0222 21:36:59.740537       1 storage_provisioner.go:116] Initializing the minikube storage provisioner...
F0222 21:37:04.750033       1 main.go:39] error getting server version: Get "https://10.96.0.1:443/version?timeout=32s": dial tcp 10.96.0.1:443: connect: connection refused

add more verbose failure for DeployApp2Nodes
test log when it hostip is nil

to help with Mirantis/cri-dockerd#163

medyagh · 2023-02-22T21:33:30Z

/ok-to-test

medyagh · 2023-02-22T21:50:18Z

/ok-to-test

pkg/minikube/logs/logs.go

medyagh · 2023-02-23T03:57:42Z

/retest-this-please

minikube-pr-bot · 2023-02-23T04:57:56Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 54.1s    | 54.8s               |
| enable ingress | 26.1s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.1s 28.7s 24.2s 28.2s 23.2s
Times for minikube (PR 15909) ingress: 28.2s 27.7s 24.7s 24.2s 29.2s

Times for minikube (PR 15909) start: 54.8s 52.8s 55.5s 54.5s 56.3s
Times for minikube start: 54.2s 54.1s 54.5s 56.0s 51.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 26.7s    | 25.9s               |
| enable ingress | 33.3s    | 20.9s               |
+----------------+----------+---------------------+

Times for minikube start: 26.0s 26.4s 26.9s 26.8s 27.2s
Times for minikube (PR 15909) start: 26.1s 26.9s 25.1s 26.0s 25.5s

Times for minikube ingress: 19.5s 22.0s 82.6s 20.1s 22.1s
Times for minikube (PR 15909) ingress: 21.1s 19.1s 23.0s 21.0s 20.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.6s               |
| enable ingress | 26.9s    | 30.1s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 21.9s 20.7s 21.2s 20.6s
Times for minikube (PR 15909) start: 21.2s 20.9s 22.2s 21.9s 22.0s

Times for minikube ingress: 31.5s 19.6s 32.5s 19.5s 31.6s
Times for minikube (PR 15909) ingress: 32.6s 33.1s 20.6s 31.6s 32.6s

minikube-pr-bot · 2023-02-23T05:51:51Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/custom-flannel/Start (gopogh)	0.67 (chart)
Hyperkit_macOS	TestMultiNode/serial/RestartKeepsNodes (gopogh)	1.33 (chart)
KVM_Linux	TestPause/serial/SecondStartNoReconfiguration (gopogh)	6.79 (chart)
Docker_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	50.30 (chart)
Docker_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	50.30 (chart)
Docker_macOS	TestMultiNode/serial/DeployApp2Nodes (gopogh)	51.28 (chart)
Docker_macOS	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	51.28 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	71.88 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	84.38 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	96.88 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	96.88 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	99.36 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
KVM_Linux_containerd	TestPreload (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

minikube-pr-bot · 2023-02-23T21:07:13Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 52.9s    | 51.9s               |
| enable ingress | 25.0s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 15909) start: 54.7s 50.1s 50.1s 54.2s 50.4s
Times for minikube start: 53.6s 52.6s 50.6s 52.9s 54.6s

Times for minikube ingress: 25.2s 23.7s 24.2s 23.6s 28.2s
Times for minikube (PR 15909) ingress: 25.2s 24.2s 28.7s 28.2s 28.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15909) |
+-------------------+----------+---------------------+
| minikube start    | 26.4s    | 26.9s               |
| ⚠️  enable ingress | 21.5s    | 33.6s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 23.0s 23.0s 20.0s 22.0s 19.6s
Times for minikube (PR 15909) ingress: 21.0s 21.0s 23.1s 81.6s 21.0s

Times for minikube start: 25.6s 25.1s 27.6s 27.2s 26.3s
Times for minikube (PR 15909) start: 26.8s 27.3s 27.0s 26.4s 27.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.4s               |
| enable ingress | 30.1s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 22.8s 21.4s 22.0s 21.6s
Times for minikube (PR 15909) start: 21.3s 22.2s 21.4s 21.5s 20.5s

Times for minikube ingress: 32.0s 31.5s 21.6s 32.5s 32.6s
Times for minikube (PR 15909) ingress: 19.5s 31.5s 31.6s 32.5s 32.6s

test/integration/multinode_test.go

minikube-pr-bot · 2023-02-23T22:01:19Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_macOS	TestNoKubernetes/serial/Start (gopogh)	3.75 (chart)
Docker_macOS	TestNoKubernetes/serial/StartNoArgs (gopogh)	3.75 (chart)
Docker_macOS	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	3.75 (chart)
Docker_macOS	TestNoKubernetes/serial/Stop (gopogh)	3.75 (chart)
Docker_macOS	TestNetworkPlugins/group/auto/Start (gopogh)	3.77 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	3.77 (chart)
Docker_macOS	TestNetworkPlugins/group/custom-flannel/Start (gopogh)	3.77 (chart)
Docker_macOS	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	3.77 (chart)
Docker_macOS	TestNetworkPlugins/group/false/Start (gopogh)	3.77 (chart)
Docker_macOS	TestNetworkPlugins/group/kubenet/Start (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/DeployApp (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/EnableAddonAfterStop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/EnableAddonWhileActive (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/Stop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/AddonExistsAfterStop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/DeployApp (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/EnableAddonAfterStop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/EnableAddonWhileActive (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/FirstStart (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Pause (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/SecondStart (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/Stop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/UserAppExistsAfterStop (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/embed-certs/serial/VerifyKubernetesImages (gopogh)	3.77 (chart)
Docker_macOS	TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh)	3.77 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2023-02-23T22:40:23Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 55.5s    | 55.5s               |
| enable ingress | 27.8s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.3s 25.8s 28.8s 27.9s 29.3s
Times for minikube (PR 15909) ingress: 28.9s 28.3s 28.3s 24.8s 29.4s

Times for minikube start: 55.3s 57.8s 53.9s 55.2s 55.1s
Times for minikube (PR 15909) start: 56.1s 57.0s 54.4s 55.7s 54.5s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15909) |
+-------------------+----------+---------------------+
| minikube start    | 27.6s    | 27.6s               |
| ⚠️  enable ingress | 27.5s    | 33.9s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 28.1s 27.5s 27.9s 27.4s 27.4s
Times for minikube (PR 15909) start: 27.5s 26.8s 27.5s 28.1s 27.9s

Times for minikube ingress: 21.2s 20.1s 21.6s 23.1s 51.7s
Times for minikube (PR 15909) ingress: 22.1s 21.1s 22.1s 22.1s 82.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 22.6s               |
| enable ingress | 39.2s    | 39.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 23.7s 23.1s 23.2s 22.3s
Times for minikube (PR 15909) start: 22.2s 21.9s 22.9s 23.1s 22.9s

Times for minikube ingress: 32.6s 19.6s 79.7s 32.6s 31.6s
Times for minikube (PR 15909) ingress: 79.6s 19.7s 32.6s 32.6s 32.6s

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

minikube-pr-bot · 2023-02-24T01:19:12Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 53.8s    | 52.9s               |
| enable ingress | 27.0s    | 26.1s               |
+----------------+----------+---------------------+

Times for minikube start: 56.8s 54.3s 53.2s 50.1s 54.6s
Times for minikube (PR 15909) start: 54.5s 51.3s 55.3s 53.6s 49.7s

Times for minikube ingress: 29.2s 25.7s 24.6s 27.2s 28.2s
Times for minikube (PR 15909) ingress: 28.2s 24.2s 25.2s 27.7s 25.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15909) |
+-------------------+----------+---------------------+
| minikube start    | 26.6s    | 26.4s               |
| ⚠️  enable ingress | 21.1s    | 32.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 27.1s 26.3s 26.9s 27.0s 25.6s
Times for minikube (PR 15909) start: 26.3s 26.7s 25.7s 27.0s 26.3s

Times for minikube ingress: 20.6s 21.5s 21.1s 22.1s 20.0s
Times for minikube (PR 15909) ingress: 23.1s 49.6s 21.1s 49.5s 20.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.6s               |
| enable ingress | 45.2s    | 45.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.1s 22.4s 21.7s 22.4s 21.2s
Times for minikube (PR 15909) start: 21.1s 22.7s 21.8s 21.4s 21.0s

Times for minikube ingress: 32.5s 47.5s 33.1s 32.6s 80.0s
Times for minikube (PR 15909) ingress: 31.6s 48.0s 31.6s 81.1s 32.6s

minikube-pr-bot · 2023-02-24T01:58:41Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/Setup (gopogh)	0.00 (chart)
Hyperkit_macOS	TestFunctional/serial/CacheCmd/cache/add_local (gopogh)	0.00 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh)	0.66 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	1.32 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	1.32 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	1.32 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	1.32 (chart)
Hyperkit_macOS	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	1.32 (chart)
KVM_Linux	TestMultiNode/serial/DeleteNode (gopogh)	1.86 (chart)
KVM_Linux	TestMultiNode/serial/RestartKeepsNodes (gopogh)	2.48 (chart)
KVM_Linux_containerd	TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh)	7.41 (chart)
KVM_Linux_containerd	TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh)	7.41 (chart)
Docker_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	57.41 (chart)
Docker_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	57.41 (chart)
Docker_macOS	TestMultiNode/serial/DeployApp2Nodes (gopogh)	57.69 (chart)
Docker_macOS	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	57.69 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	76.92 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	87.18 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	97.44 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	97.44 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	99.36 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2023-02-24T02:10:26Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/Pause (gopogh)	1.32 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/SecondStart (gopogh)	1.32 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh)	1.32 (chart)
KVM_Linux	TestPause/serial/SecondStartNoReconfiguration (gopogh)	6.88 (chart)
KVM_Linux	TestMultiNode/serial/StartAfterStop (gopogh)	13.04 (chart)
Docker_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	57.41 (chart)
Docker_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	57.41 (chart)
Docker_macOS	TestMultiNode/serial/DeployApp2Nodes (gopogh)	57.69 (chart)
Docker_macOS	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	57.69 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	76.92 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	87.18 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	97.44 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	97.44 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	99.36 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

test/integration/multinode_test.go

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

k8s-ci-robot · 2023-02-24T21:43:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2023-02-24T23:05:27Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 55.0s    | 53.6s               |
| enable ingress | 28.0s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube start: 54.2s 59.3s 53.8s 54.0s 53.9s
Times for minikube (PR 15909) start: 50.8s 49.8s 56.1s 56.7s 54.5s

Times for minikube ingress: 25.7s 27.3s 28.7s 28.8s 29.7s
Times for minikube (PR 15909) ingress: 28.3s 25.8s 30.7s 28.3s 25.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 27.3s    | 27.5s               |
| enable ingress | 22.1s    | 21.8s               |
+----------------+----------+---------------------+

Times for minikube start: 28.1s 26.2s 26.6s 28.4s 27.3s
Times for minikube (PR 15909) start: 27.0s 28.1s 27.6s 27.9s 26.7s

Times for minikube ingress: 22.1s 22.2s 22.1s 21.6s 22.6s
Times for minikube (PR 15909) ingress: 23.1s 20.1s 20.2s 23.6s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15909) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.9s               |
| enable ingress | 31.6s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 15909) ingress: 31.6s 32.6s 31.6s 32.6s 32.1s
Times for minikube ingress: 32.6s 27.7s 32.6s 33.6s 31.6s

Times for minikube (PR 15909) start: 22.2s 23.9s 23.1s 23.2s 22.3s
Times for minikube start: 22.3s 23.3s 22.2s 22.4s 22.8s

minikube-pr-bot · 2023-02-25T00:58:04Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	64.60 (chart)
Docker_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	64.60 (chart)
Docker_macOS	TestMultiNode/serial/DeployApp2Nodes (gopogh)	65.16 (chart)
Docker_macOS	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	65.16 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	99.35 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
KVM_Linux_containerd	TestPreload (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

medyagh added 2 commits February 22, 2023 13:26

add more verbose failure for DeployApp2Nodes

57a8bb7

test log when it hostip is nil

ae91a3e

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2023

k8s-ci-robot requested review from sharifelgamal and spowelljr February 22, 2023 21:32

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2023

medyagh changed the title ~~multinodetestverbose~~ Add more logs for TestMultiNode/DeployApp2Nodes Feb 22, 2023

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 22, 2023

medyagh changed the title ~~Add more logs for TestMultiNode/DeployApp2Nodes~~ Add kindnet logs to minikbue logs Feb 22, 2023

add storage provisioner to minikube logs

e35e2c7

medyagh changed the title ~~Add kindnet logs to minikbue logs~~ Add default storage and cni logs to minikbue logs Feb 22, 2023

spowelljr requested changes Feb 22, 2023

View reviewed changes

pkg/minikube/logs/logs.go Outdated Show resolved Hide resolved

Update pkg/minikube/logs/logs.go

e9ad3cc

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

add more

468919b

medyagh changed the title ~~Add default storage and cni logs to minikbue logs~~ Add default cni logs to minikbue logs Feb 23, 2023

spowelljr requested changes Feb 23, 2023

View reviewed changes

test/integration/multinode_test.go Outdated Show resolved Hide resolved

Update test/integration/multinode_test.go

c3ced9e

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

spowelljr requested changes Feb 24, 2023

View reviewed changes

test/integration/multinode_test.go Outdated Show resolved Hide resolved

test/integration/multinode_test.go Outdated Show resolved Hide resolved

medyagh and others added 2 commits February 24, 2023 13:30

Update test/integration/multinode_test.go

0cd84d8

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

Update test/integration/multinode_test.go

7e38a61

Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>

spowelljr approved these changes Feb 24, 2023

View reviewed changes

medyagh merged commit 91cf318 into kubernetes:master Feb 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add default cni logs to `minikbue logs` #15909

Add default cni logs to `minikbue logs` #15909

medyagh commented Feb 22, 2023 •

edited

medyagh commented Feb 22, 2023

medyagh commented Feb 22, 2023

medyagh commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 24, 2023

minikube-pr-bot commented Feb 24, 2023

minikube-pr-bot commented Feb 24, 2023

k8s-ci-robot commented Feb 24, 2023

minikube-pr-bot commented Feb 24, 2023

minikube-pr-bot commented Feb 25, 2023

Add default cni logs to minikbue logs #15909

Add default cni logs to minikbue logs #15909

Conversation

medyagh commented Feb 22, 2023 • edited

After this PR

medyagh commented Feb 22, 2023

medyagh commented Feb 22, 2023

medyagh commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 23, 2023

minikube-pr-bot commented Feb 24, 2023

minikube-pr-bot commented Feb 24, 2023

minikube-pr-bot commented Feb 24, 2023

k8s-ci-robot commented Feb 24, 2023

minikube-pr-bot commented Feb 24, 2023

minikube-pr-bot commented Feb 25, 2023

Add default cni logs to `minikbue logs` #15909

Add default cni logs to `minikbue logs` #15909

medyagh commented Feb 22, 2023 •

edited