Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO/Kicbase: Update containerd from 1.6.15 to 1.6.18 #15923

Merged
merged 3 commits into from Mar 3, 2023
Merged

ISO/Kicbase: Update containerd from 1.6.15 to 1.6.18 #15923

merged 3 commits into from Mar 3, 2023

Conversation

spowelljr
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2023
@spowelljr
Copy link
Member Author

ok-to-build-iso

@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr spowelljr changed the title ISO: Update containerd from 1.6.15 to 1.6.18 ISO/Kicbase: Update containerd from 1.6.15 to 1.6.18 Feb 24, 2023
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@medyagh
Copy link
Member

medyagh commented Feb 24, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 24, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 55.1s    | 55.1s               |
| enable ingress | 28.1s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 15923) start: 53.0s 57.7s 53.8s 55.5s 55.6s
Times for minikube start: 56.2s 52.9s 57.4s 54.8s 54.3s

Times for minikube ingress: 27.7s 25.8s 28.2s 30.1s 28.7s
Times for minikube (PR 15923) ingress: 28.2s 29.7s 24.7s 28.2s 28.2s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15923) |
+-------------------+----------+---------------------+
| minikube start    | 27.1s    | 27.1s               |
| ⚠️  enable ingress | 21.1s    | 45.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 26.2s 27.5s 27.3s 27.5s 27.2s
Times for minikube (PR 15923) start: 26.9s 28.3s 27.7s 27.0s 25.6s

Times for minikube ingress: 22.1s 22.1s 20.1s 21.1s 20.1s
Times for minikube (PR 15923) ingress: 21.1s 19.1s 21.1s 82.6s 82.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.7s               |
| enable ingress | 49.2s    | 44.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 22.6s 21.9s 22.2s 22.8s
Times for minikube (PR 15923) start: 22.0s 22.2s 21.6s 21.5s 21.2s

Times for minikube ingress: 80.1s 20.6s 32.6s 81.1s 31.6s
Times for minikube (PR 15923) ingress: 31.5s 30.5s 32.5s 49.6s 80.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestMultiNode/serial/RestartMultiNode (gopogh) 2.33 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 6.98 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 6.98 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 59.88 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 59.88 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 60.24 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 60.24 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 99.40 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 53.3s    | 54.5s               |
| enable ingress | 25.7s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 58.0s 55.0s 49.5s 52.7s 51.3s
Times for minikube (PR 15923) start: 55.0s 55.7s 56.2s 55.1s 50.6s

Times for minikube ingress: 23.8s 28.7s 24.2s 24.2s 27.7s
Times for minikube (PR 15923) ingress: 23.7s 28.7s 25.8s 25.2s 29.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 26.6s    | 26.7s               |
| enable ingress | 27.3s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 15923) start: 27.4s 27.2s 26.1s 26.7s 26.2s
Times for minikube start: 26.4s 26.3s 26.5s 26.5s 27.1s

Times for minikube ingress: 22.1s 21.1s 50.1s 20.1s 23.1s
Times for minikube (PR 15923) ingress: 21.1s 21.1s 20.1s 50.6s 22.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.0s               |
| enable ingress | 49.2s    | 39.8s               |
+----------------+----------+---------------------+

Times for minikube start: 22.8s 21.2s 22.2s 20.9s 22.9s
Times for minikube (PR 15923) start: 21.9s 22.4s 21.8s 22.4s 21.6s

Times for minikube ingress: 21.6s 32.6s 31.6s 80.6s 79.6s
Times for minikube (PR 15923) ingress: 81.6s 21.6s 32.6s 31.6s 31.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestMissingContainerUpgrade (gopogh) 0.00 (chart)
KVM_Linux TestJSONOutput/pause/Command (gopogh) 0.62 (chart)
KVM_Linux TestJSONOutput/start/Command (gopogh) 0.62 (chart)
KVM_Linux TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 0.62 (chart)
KVM_Linux TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 0.62 (chart)
KVM_Linux TestJSONOutput/unpause/Command (gopogh) 0.62 (chart)
Hyperkit_macOS TestSkaffold (gopogh) 0.67 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 6.83 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 6.83 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 64.60 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 64.60 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 65.16 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 65.16 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 97.87 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 99.35 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Mar 1, 2023

weird that the test outputjson is failing more on this PR

@medyagh
Copy link
Member

medyagh commented Mar 1, 2023

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 54.5s    | 55.0s               |
| enable ingress | 26.8s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 15923) ingress: 28.8s 28.3s 29.3s 24.2s 25.3s
Times for minikube ingress: 25.3s 25.3s 29.7s 24.8s 28.7s

Times for minikube start: 54.9s 54.8s 54.4s 53.1s 55.3s
Times for minikube (PR 15923) start: 56.0s 52.9s 55.9s 59.0s 51.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 26.7s    | 26.7s               |
| enable ingress | 21.7s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 27.1s 26.5s 26.8s 25.6s 27.6s
Times for minikube (PR 15923) start: 25.7s 27.2s 27.2s 26.6s 27.1s

Times for minikube ingress: 22.1s 22.1s 21.1s 22.1s 21.1s
Times for minikube (PR 15923) ingress: 21.6s 22.1s 21.6s 21.1s 23.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15923) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 23.2s               |
| enable ingress | 35.2s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 48.6s 30.6s 31.6s 33.6s 31.6s
Times for minikube (PR 15923) ingress: 32.6s 31.6s 32.6s 32.6s 31.6s

Times for minikube start: 22.7s 23.6s 22.4s 23.5s 23.0s
Times for minikube (PR 15923) start: 23.0s 23.6s 24.0s 22.5s 23.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestBinaryMirror (gopogh) 5.77 (chart)
Docker_Windows TestAddons/Setup (gopogh) 21.15 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 21.15 (chart)
Docker_Windows TestDownloadOnly/v1.16.0/preload-exists (gopogh) 21.15 (chart)
Docker_Windows TestDownloadOnly/v1.26.1/preload-exists (gopogh) 21.15 (chart)
Docker_Windows TestErrorSpam/setup (gopogh) 21.15 (chart)
Docker_Windows TestCertExpiration (gopogh) 22.45 (chart)
Docker_Windows TestCertOptions (gopogh) 22.45 (chart)
Docker_Windows TestDockerFlags (gopogh) 22.45 (chart)
Docker_Windows TestForceSystemdEnv (gopogh) 22.45 (chart)
Docker_Windows TestForceSystemdFlag (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/add_remote (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/delete (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh) 3.3 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/list (gopogh) 22.45 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 22.45 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit ddd7763 into kubernetes:master Mar 3, 2023
@spowelljr spowelljr deleted the updateContainerd branch March 6, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spowelljr @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot