Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP-Auth: Add fixes and timeouts #15985

Merged
merged 2 commits into from Mar 13, 2023
Merged

Conversation

spowelljr
Copy link
Member

Fix 1

If you enable GCP-Auth with an older version of minikube and then try to refresh it with a newer version of minikube with different GCP-Auth images it will fail as it's trying to apply a patch using a different image. To fix this on the first kubectl apply don't use --force, but on subsequent attempts use --force, this will resolve the mentioned issue.

Fix 2

refreshExistingPods had an infinite retry with no timeout while waiting for a pod to come back up. Updated so each pod gets 15 seconds to come back up, also added info logging to help with future issues.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 7, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15985) |
+----------------+----------+---------------------+
| minikube start | 53.5s    | 54.7s               |
| enable ingress | 27.5s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube start: 53.6s 54.8s 53.8s 52.1s 53.4s
Times for minikube (PR 15985) start: 52.2s 54.8s 55.8s 56.0s 54.7s

Times for minikube ingress: 28.3s 27.3s 28.3s 28.3s 25.3s
Times for minikube (PR 15985) ingress: 24.8s 24.7s 29.8s 25.7s 29.9s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15985) |
+-------------------+----------+---------------------+
| minikube start    | 26.8s    | 26.9s               |
| ⚠️  enable ingress | 21.0s    | 34.1s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 19.6s 20.1s 22.1s 21.1s 22.1s
Times for minikube (PR 15985) ingress: 23.1s 23.1s 21.1s 20.6s 82.6s

Times for minikube start: 25.8s 28.0s 27.2s 25.9s 27.2s
Times for minikube (PR 15985) start: 27.1s 26.6s 27.9s 26.5s 26.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15985) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 23.1s               |
| enable ingress | 38.0s    | 31.6s               |
+----------------+----------+---------------------+

Times for minikube start: 24.0s 22.1s 22.6s 23.2s 23.6s
Times for minikube (PR 15985) start: 23.6s 23.2s 23.1s 23.0s 22.4s

Times for minikube ingress: 31.6s 47.6s 47.6s 31.6s 31.6s
Times for minikube (PR 15985) ingress: 31.6s 31.6s 31.6s 31.6s 31.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNetworkPlugins/group/flannel/Start (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 0.91 (chart)
Hyperkit_macOS TestRunningBinaryUpgrade (gopogh) 9.09 (chart)
KVM_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 9.64 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 100.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 75851c0 into kubernetes:master Mar 13, 2023
@spowelljr spowelljr deleted the kubectlContext branch March 13, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants