Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI: Update kindnetd from v20230227-15197099 to v20230330-48f316cd #16207

Merged
merged 2 commits into from Apr 2, 2023

Conversation

spowelljr
Copy link
Member

kindnetd commits:
bump distroless-iptables to latest: kubernetes-sigs/kind@91ac084
bump kindnetd dependencies: kubernetes-sigs/kind@385bf7b

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
@spowelljr spowelljr changed the title CNI: Update kindnetd from v20230227-15197099 to v20230330-48f316cd CNI: Update kindnetd from v20230227-15197099 to v20230330-48f316cd Mar 31, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 31, 2023
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented Apr 1, 2023

/ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16207) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 49.4s               |
| enable ingress | 26.1s    | 25.3s               |
+----------------+----------+---------------------+

Times for minikube start: 51.0s 52.2s 50.4s 48.2s 49.8s
Times for minikube (PR 16207) start: 50.9s 48.3s 46.2s 51.2s 50.3s

Times for minikube ingress: 29.7s 28.2s 23.7s 24.7s 24.2s
Times for minikube (PR 16207) ingress: 25.3s 24.7s 25.7s 25.7s 25.1s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16207) |
+-------------------+----------+---------------------+
| minikube start    | 23.3s    | 23.2s               |
| ⚠️  enable ingress | 20.5s    | 26.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 23.5s 23.6s 23.6s 23.2s 22.4s
Times for minikube (PR 16207) start: 22.7s 23.3s 23.4s 23.3s 23.3s

Times for minikube ingress: 20.0s 20.0s 20.1s 20.0s 22.6s
Times for minikube (PR 16207) ingress: 21.5s 21.1s 20.0s 49.5s 19.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16207) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 21.3s               |
| enable ingress | 31.9s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.5s 21.6s 21.9s 21.3s 21.9s
Times for minikube (PR 16207) start: 21.7s 21.5s 20.8s 20.8s 21.7s

Times for minikube ingress: 31.6s 48.1s 29.6s 31.6s 18.6s
Times for minikube (PR 16207) ingress: 31.0s 31.5s 32.6s 32.0s 32.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestErrorSpam/setup (gopogh) 5.56 (chart)
KVM_Linux TestErrorSpam/setup (gopogh) 6.79 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 12.36 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 14.06 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 19.54 (chart)
Docker_macOS TestSkaffold (gopogh) 81.82 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 91.01 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 98.08 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)
none_Linux TestAddons/Setup (gopogh) 100.00 (chart)
none_Linux TestFunctional/parallel/DashboardCmd (gopogh) 100.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmdConnect (gopogh) 100.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 100.00 (chart)
none_Linux TestFunctional/serial/ExtraConfig (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 69a13ab into kubernetes:master Apr 2, 2023
28 of 41 checks passed
@spowelljr spowelljr deleted the updateKindnetd branch April 3, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants