Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONFIG_BINFMT_MISC=y flag #16712

Merged
merged 3 commits into from Jun 21, 2023
Merged

Add CONFIG_BINFMT_MISC=y flag #16712

merged 3 commits into from Jun 21, 2023

Conversation

spowelljr
Copy link
Member

Reopening #16428 due to weird rebase error

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2023
@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 15, 2023
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16712) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 49.7s               |
| enable ingress | 26.3s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 16712) start: 46.7s 51.6s 50.4s 51.8s 48.0s
Times for minikube start: 52.5s 53.0s 52.2s 50.9s 47.4s

Times for minikube ingress: 27.6s 25.6s 27.6s 23.6s 27.1s
Times for minikube (PR 16712) ingress: 27.6s 27.1s 27.6s 27.2s 27.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16712) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 23.2s               |
| enable ingress | 49.3s    | 49.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 49.3s 48.8s 50.3s 49.3s 48.8s
Times for minikube (PR 16712) ingress: 49.3s 49.3s 49.3s 48.3s 49.8s

Times for minikube start: 21.4s 22.0s 23.7s 20.9s 23.6s
Times for minikube (PR 16712) start: 24.9s 23.5s 21.3s 24.7s 21.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16712) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 20.8s               |
| enable ingress | 28.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 23.0s 23.1s 19.6s 19.9s 19.7s
Times for minikube (PR 16712) start: 20.0s 21.2s 20.3s 22.6s 20.0s

Times for minikube ingress: 31.3s 31.3s 31.3s 18.3s 31.3s
Times for minikube (PR 16712) ingress: 32.3s 31.3s 31.3s 31.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestFunctional/serial/LogsFileCmd (gopogh) 3.18 (chart)
KVM_Linux_containerd TestRunningBinaryUpgrade (gopogh) 3.18 (chart)
QEMU_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 9.86 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 9.93 (chart)
QEMU_macOS TestFunctional/parallel/Version/components (gopogh) 9.93 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit da825db into kubernetes:master Jun 21, 2023
30 of 41 checks passed
@spowelljr spowelljr deleted the michelesr/master branch June 21, 2023 17:00
@spowelljr spowelljr mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spowelljr @minikube-bot @minikube-pr-bot @k8s-ci-robot @medyagh @michelesr