Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-limit option for config validation #17530

Merged
merged 1 commit into from Nov 2, 2023

Conversation

spowelljr
Copy link
Member

Before:

$ minikube config set cpus no-limit

❌  Exiting due to MK_CONFIG_SET: Set failed: run validations for "cpus" with value of "no-limit": [cpus:strconv.Atoi: parsing "no-limit": invalid syntax]

╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                         │
│    😿  If the above advice does not help, please let us know:                                                           │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                                                         │
│                                                                                                                         │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.                                  │
│    Please also attach the following file to the GitHub issue:                                                           │
│    - /var/folders/9l/6wpxv6wd1b901m1146r579wc00rqw3/T/minikube_config_f2ac5a775a933d63b384f05046e49d1328797158_0.log    │
│                                                                                                                         │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

After:

$ minikube config set cpus no-limit
❗  These changes will take effect upon a minikube delete and then a minikube start

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@medyagh
Copy link
Member

medyagh commented Oct 31, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17530) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 50.9s               |
| enable ingress | 27.1s    | 27.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 17530) start: 50.4s 52.2s 50.3s 50.3s 51.3s
Times for minikube start: 52.7s 51.6s 50.5s 51.0s 50.0s

Times for minikube ingress: 25.1s 26.7s 28.6s 27.1s 28.2s
Times for minikube (PR 17530) ingress: 27.7s 28.1s 27.5s 24.6s 27.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17530) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 24.0s               |
| enable ingress | 20.8s    | 20.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 21.7s 24.0s 21.7s 22.0s
Times for minikube (PR 17530) start: 23.8s 24.1s 24.9s 24.6s 22.3s

Times for minikube ingress: 21.8s 20.8s 19.8s 20.8s 20.8s
Times for minikube (PR 17530) ingress: 18.8s 18.8s 20.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17530) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.4s               |
| enable ingress | 34.1s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 20.9s 23.6s 20.8s 23.5s
Times for minikube (PR 17530) start: 20.9s 23.6s 23.2s 23.9s 20.6s

Times for minikube ingress: 47.3s 31.3s 30.3s 31.3s 30.3s
Times for minikube (PR 17530) ingress: 19.3s 31.3s 30.3s 31.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
KVM_Linux TestMultiNode/serial/CopyFile (gopogh) 0.00 (chart)
KVM_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
KVM_Linux TestMultiNode/serial/FreshStart2Nodes (gopogh) 0.00 (chart)
KVM_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 0.00 (chart)
KVM_Linux TestMultiNode/serial/StopNode (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/CloudSpanner (gopogh) 1.69 (chart)
KVM_Linux TestMultiNode/serial/StartAfterStop (gopogh) 1.71 (chart)
KVM_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 4.24 (chart)
KVM_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 4.24 (chart)
KVM_Linux_containerd TestFunctional/serial/ComponentHealth (gopogh) 5.08 (chart)
Hyperkit_macOS TestFunctional/parallel/CertSync (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/FileSync (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/NodeLabels (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 7.96 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 7.96 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 483ae12 into kubernetes:master Nov 2, 2023
35 of 50 checks passed
@spowelljr spowelljr deleted the fixNoLimitConfigValidation branch November 2, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants