kvm2 driver: Use scsi cdrom for arm64 to fix Linux on Apple Silicone #18239
Conversation
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
Hi @nirs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch? |
On linux/aarch64 (e.g. Asahi Linux on MacBook M*) booting from SATA cdrom is broken and the VM drops into the UEFI shell. It seems that linux/aarch64 supports only virtio and scsi devices[1]. Replace with scsi cdrom (like the x86 version) and addd a virtio-scsi controller since the default scsi controller does not boot as well. [1] https://kubevirt.io/user-guide/virtual_machines/virtual_machines_on_Arm64/#disks-and-volumes
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
nirs
changed the title
Build and installStarting a cluster |
|
I recall there was a lot of hassle with the CD-rom drivers with the initial arm64 initiative, but if it works OK in qemu2 too... The minikube ISO has been updated since, so it is possible that the new OS works better (like with a new kernel or such?) |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 driver with docker runtime Times for minikube start: 49.4s 52.2s 52.4s 51.3s 54.8s Times for minikube ingress: 26.5s 27.1s 26.7s 26.0s 22.6s docker driver with docker runtime Times for minikube ingress: 21.3s 19.8s 20.3s 20.3s 20.4s Times for minikube start: 26.1s 25.7s 22.1s 22.4s 25.3s docker driver with containerd runtime Times for minikube (PR 18239) start: 21.4s 21.9s 21.9s 23.5s 21.0s Times for minikube ingress: 30.8s 30.8s 30.8s 31.8s 30.9s |
|
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
|
Failing tests look similar to #18241 - change in libvirt domain xml cannot break other drivers. |
medyagh
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, BlaineEXE, medyagh, nirs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On linux/aarch64 (e.g. Asahi Linux on MacBook M*) booting from SATA cdrom is broken and the VM drops into the UEFI shell.
It seems that linux/aarch64 supports only virtio and scsi devices[1]. Replace with scsi cdrom (like the x86 version) and addd a virtio-scsi controller since the default scsi controller does not boot as well.
[1] https://kubevirt.io/user-guide/virtual_machines/virtual_machines_on_Arm64/#disks-and-volumes
Fixes #18238