Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: Add CONFIG_DM_MULTIPATH=y to aarch64 and x86_64 config #18277

Merged
merged 2 commits into from Mar 18, 2024

Conversation

albertofaria
Copy link
Contributor

We happen to need this for [1], where we use minikube for testing.

[1] https://gitlab.com/subprovisioner/subprovisioner

Copy link

linux-foundation-easycla bot commented Mar 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: minikube-bot (3b3cd74)
  • ✅ login: albertofaria / name: Alberto Faria (5fb7240)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @albertofaria!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @albertofaria. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 3, 2024
@albertofaria
Copy link
Contributor Author

Can we get an ok-to-test on this?

@spowelljr
Copy link
Member

Hi @albertofaria, there are two ISO PRs ahead of you I'm working on merging, I should be able to get this merged early next week

We happen to need this for [1], where we use minikube for testing.

[1] https://gitlab.com/subprovisioner/subprovisioner

Signed-off-by: Alberto Faria <afaria@redhat.com>
@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @albertofaria, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18277) |
+----------------+----------+---------------------+
| minikube start | 52.4s    | 52.8s               |
| enable ingress | 24.3s    | 24.3s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 55.2s 50.6s 51.6s 53.7s
Times for minikube (PR 18277) start: 52.5s 52.5s 53.2s 52.0s 53.6s

Times for minikube ingress: 24.0s 25.8s 22.5s 26.0s 23.0s
Times for minikube (PR 18277) ingress: 26.5s 23.1s 26.1s 22.0s 23.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18277) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 23.0s               |
| enable ingress | 19.9s    | 20.3s               |
+----------------+----------+---------------------+

Times for minikube start: 21.8s 22.8s 25.8s 23.0s 22.8s
Times for minikube (PR 18277) start: 22.1s 22.5s 25.1s 22.8s 22.7s

Times for minikube ingress: 19.8s 20.3s 20.3s 19.3s 19.8s
Times for minikube (PR 18277) ingress: 20.3s 20.3s 21.3s 19.3s 20.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 18277) |
+-------------------+----------+---------------------+
| minikube start    | 22.1s    | 23.4s               |
| ⚠️  enable ingress | 31.0s    | 37.1s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 31.3s 30.8s 31.3s 30.8s 30.8s
Times for minikube (PR 18277) ingress: 46.8s 46.3s 29.8s 31.9s 30.8s

Times for minikube (PR 18277) start: 23.9s 24.6s 22.8s 21.4s 24.4s
Times for minikube start: 23.6s 21.8s 20.0s 21.5s 23.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 20.24 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 32.75 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 1100f96 into kubernetes:master Mar 18, 2024
23 of 38 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albertofaria, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants