Addons: Only template .tmpl files

[spowelljr]

Closes #18784

The full explanation for this can be found in #18784, but the short is that we're templating all addon files on load. This hasn't caused an issue until now, but when trying to update the kubeflow addon they added templating that acts as version validation on runtime, but we're templating on load, resulting in:

panic: Failed to define asset kubeflow/kubeflow.yaml: template: kubeflow/kubeflow.yaml:118901: function "Template_Version_And_Istio_Version_Mismatched_Check_Installation" not defined

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset({0x10317f7e0?}, {0x101f2a8ec, 0x16}, {0x101f29d94?, 0x1?}, {0x101f1131e?, 0x14000593928?}, {0x101efea1b?, 0x10?})
	/Users/powellsteven/repo/minikube/pkg/minikube/assets/vm_assets.go:323 +0xb8
k8s.io/minikube/pkg/minikube/assets.init()
	/Users/powellsteven/repo/minikube/pkg/minikube/assets/addons.go:780 +0x687c

Since we strictly add .tmpl to the filename of files that need templating, check for that suffix to decide if the file needs to be templated or not.

[spowelljr]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18785) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 51.8s               |
| enable ingress | 28.5s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 50.8s 53.9s 53.3s 53.4s
Times for minikube (PR 18785) start: 50.2s 52.5s 49.5s 53.6s 53.0s

Times for minikube ingress: 28.0s 28.6s 30.1s 27.6s 28.0s
Times for minikube (PR 18785) ingress: 28.0s 26.0s 29.1s 28.5s 28.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18785) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.5s               |
| enable ingress | 21.9s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 24.6s 20.9s 24.0s 20.8s
Times for minikube (PR 18785) start: 23.8s 21.5s 21.6s 25.0s 20.9s

Times for minikube (PR 18785) ingress: 21.8s 21.8s 21.8s 21.3s 22.8s
Times for minikube ingress: 21.8s 21.8s 21.8s 21.3s 22.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18785) |
+----------------+----------+---------------------+
| minikube start | 22.7s    | 21.1s               |
| enable ingress | 31.6s    | 32.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 20.9s 22.6s 22.1s 24.0s
Times for minikube (PR 18785) start: 20.7s 19.4s 20.1s 22.7s 22.7s

Times for minikube ingress: 31.8s 31.8s 31.3s 31.3s 31.8s
Times for minikube (PR 18785) ingress: 32.3s 32.3s 31.8s 48.3s 19.3s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux_crio	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	0.64 (chart)
Docker_Linux_containerd	TestFunctional/parallel/MountCmd/specific-port (gopogh)	1.91 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh)	2.48 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	2.48 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	2.48 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh)	2.48 (chart)
Docker_Windows	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	3.31 (chart)
Hyper-V_Windows	TestMountStart/serial/StartWithMountFirst (gopogh)	4.27 (chart)
Hyper-V_Windows	TestFunctional/parallel/DockerEnv/powershell (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageListShort (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/MySQL (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/NodeLabels (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ServiceCmdConnect (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ServiceCmd/DeployApp (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ServiceCmd/List (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/StatusCmd (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/serial/InvalidService (gopogh)	11.01 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	12.84 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	12.84 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	12.84 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	12.84 (chart)
Hyper-V_Windows	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	12.84 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment