Add new VMware unified driver to supported list

[frapposelli]

This PR adds the new VMware unified driver to the supported list, the driver now supports Fusion and Workstation across Windows, Linux and macOS.

A deprecation note has been added for the bundled vmwarefusion driver.

Ref: #2118 #2526 machine-drivers/discussion#5 machine-drivers/docker-machine-driver-vmware#1

Fixes: machine-drivers/docker-machine-driver-vmware#1 #2118

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frapposelli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

Assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[frapposelli]

/assign @luxas

[frapposelli]

/cc: @anfernee @SvenDowideit @dlorenc @gbraad @r2d4

[dlorenc]

We shouldn't really add this to an officially supported list until we get automated integration testing for it.

@minikube-bot OK to test

[frapposelli]

@dlorenc we’re working on getting a CI environment to test integration under the driver repo.

[gbraad]

@frapposelli glad to hear about that last part... :-D

[frapposelli]

@dlorenc @gbraad it’s going to take some time to have the environment provisioned, in the meantime, this driver is fixing several issues with our platforms, and extending support to Windows and Linux.

Adding support for this and deprecating the docker-machine builtin one should be a priority in order to have better supportability and timely fixes.

[dlorenc]

@frapposelli I definitely understand that, but I'm going to have to stay firm on this one. The vmware fusion driver shouldn't have been added without CI tests in the first place, and it's much harder to delete something once it's been merged in.

Once we get CI running, we can add this driver.

[gbraad]

I also understand, but have to agree with @dlorenc.

[frapposelli]

Understand, let's leave this open and I'll try to speed up with the CI infra on our side.

[dlorenc]

Any updates on getting this into the test infrastructure?

[frapposelli]

@dlorenc we’re still waiting on the capacity we requested. Shouldn’t take long

[gbraad]

any updates?

[frapposelli]

Yes, we have secured the capacity and we're working on setting up CI, this week there's Kubecon (pretty much our the entire team is here) so I would expect to have something ready by end of next week.

[fenos]

What's the progress on this?

[frapposelli]

Unfortunately the CI work was re-prioritized a few times, we’re now working to have the vSphere capacity added to the tide pool, after that is done we can run tests and merge this.

[fenos]

@frapposelli Thanks for the update!
No worries it happens! I Can't wait for having VMWare fusion working properly on minikube, at the current state it doesn't even start a cluster on it 😭

Keep up the great job 🎉

[smebberson]

Any news on this?

[frapposelli]

Sorry guys, this is taking a little longer than expected.

/cc @akutz FYI

[k8s-ci-robot]

@frapposelli: GitHub didn't allow me to request PR reviews from the following users: FYI.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Sorry guys, this is taking a little longer than expected.

/cc @akutz FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[briandealwis]

Also need to update pkg/minikube/constants/constants.go to add vmware to SupportedVMDrivers.

The changes to the vendor should be backed out.

[RA489]

@frapposelli This PR needs rebase.

[tstromberg]

Do you mind addressing the merge conflicts? I'd like to see about merging this if it's still viable. My apologies for the unnecessarily long delay in reviewing this PR.

[frapposelli]

@tstromberg thanks, let me look into it

[frapposelli]

@tstromberg the original fork was deleted, created #3534 as a follow up from this PR, which I'm closing