Add a Makefile to replace build.sh and test.sh. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ethernetdan Could you take a look here when you get a chance? |
| BUILD_DIR ?= ./out | ||
| GOPATH := $(shell pwd)/.gopath | ||
| REPOPATH ?= k8s.io/minikube | ||
|
|
There was a problem hiding this comment.
Thanks! I've been using Go 1.6 for everything so I forget to set that.
|
|
||
| .PHONY: localkube-$(GOOS)-$(GOARCH) | ||
| localkube-$(GOOS)-$(GOARCH): gopath | ||
| GOARCH=$(GOARCH) GOOS=$(GOOS) $(GO) build -o $(BUILD_DIR)/localkube-$(GOOS)-$(GOARCH) -i --ldflags '-extldflags "-static" --s -w' ./cmd/localkube |
There was a problem hiding this comment.
I think localkube should be dynamically built, since we want and need cAdvisor.
Clean up PHONY's Make localkube dynamic Put test.sh script back
|
PTAL @luxas, cleaned it up a bit. Thanks for the detailed review! |
| GOPATH=$(GOPATH) CGO_ENABLED=0 GOARCH=$(GOARCH) GOOS=$(GOOS) go build --installsuffix cgo -a -o $(BUILD_DIR)/minikube-$(GOOS)-$(GOARCH) ./cmd/minikube | ||
|
|
||
| localkube-$(GOOS)-$(GOARCH): gopath | ||
| GOARCH=$(GOARCH) GOOS=$(GOOS) CGO_ENABLED=1 go build -o $(BUILD_DIR)/localkube-$(GOOS)-$(GOARCH) -i ./cmd/localkube |
There was a problem hiding this comment.
Do we want to support platforms other than Linux for localkube?
There was a problem hiding this comment.
Probably not, but it is really nice to be able to run "make localkube" on my mac just to be sure everything compiles :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates some make actions to build and test:
make minikube
make localkube
make minikube-linux-amd64, etc.
make localkube-linux-amd64, etc.
make test
make integration