Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add a build command, for building container images #4869

Closed
wants to merge 1 commit into from

Conversation

afbjorklund
Copy link
Collaborator

From #4868

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@medyagh
Copy link
Member

medyagh commented Jul 26, 2019

This is reall cool ! I assume the built image will be available inside minikube. Is there any way they could push that image to outside minikube too ?

Could you provide couple example real world use cases that you have in your mind ?

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Jul 27, 2019

This is reall cool ! I assume the built image will be available inside minikube. Is there any way they could push that image to outside minikube too ?

Sure, but unfortunately crictl only knows "pull" - it doesn't know "tag" or "push".
So just like with the missing "load" command, one would have to talk to the engine.

That is: after building the image, you would use either docker or podman to upload.
Of course, you would also have to sort out the credentials so probably need "login".

Could you provide couple example real world use cases that you have in your mind ?

I prefer to discuss the implementation here, but can do some more examples in #4868

The basic use case is just being able to convert a Dockerfile into a container image.

@afbjorklund
Copy link
Collaborator Author

I'm going to close this one as a PoC, until we some more buy-in on the concept (#4868)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants