Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable istio provisioner by default #6315

Merged
merged 1 commit into from Jan 14, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jan 14, 2020

replaces this #6272

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #6315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6315   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files         123      123           
  Lines        8269     8269           
=======================================
  Hits         3162     3162           
  Misses       4696     4696           
  Partials      411      411
Impacted Files Coverage Δ
pkg/minikube/assets/addons.go 37.93% <ø> (ø) ⬆️

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 125.206221 123.431655 113.351792]
All Times Minikube (PR 6315): [ 124.154944 122.623291 124.311129]

Average minikube: 120.663223
Average Minikube (PR 6315): 123.696455

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6315) |
+----------------------+-----------+--------------------+
| minikube v           |  0.228835 |           0.223332 |
| Creating kvm2        | 46.509110 |          46.324093 |
| Preparing Kubernetes | 48.018393 |          51.626834 |
| Pulling images       |  2.965834 |           2.923849 |
| Launching Kubernetes | 20.150965 |          19.986949 |
| Waiting for cluster  |  2.738554 |           2.559944 |
| Done                 |           |                    |
|                      |  0.051108 |           0.051453 |
+----------------------+-----------+--------------------+

@sharifelgamal sharifelgamal merged commit 70f73e7 into kubernetes:master Jan 14, 2020
@medyagh medyagh deleted the istio_disable branch May 2, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants