Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumpup helm-tiller v2.16.1 → v2.16.3 #7130

Merged
merged 1 commit into from Mar 21, 2020
Merged

bumpup helm-tiller v2.16.1 → v2.16.3 #7130

merged 1 commit into from Mar 21, 2020

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Mar 21, 2020

What type of PR is this?

/area addons

What this PR does / why we need it:

This PR bump up helm-tiller addon's image v2.16.1 to v2.16.3

And I added integration test for helm-tiller to gurantee our change stability.

Which issue(s) this PR fixes:

Fixes #7129

Does this PR introduce a user-facing change?

Yes.
This image bumpup includes security patch for CVE-2019-1551.
https://github.com/helm/helm/releases/tag/v2.16.3

Before

image: gcr.io/kubernetes-helm/tiller:v2.16.1

After

image: gcr.io/kubernetes-helm/tiller:v2.16.3

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2020
@govargo govargo changed the title bumpup helm-tiller v2.16.1 → v2.16.3 and add integration test for tiller bumpup helm-tiller v2.16.1 → v2.16.3 Mar 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/addons labels Mar 21, 2020
@govargo
Copy link
Contributor Author

govargo commented Mar 21, 2020

/assign @medyagh

@afbjorklund afbjorklund added kind/security security issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 21, 2020
@afbjorklund afbjorklund linked an issue Mar 21, 2020 that may be closed by this pull request
@afbjorklund afbjorklund removed area/addons kind/security security issues priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 21, 2020
@afbjorklund
Copy link
Collaborator

The PR should link the issue, rather than setting tags on itself...

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/addons labels Mar 21, 2020
@govargo
Copy link
Contributor Author

govargo commented Mar 21, 2020

@afbjorklund
I'm sorry. I mistook the link target.
Thanks for your point out.

@govargo
Copy link
Contributor Author

govargo commented Mar 21, 2020

/remove-kind cleanup

@k8s-ci-robot k8s-ci-robot removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #7130 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7130   +/-   ##
=======================================
  Coverage   36.96%   36.96%           
=======================================
  Files         145      145           
  Lines        9165     9165           
=======================================
  Hits         3388     3388           
  Misses       5359     5359           
  Partials      418      418           

@tstromberg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 21, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@tstromberg tstromberg merged commit 0c7bdda into kubernetes:master Mar 21, 2020
@govargo govargo deleted the feature/helm-tiller-2.16.3 branch February 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BumpUp]: helm-tiller patch update v2.16.1 → v2.16.3
8 participants