Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add delete-on-failure flag #7345

Merged
merged 5 commits into from Apr 2, 2020
Merged

add delete-on-failure flag #7345

merged 5 commits into from Apr 2, 2020

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Mar 31, 2020 •
edited

Fixes #7233

Example:

out/minikube start
πŸ˜„  minikube v1.9.0 on Darwin 10.14.6
✨  Automatically selected the hyperkit driver

πŸ’£  startup failed: OH NO RANDOM FAILURE

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
πŸ‘‰  https://github.com/kubernetes/minikube/issues/new/choose

out/minikube start --delete-on-failure
πŸ˜„  minikube v1.9.0 on Darwin 10.14.6
✨  Automatically selected the hyperkit driver
❗  Node m01 failed to start, deleting and trying again.
πŸ™„  "minikube" profile does not exist, trying anyways.
πŸ’€  Removed all traces of the "minikube" cluster.
πŸ‘  Starting control plane node m01 in cluster minikube
πŸ”₯  Creating hyperkit VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.8 ...
🌟  Enabling addons: default-storageclass, storage-provisioner
πŸ„  Done! kubectl is now configured to use "minikube"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@medyagh
Copy link
Member

medyagh commented Mar 31, 2020

lint

medyagh
medyagh reviewed Mar 31, 2020
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
tstromberg
tstromberg suggested changes Mar 31, 2020
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 31, 2020 •
edited

Codecov Report

Merging #7345 into master will decrease coverage by 0.11%.
The diff coverage is 10.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7345      +/-   ##
==========================================
- Coverage   37.30%   37.18%   -0.12%     
==========================================
  Files         145      145              
  Lines        8804     8836      +32     
==========================================
+ Hits         3284     3286       +2     
- Misses       5123     5154      +31     
+ Partials      397      396       -1
Impacted Files Coverage Ξ”
cmd/minikube/cmd/start.go 34.60% <4.34%> (-1.05%) ⬇️
cmd/minikube/cmd/node_start.go 22.22% <25.00%> (+2.22%) ⬆️
cmd/minikube/cmd/node_add.go 25.00% <50.00%> (+3.26%) ⬆️
pkg/minikube/machine/cache_images.go 0.00% <0.00%> (ΓΈ)

@medyagh
Copy link
Member

medyagh commented Apr 1, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 1, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

All Times minikube: [ 55.993152 62.804856 64.859966]
All Times Minikube (PR 7345): [ 64.655849 65.396171 63.919338]

Average Minikube (PR 7345): 64.657119
Average minikube: 61.219325

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7345) |
+----------------------+-----------+--------------------+
| minikube v           |  0.215161 |           0.228505 |
| Creating kvm2        | 38.998201 |          40.442833 |
| Preparing Kubernetes | 20.406044 |          22.132102 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

All Times minikube: [ 64.559848 62.449330 64.900307]
All Times Minikube (PR 7345): [ 61.840194 63.896953 63.183457]

Average minikube: 63.969828
Average Minikube (PR 7345): 62.973535

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7345) |
+----------------------+-----------+--------------------+
| minikube v           |  0.211389 |           0.207044 |
| Creating kvm2        | 40.107109 |          40.608858 |
| Preparing Kubernetes | 22.085055 |          20.533257 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

medyagh
medyagh approved these changes Apr 2, 2020
View reviewed changes
cmd/minikube/cmd/node_add.go Outdated
}

out.T(out.Ready, "Successfully added {{.name}} to {{.cluster}}!", out.V{"name": name, "cluster": cc.Name})
},
}

func init() {
//We should figure out which minikube start flags to actually import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont add comments without issue link, if something worth doing needs an issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@minikube-pr-bot
Copy link

All Times minikube: [ 61.378756 62.152547 64.030721]
All Times Minikube (PR 7345): [ 65.235826 65.326047 66.191776]

Average minikube: 62.520674
Average Minikube (PR 7345): 65.584550

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7345) |
+----------------------+-----------+--------------------+
| minikube v           |  0.210780 |           0.205636 |
| Creating kvm2        | 40.370355 |          42.123098 |
| Preparing Kubernetes | 20.446419 |          21.688204 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@sharifelgamal sharifelgamal merged commit 5806bb0 into kubernetes:master Apr 2, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
@loftkun loftkun mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh medyagh approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start: Add flag to signify that it's OK to delete broken clusters
6 participants
@sharifelgamal @k8s-ci-robot @medyagh @codecov-io @minikube-pr-bot @tstromberg