Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new wait component apps_running #7460

Merged
merged 5 commits into from Apr 7, 2020
Merged

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 6, 2020

closes #7431

wait=true or wait=all will wait for a new component called "apps_running"
this should reduce test start stop fails, by waiting for more components

the new wait components is called apps_running

$ ./out/minikube start --help | grep wait
      --wait=[apiserver,system_pods]: comma separated list of kubernetes components to verify and wait for after starting a cluster. defaults to "apiserver,system_pods", available options: "apiserver,system_pods,default_sa,apps_running" . other acceptable values are 'all' or 'none', 'true' and 'false'

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 6, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member Author

medyagh commented Apr 6, 2020

/ok-to-test

@codecov-io
Copy link

Codecov Report

Merging #7460 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7460   +/-   ##
=======================================
  Coverage   37.07%   37.07%           
=======================================
  Files         146      146           
  Lines        8871     8871           
=======================================
  Hits         3289     3289           
  Misses       5193     5193           
  Partials      389      389           

@minikube-pr-bot
Copy link

All Times Minikube (PR 7460): [ 65.191856 64.364387 65.393601]
All Times minikube: [ 64.379108 66.166299 62.241991]

Average minikube: 64.262466
Average Minikube (PR 7460): 64.983281

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7460) |
+----------------------+-----------+--------------------+
| minikube v           |  0.239983 |           0.235110 |
| Creating kvm2        | 40.728139 |          41.186969 |
| Preparing Kubernetes | 20.830738 |          21.701030 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member Author

medyagh commented Apr 7, 2020

This PR reveals that our NewestCNI is broken. created an issue for it #7466

@medyagh medyagh merged commit a577ed0 into kubernetes:master Apr 7, 2020
@medyagh medyagh deleted the wait-coredns branch May 2, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CoreDNS to wait components
5 participants