Increase retries for persistence test, add logging #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
approved these changes
Oct 25, 2016
Current coverage is 31.29% (diff: 100%)@@ master #753 diff @@
==========================================
Files 43 43
Lines 1975 1975
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 618 618
Misses 1228 1228
Partials 129 129
|
r2d4
force-pushed
the
persistence-test
branch
from
26434f4
to
05ea00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped up the retries for persistence test, because I think we might need to wait a little longer once we start adding kube-dns as a cluster addon (#738)
(flake here https://storage.googleapis.com/minikube-builds/logs/738/OSX-Virtualbox.txt)
Additionally, I changed the logging messages to the test context instead of libmachine/logs for the pod ready helper function