Reduce coredns replicas from 2 to 1 #8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an easy way to improve overhead, and users can always scale this back up if they need to.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
medyagh
reviewed
Jun 25, 2020
… import dependencies
k8s-ci-robot
added
size/M
|
kvm2 Driver Times for Minikube (PR 8552): [67.682349452 62.92510660999999 64.340755203] Averages Time Per Log docker Driver Times for Minikube (PR 8552): [26.444226114 27.913836233 24.902068095999997] Averages Time Per Log |
tstromberg
reviewed
Jun 25, 2020
pkg/minikube/node/start.go
Outdated
| kubectl := kapi.KubectlBinaryPath(cc.KubernetesConfig.KubernetesVersion) | ||
| cmd := exec.Command("sudo", "KUBECONFIG=/var/lib/minikube/kubeconfig", kubectl, "scale", "deployment", "--replicas=1", "coredns", "-n=kube-system") | ||
| if _, err := runner.RunCmd(cmd); err != nil { | ||
| glog.Infof("unable to scale coredns replicas to 1: %v", err) |
There was a problem hiding this comment.
This should be warningf
tstromberg
approved these changes
Jun 25, 2020
|
kvm2 Driver Times for Minikube (PR 8552): [67.268643208 61.53745453399999 63.500490506000006] Averages Time Per Log docker Driver Times for Minikube (PR 8552): [25.677865813 24.911623059 25.185663239000004] Averages Time Per Log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an easy way to improve overhead -- we don't need 2 coredns pods running by default. If a user wants more, they can easily scale the deployment up with
kubectlit won't make a huge difference alone, but in combination with some other PRs I'll be opening it should get us to our goal of 20% reduction
#5682