Make waiting for Host configurable via --wait-timeout flag #8948

kadern0 · 2020-08-10T06:41:06Z

Signed-off-by: Pablo Caderno kaderno@gmail.com

@sharifelgamal can you have a look at this?

would close this #8961

Signed-off-by: Pablo Caderno <kaderno@gmail.com>

k8s-ci-robot · 2020-08-10T06:41:14Z

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-08-10T06:41:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadern0
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2020-08-10T06:47:10Z

Travis tests have failed

Hey @kadern0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="3a2c0734923ba3441fe01b833988433324c2b5f4" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.29.0'
golangci/golangci-lint info found version: 1.29.0 for v1.29.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/minikube/machine/cluster_test.go:67: File is not `goimports`-ed (goimports)
	Name:      viper.GetString("profile"),
	Driver:    driver.Mock,
	DockerEnv: []string{"MOCK_MAKE_IT_PROVISION=true"},
	Nodes:     []config.Node{{Name: "minikube"}},
Makefile:389: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 4f1de570-dad5-11ea-bee2-571e9d389dd6

minikube-bot · 2020-08-10T06:48:03Z

Can one of the admins verify this patch?

pkg/minikube/machine/start.go

cmd/minikube/cmd/start_flags.go

pkg/minikube/machine/start.go

medyagh

this PR is doing the right thing by increasing the startHost timeout as I seen it in sometimes time out for hyperv in nested virtualization.

but I would like this to use the same flag
--wait-timeout so basically that would be the Max Wait for everything minikube waits on
Start Host or Kubernetes components

Set default value if not specified by the user. Signed-off-by: Pablo Caderno <kaderno@gmail.com>

Signed-off-by: Pablo Caderno <kaderno@gmail.com>

TravisBuddy · 2020-08-11T09:12:24Z

Travis tests have failed

Hey @kadern0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.2 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="c014a201d12c4437ae966ce6dcf1ad301cff1e23" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v2" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200810185219-7d42fed1b770
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading k8s.io/kubernetes v1.17.3
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading k8s.io/api v0.17.3
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading k8s.io/kubectl v0.17.3
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading go.uber.org/zap v1.10.0
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading golang.org/x/text v0.3.2
go: downloading go.opencensus.io v0.22.3
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/imdario/mergo v0.3.9
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/spf13/pflag v1.0.5
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading go.uber.org/atomic v1.4.0
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading k8s.io/component-base v0.17.3
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/json-iterator/go v1.1.9
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/golang/protobuf v1.4.2
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
ERROR: logging before flag.Parse: I0811 09:10:22.483149   12231 translate.go:106] Setting Language to en-US ...
--- FAIL: TestGenerateDocs (0.01s)
    --- FAIL: TestGenerateDocs/start (0.00s)
        generate-docs_test.go:47: Docs are not updated. Please run `make generate-docs` to update commands documentation:   strings.Join({
              	... // 9591 identical bytes
              	" daemon\n      --service-cluster-ip-range string   The CIDR to be",
              	" used for service cluster IPs. (default \"10.96.0.0/12\")\n      --",
            - 	"uuid string ",
            + 	"starthost-timeout duration        max time to wait per host to s",
            + 	"tart. (default 4m0s)\n      --uuid string ",
              	"                      Provide VM UUID to restore MAC address (hy",
              	"perkit driver only)\n      --vm                                Fi",
              	... // 392 identical bytes
              	" 'none', 'true' and 'false' (default [apiserver,system_pods])\n  ",
              	"    --wait-timeout duration             max time to wait per Kub",
            + 	"ernet",
              	"e",
            - 	"rnetes or host",
            + 	"s core services",
              	" to be healthy. (default 6m0s)\n```\n\n### Options inherited from p",
              	"arent commands\n\n```\n      --alsologtostderr                  log",
              	... // 903 identical bytes
              }, "")
E0811 09:10:26.840056   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E0811 09:10:26.840427   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E0811 09:10:26.840524   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=localhost:3128 to docker env.
E0811 09:10:26.840694   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=localhost:3128 to docker env.
E0811 09:10:26.840789   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=http://localhost:3128 to docker env.
E0811 09:10:26.840969   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=http://localhost:3128 to docker env.
E0811 09:10:26.841044   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
E0811 09:10:26.841226   12231 out.go:144] [unset errFile]: ! Not passing HTTP_PROXY=http://127.0.0.1:3128 to docker env.
FAIL
coverage: 18.7% of statements
FAIL	k8s.io/minikube/cmd/minikube/cmd	4.453s
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.043s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.075s	coverage: 52.5% of statements
ok  	k8s.io/minikube/pkg/drivers	0.007s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.011s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.011s	coverage: 0.0% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.029s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.850s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.100s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.010s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.005s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.073s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.022s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.174s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.046s	coverage: 36.7% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.029s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.020s	coverage: 34.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.006s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.022s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.033s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.004s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.036s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.498s	coverage: 39.2% of statements
ok  	k8s.io/minikube/pkg/minikube/mustload	0.066s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.019s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.057s	coverage: 58.7% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.008s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.149s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.012s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 68.7% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.009s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.077s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.009s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.027s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.050s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.649s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.759s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.008s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 32

TravisBuddy Request Identifier: c2a61f70-dbb2-11ea-bc40-19e33457b5db

medyagh

Thank you for this PR

Added startHostTimeout flag

37a1d3b

Signed-off-by: Pablo Caderno <kaderno@gmail.com>

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2020

k8s-ci-robot requested review from josedonizetti and RA489 August 10, 2020 06:41

sharifelgamal reviewed Aug 10, 2020

View reviewed changes

pkg/minikube/machine/start.go Show resolved Hide resolved

medyagh requested changes Aug 10, 2020

View reviewed changes

cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved

medyagh requested changes Aug 10, 2020

View reviewed changes

pkg/minikube/machine/start.go Show resolved Hide resolved

medyagh requested changes Aug 10, 2020

View reviewed changes

kadern0 added 2 commits August 11, 2020 19:05

Removed extra flag add.

9354d2c

Set default value if not specified by the user. Signed-off-by: Pablo Caderno <kaderno@gmail.com>

updated documentation

0d7686a

Signed-off-by: Pablo Caderno <kaderno@gmail.com>

medyagh changed the title ~~WIP: Added startHostTimeout flag~~ Added startHostTimeout flag Aug 11, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2020

medyagh approved these changes Aug 11, 2020

View reviewed changes

medyagh merged commit 8b6a0eb into kubernetes:master Aug 11, 2020

medyagh changed the title ~~Added startHostTimeout flag~~ make start host timeout configurable Aug 12, 2020

medyagh changed the title ~~make start host timeout configurable~~ Make waiting for Host configurable via --wait-timeout flag Aug 12, 2020

fmotrifork mentioned this pull request Aug 13, 2020

minikube 1.12.3 fishworks/fish-food#893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make waiting for Host configurable via --wait-timeout flag #8948

Make waiting for Host configurable via --wait-timeout flag #8948

kadern0 commented Aug 10, 2020 •

edited by medyagh

k8s-ci-robot commented Aug 10, 2020

k8s-ci-robot commented Aug 10, 2020

TravisBuddy commented Aug 10, 2020

minikube-bot commented Aug 10, 2020

medyagh left a comment •

edited

TravisBuddy commented Aug 11, 2020

medyagh left a comment

Make waiting for Host configurable via --wait-timeout flag #8948

Make waiting for Host configurable via --wait-timeout flag #8948

Conversation

kadern0 commented Aug 10, 2020 • edited by medyagh

k8s-ci-robot commented Aug 10, 2020

k8s-ci-robot commented Aug 10, 2020

TravisBuddy commented Aug 10, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 4f1de570-dad5-11ea-bee2-571e9d389dd6

minikube-bot commented Aug 10, 2020

medyagh left a comment • edited

Choose a reason for hiding this comment

TravisBuddy commented Aug 11, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: c2a61f70-dbb2-11ea-bc40-19e33457b5db

medyagh left a comment

Choose a reason for hiding this comment

kadern0 commented Aug 10, 2020 •

edited by medyagh

medyagh left a comment •

edited