New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install minikube with homebrew on Linux #9066
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inductor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @priyawadhwa |
Codecov Report
@@ Coverage Diff @@
## master #9066 +/- ##
=======================================
Coverage 31.55% 31.55%
=======================================
Files 166 166
Lines 11356 11356
=======================================
Hits 3583 3583
Misses 7348 7348
Partials 425 425 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with this PR that has added homebrew as a new paragraph, making the Getting Started Guide look more complicated.
if you think adding brew would add a lot of value, I recommend at least adding it in the end
and with same format as others
## Homebrew install
brew install minikube
no need to say if homebrew is installed....the shorter the Getting Started Page be the better
but overall I dont think we really need to add homebrew installation for linux.
Sure, but I do not think the format is h2(with ##) and ### Debian package
### RPM package Also, I borrowed the "if homebrew installed" from the macOS installation. Should I remove that line too? I didn't think it was redundant because Linux and macOS are in different tabs anyway. |
brew install minikube | ||
``` | ||
|
||
If `which minikube` fails after installation via brew, you may have to remove the minikube cask and link the binary: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rather we keep this first page short, about creating a full page for all the possible installation for linux, and then from here
that says
for hombrew and full notes see ...(link)
Worked fine here, defintely better than the other mess... (the binary, and deb and rpm "hacks") Binary download
Debian package
RPM package
Linux brew
Zero Install
Even with the long command lines of the first three, they still fail to verify the checksums. |
Yeah, that's actually the biggest motivation for this Pull Request! |
However, the sheer amount of text / different environments is also a problem with the install page. It is nowhere as bad as the podman/cri-o pages, with dozens and dozens of distributions, but still... https://kubernetes.io/docs/tasks/tools/install-kubectl/ You know, the alternative to |
@inductor : actually we do recommend using https://kubernetes.io/docs/tasks/tools/install-minikube/
In this text, docker/podman qualifies as "hypervisor" too. But the wording is somewhat different, for the recommendation: macOS: "The easiest way to install Minikube on macOS is using Homebrew" And the package text is actually even less helpful than above:
But we should open a proper issue for this, rather than just chat in the PR.... |
I am actually from SIG-Docs 😅 |
I think the original idea (add brew) was OK, just formatting...
So it is mostly about fiddling the order around, and improving wording. It is also somewhat complicated, compared to a big Download button... |
The comment from @medyagh was that adding brew would make the Linux list too long. Maybe nested tabs would fix, but I'm not sure about that approach either - if it even works ? But it would be nice to come up with some way to "squash" rpm/yum deb/apt into the others... So that there was just one "binary download" and one "package manager" entry, for Linux ? I guess anything is better than the auto-generated release page though: https://github.com/kubernetes/minikube/releases/tag/v1.12.3 (34 assets) |
I think it's already nested |
I can only see one layer, but nested tabs is probably evil (and I'm not sure if Hugo allows it) Theoretically one could put DEB and RPM tabs, like is being done for kubectl/kubeadm now: But then there would be a distro tab inside an operating system tab, and it would be ugly. And of course trying to get apt and yum working is like a whole class of fail on its own... We could of course "untab" the OS, but then the page would be longer rather than shorter ? |
@priyawadhwa : we don't usually have priorities on PRs, so if we don't want to merge it as-is we need a backlog issue (for brew) @medyagh : maybe we can discuss it on the next meeting, if you think that the Linux install page is indeed becoming too long ? At the very least, we should probably work with @inductor and others to make the two install pages a bit more similar than now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with adding home brew as an option but i would like to know first, who Maintains this minikube homebrew for linux ?
is it an automatic process to ensure we have brew for linux ? does that mean whenever we update the mac homebrew they automatically add linux version too ? till I dont know the details I am not comfortable merging this
and also we dont need the extra lines that says if it didnt work do this or that. first page should be as short as possible. u can have a Link to another page that says for more info see... (homebrew links)
It is the same package: https://github.com/Homebrew/homebrew-core/commits/master/Formula/minikube.rb https://github.com/Homebrew/linuxbrew-core/commits/master/Formula/minikube.rb Basically only header changes: class Minikube < Formula
desc "Run a Kubernetes cluster locally"
homepage "https://minikube.sigs.k8s.io/"
url "https://github.com/kubernetes/minikube.git",
tag: "v1.14.0",
revision: "b09ee50ec047410326a85435f4d99026f9c4f5c4"
license "Apache-2.0"
head "https://github.com/kubernetes/minikube.git"
... And then the build system builds the binaries ("bottles") from the source ("formulas") So homebrew is not using the same binaries as available on the github download page. They call that "cask", when speaking in 🍺 (it was used earlier, in #5081) It (brew cask install minikube) was also the reason for those cleanup tasks. |
@inductor: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We close this for now, Brew and Arch are still available - even if undocumented "upstream". https://formulae.brew.sh/formula/minikube https://www.archlinux.org/packages/community/x86_64/minikube/ Thanks for your contribution! Maybe a future version of Getting Started will feature them... |
Homebrew has supported Linux since a while ago and I've been using it on my Linux environment too :)