Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect more CPU/disk/memory metrics #410

Merged
merged 4 commits into from Feb 6, 2020
Merged

Conversation

xueweiz
Copy link
Contributor

@xueweiz xueweiz commented Feb 1, 2020

This PR adds more CPU/disk/memory metrics:

  • cpu_runnable_task_count: helps detecting CPU pressure by measuring the number of "active" tasks on the node
  • cpu_usage_time: helps detecting CPU pressure by measuring the CPU usage state breakdown (system v.s. user v.s. irq...)
  • disk_operation_count: helps detecting disk IO pressure pattern (together with the 3 metrics below)
  • disk_merged_operation_count
  • disk_operation_bytes_count
  • disk_operation_time
  • disk_bytes_used: helps detecting disk space insufficiency
  • memory_bytes_used: helps detecting memory pressure via breaking down memory usage by their state (buffer, cache, slab...)
  • memory_anonymous_used: helps detecting swap related problems (which could be related to disk IO pressure and memory pressure)
  • memory_page_cache_used: helps detecting page cache related problems (slow reads, disk IO pressure, memory pressure)
  • memory_unevictable_used: helps detecting swap related problems
  • memory_dirty_used: helps detecting filesystem and disk IO pressure

The details are documented in the README for system stats monitor. See a preview here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 1, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2020
@xueweiz
Copy link
Contributor Author

xueweiz commented Feb 1, 2020

/assign @wangzhen127
/cc @kewu1992
/cc @vaibhav-rustagi

@k8s-ci-robot
Copy link
Contributor

@xueweiz: GitHub didn't allow me to request PR reviews from the following users: kewu1992, vaibhav-rustagi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @wangzhen127
/cc @kewu1992
/cc @vaibhav-rustagi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xueweiz xueweiz force-pushed the stats branch 2 times, most recently from 6fe74c5 to 7c69e9b Compare February 3, 2020 23:17
@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [wangzhen127,xueweiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 450c6c3 into kubernetes:master Feb 6, 2020
@xueweiz
Copy link
Contributor Author

xueweiz commented Feb 6, 2020

Thanks a lot for the review Zhen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants