Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update powershell command for uptime to help efficiency #612

Merged
merged 1 commit into from
Aug 21, 2021
Merged

Update powershell command for uptime to help efficiency #612

merged 1 commit into from
Aug 21, 2021

Conversation

mcshooter
Copy link
Contributor

@mcshooter mcshooter commented Aug 18, 2021 •
edited

When uptime function is called, we make a powershell query to trace through all the WinEvents. To attempt to make this call a little efficient, we will attempt to grab the process ID of the service (if it is running) and query the starttime based off of that. This will prevent the extensive querying that we do when calling Get-WinEvent. This only takes care of the case if the service is still running and an issue is detected.

If the Process ID does not exist and the service seems to have stopped running, then we will result to using the Get-WinEvent querying approach with an additional filter. I added an additional filter to filter not only by the logname=system but to also filter on event id=7036 to reduce the number of entries the next command Where-Object will have to look through. It seems that all messages indicating a stopped or running service will have the event id=7036.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mcshooter. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2021
@mcshooter
Copy link
Contributor Author

cc/ @ibabou

@mcshooter
Copy link
Contributor Author

cc/ @pjh

@mcshooter
Copy link
Contributor Author

/sig node
/sig windows
/priority important-soon
/ok-to-test

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 19, 2021
@k8s-ci-robot
Copy link
Contributor

@mcshooter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/sig node
/sig windows
/priority important-soon
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Random-Liu
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2021
@ibabou
Copy link

ibabou commented Aug 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
pjh
pjh reviewed Aug 19, 2021
View reviewed changes
Copy link

@pjh pjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question.

pkg/healthchecker/health_checker_windows.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2021
@mcshooter
Copy link
Contributor Author

/retest

Random-Liu
Random-Liu reviewed Aug 21, 2021
View reviewed changes
pkg/healthchecker/health_checker_windows.go
@@ -33,12 +33,19 @@ import (
// getUptimeFunc returns the time for which the given service has been running.
func getUptimeFunc(service string) func() (time.Duration, error) {
return func() (time.Duration, error) {
// Using the WinEvent Log Objects to find the Service logs' time when the Service last entered running state.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need uptime if we already know that the service is not running?

Maybe we can just return a known error or uptime value to indicate that the service is not running?

And from the caller side, it should treat the service as not healthy in that case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that, we may not even need the first fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline discussed, the uptime is still needed to calculate the cooldown even if the service is not running.

@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibabou, mcshooter, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3c3609b into kubernetes:master Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Random-Liu left review comments

@pjh pjh pjh requested changes

@ibabou ibabou ibabou approved these changes

Assignees

@Random-Liu Random-Liu

@ibabou ibabou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mcshooter @k8s-ci-robot @Random-Liu @ibabou @pjh