Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing build arg in build-in-docker make target #780

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix missing build arg in build-in-docker make target #780

merged 1 commit into from
Aug 2, 2023

Conversation

btiernay
Copy link
Contributor

@btiernay btiernay commented Jul 7, 2023

Fixes #778

Before:
image

After:
image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @btiernay. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2023
@mmiranda96
Copy link
Contributor

Thanks for the fix!

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@btiernay
Copy link
Contributor Author

btiernay commented Jul 7, 2023

/retest-required

@mmiranda96
Copy link
Contributor

Tests are failing due to kubernetes/test-infra#29751, let's fix that and then this should not be an issue any longer.

@btiernay
Copy link
Contributor Author

@mmiranda96 kubernetes/test-infra#29751 is merged, but yet this still fails. I'm rebased on upstream master. Any ideas?

@mmiranda96
Copy link
Contributor

Yes, this is a known issue: kubernetes/kubernetes#119211.

We're working on fixing it, apologies for any inconveniences caused.

@mmiranda96
Copy link
Contributor

/retest-all

@mmiranda96
Copy link
Contributor

/retest

@btiernay
Copy link
Contributor Author

btiernay commented Aug 2, 2023

Green bill of health 👍. @mmiranda96 Are you good to approve?

@mmiranda96
Copy link
Contributor

I can't approve PRs unfortunately.

Varsha, could you help us approve this change?

/assign @vteratipally

@vteratipally
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: btiernay, mmiranda96, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5953ba1 into kubernetes:master Aug 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmiranda96 mmiranda96 Awaiting requested review from mmiranda96

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@mmiranda96 mmiranda96

@vteratipally vteratipally

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make build-in-docker fails with unbound BASEIMAGE build arg
4 participants
@btiernay @k8s-ci-robot @mmiranda96 @vteratipally